From: Muchun Song <muchun.song@linux.dev>
To: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org, chris@zankel.net,
jcmvbkbc@gmail.com, maobibo@loongson.cn
Subject: Re: [PATCH] mm: fix misuse of update_mmu_cache() in do_anonymous_page()
Date: Sun, 25 Sep 2022 09:43:34 +0800 [thread overview]
Message-ID: <3A09E40A-E2C5-4C6F-8550-DD0E17B7DAB9@linux.dev> (raw)
In-Reply-To: <20220924053239.91661-1-zhengqi.arch@bytedance.com>
> On Sep 24, 2022, at 13:32, Qi Zheng <zhengqi.arch@bytedance.com> wrote:
>
> As message in commit 7df676974359 ("mm/memory.c: Update local TLB
> if PTE entry exists") said, we should update local TLB only on the
> second thread. So fix the misuse of update_mmu_cache() by using
> update_mmu_tlb() in the do_anonymous_page().
>
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
The change looks good to me. However, I am not sure what is the user-visible
effect to xtensa users. So Cc xtensa’s maintainer and the author of 7df676974359
to double check this.
But anyway:
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
next prev parent reply other threads:[~2022-09-25 1:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 5:32 Qi Zheng
2022-09-25 1:43 ` Muchun Song [this message]
2022-09-26 8:32 ` David Hildenbrand
2022-09-26 8:41 ` Qi Zheng
2022-09-26 8:42 ` David Hildenbrand
2022-09-26 8:47 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A09E40A-E2C5-4C6F-8550-DD0E17B7DAB9@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maobibo@loongson.cn \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox