From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10DFFC7115B for ; Mon, 23 Jun 2025 14:13:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A17DC6B00C5; Mon, 23 Jun 2025 10:13:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C8D06B00C6; Mon, 23 Jun 2025 10:13:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 891256B00C7; Mon, 23 Jun 2025 10:13:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7687B6B00C5 for ; Mon, 23 Jun 2025 10:13:24 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3C8A059D81 for ; Mon, 23 Jun 2025 14:13:24 +0000 (UTC) X-FDA: 83586857928.05.27B4BB2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id C5FDA4000C for ; Mon, 23 Jun 2025 14:13:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=U5ZqaRt2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="rVexpCh/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=U5ZqaRt2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="rVexpCh/"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750688002; a=rsa-sha256; cv=none; b=3E0zkmW785R0mwtKJm+HRD6aPQFWp/ByEBa46DT3C4KcTefcHCORpBgae1629peQjgoMOS QgH2a3iNz/W0yi5VtmHPQr0jVn0slIMKoKO7ZsDqvGKVSbYjd1n51jYk4mMpz8FzKrqUlI l1zfv4QKiWi6w0atTfLuGdUxGIK8ttk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=U5ZqaRt2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="rVexpCh/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=U5ZqaRt2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="rVexpCh/"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750688002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lADc/8kE752BhxoOtNBA4BLJ16fQqPkxmPRbOD7u0sc=; b=7Nt6aFqPe/5Vwd9/ph1k4c5bAluxDNBkg9EGAOm9lEG3nioGgNaWMpJHgh+geJq+a3ajjc NAgxnL2dzGFL6uTIPdFH13SazrMaMPWcnpz758XuH0KJzVl/48eSsxHEYpK0V9Mvz9MEHk Px8zBlE5Zizuu+OhyOY7ajEeNzfhj2o= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 347F021179; Mon, 23 Jun 2025 14:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750688000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lADc/8kE752BhxoOtNBA4BLJ16fQqPkxmPRbOD7u0sc=; b=U5ZqaRt2aDokyJJ2YZQahJs3bQHTkXIYqXhfdR5mGYhHt9JYMNOgWZEmgXRRHRfpToNDwf sHTQFpQdxMQK9flAUSvFHm20CCoM7fIoX9CeTCI7y8p3GkwtMmFgUB+Cel/XOFicoCM7BF AZoZeOVGzecueNsF0oN050bwdGzH7LI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750688000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lADc/8kE752BhxoOtNBA4BLJ16fQqPkxmPRbOD7u0sc=; b=rVexpCh/kQH0BW5jRIKacs1JBvPI1Ca52kZ9vhQAMqd41mhS3pga2UIlU6BTt52bFVA7Ej IxHI/9H+wxf74RBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750688000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lADc/8kE752BhxoOtNBA4BLJ16fQqPkxmPRbOD7u0sc=; b=U5ZqaRt2aDokyJJ2YZQahJs3bQHTkXIYqXhfdR5mGYhHt9JYMNOgWZEmgXRRHRfpToNDwf sHTQFpQdxMQK9flAUSvFHm20CCoM7fIoX9CeTCI7y8p3GkwtMmFgUB+Cel/XOFicoCM7BF AZoZeOVGzecueNsF0oN050bwdGzH7LI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750688000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lADc/8kE752BhxoOtNBA4BLJ16fQqPkxmPRbOD7u0sc=; b=rVexpCh/kQH0BW5jRIKacs1JBvPI1Ca52kZ9vhQAMqd41mhS3pga2UIlU6BTt52bFVA7Ej IxHI/9H+wxf74RBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0F91313485; Mon, 23 Jun 2025 14:13:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id f0d3AwBhWWhxYAAAD6G6ig (envelope-from ); Mon, 23 Jun 2025 14:13:20 +0000 Message-ID: <39f95eb9-c494-4967-8d4d-9768200637f4@suse.cz> Date: Mon, 23 Jun 2025 16:13:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass Content-Language: en-US To: Shivank Garg , David Hildenbrand , akpm@linux-foundation.org, brauner@kernel.org, paul@paul-moore.com, rppt@kernel.org, viro@zeniv.linux.org.uk Cc: seanjc@google.com, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20250620070328.803704-3-shivankg@amd.com> <3114d54f-ed7c-4c68-9d32-53ce04175556@amd.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <3114d54f-ed7c-4c68-9d32-53ce04175556@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C5FDA4000C X-Rspamd-Server: rspam10 X-Stat-Signature: 7nff8kgwj8ryrpnaei58cacsoeme3ajf X-HE-Tag: 1750688001-67505 X-HE-Meta: U2FsdGVkX1/3fk4+MPybThdLYysSUit18Ci8J7+WVnqbEOYkW6gOSB5LPo0AWPjJWnSVSBAH+dhkXVZ9uRrzZv1o4xeLfvWHGaYedwqq9ImEfN1D2jNYGOq14r1rN3HHk5zh26a2cdxRSM8xumM/PLWl/2t1Mrss5LagWolmbbBQzjEJLreXle3y1R4qY6jDORpCl+GdjbwlopYuDDgy4QfSM5hDSwRMOEUrAzFaX0JdH6fvyO3grLfkVPblCvExyTtQHFzgrS77JVomErL2VUzCAU6sRACCUhJLXWaU1Eh2VN1nS/Mj7BIQOWySby+pWX7Xu8gfGqVpht5IELOswzbM7lCFuRMB3NraMFdibQzD1z4nJD28x5Jh16oQInmgdCuqT0C/GfunAMEDCc0cGO099xcmER88UR7I/qmOCO4T2NHyPQwQRDimuneZtaeCt9NZSAUvAHTt35ujaGmsfe9poIdLVH80Iv11kxxtMRHi80qLNJ1SBG/nfkHgqs1OCNbU+qbUW4wUAq281ehDBxlUAwmnOgwc5WVIs/+NRJWnEw+bWKegljZm9t71fCMUm7V3pY7YTFeU3WjZ8pOBNfFKgJWPWxEHrgo4lLpqK5rN45zeJ4xfvaRlDXuwDbYpsmtv2hoF0Srgm/6rj1U3uB8aVs13Z/5HYca5aICswtdOm/NkMt5Wl53gUpDNcklZJbiO7XFWorXC48oJq8VLRwjfyS/vVA0eHiB9d5nqns9VUp5Hmv1iBeQ7ChrK0/rwt0TJgvfozZ7LLpP0LqzsIJRHAEna0zeuyeJu8/RSk3RL+exiBTRzvVsfI2h00WkM3KB6V+vURwVbQZhsdA2mRdBAOoiGeFN347MW/28mKOLiXwnjaYCjE137rFlFYo9TZWXmpJ9Bel+aWHOpj4OZM3IKOvjOcAXQL2bRH6L7VmcsXQ9kXSrmdv9LX3OCVjo9jZ6/JMqV6jQMLaQxcs1 f98CsMzk 9CCEnuoK8oyn2vwUueGBJGh7BOBr03vDGcMxeTDS1LTzI/beRXvhKoFSSpw0Ye3lWDVXlWfBM1RMLy9DndbHCmIgf3mvHOKwjy3fvOSCp3UeiFwo1EqL4/VEHmN++xVqe0ewpCs+rVwyhGyc4xd1JG6j9+zGJUeUyqOwv7n7gWjVni6KdY5GjZx2DwydWkdjZVAv88KkHf9k23DxwEKuFCSBrrNasxcMt7Xlhc1+5FnT+6q5JkqDgAFPXZRFTwhkLS477Avzxfa958K0k2jCuhFmudEk4qDZwPK9RNqG+S4jcc5QXMY3ZhMVK19TxXG3xGsoHpeKMf2PeYocStbU6m3NuO/itZNYc/Yqwlayt6td5ynGgDQ0eny2zgWtbo7E0wQ4puSE5ljqFdZpJXFKkN7JKhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/23/25 16:08, Shivank Garg wrote: > > > On 6/23/2025 7:21 PM, David Hildenbrand wrote: >> On 20.06.25 09:03, Shivank Garg wrote: >>> Export anon_inode_make_secure_inode() to allow KVM guest_memfd to create >>> anonymous inodes with proper security context. This replaces the current >>> pattern of calling alloc_anon_inode() followed by >>> inode_init_security_anon() for creating security context manually. >>> >>> This change also fixes a security regression in secretmem where the >>> S_PRIVATE flag was not cleared after alloc_anon_inode(), causing >>> LSM/SELinux checks to be bypassed for secretmem file descriptors. >>> >>> As guest_memfd currently resides in the KVM module, we need to export this >>> symbol for use outside the core kernel. In the future, guest_memfd might be >>> moved to core-mm, at which point the symbols no longer would have to be >>> exported. When/if that happens is still unclear. >>> >>> Fixes: 2bfe15c52612 ("mm: create security context for memfd_secret inodes") >>> Suggested-by: David Hildenbrand >>> Suggested-by: Mike Rapoport >>> Signed-off-by: Shivank Garg >> >> >> In general, LGTM, but I think the actual fix should be separated from exporting it for guest_memfd purposes? >> >> Also makes backporting easier, when EXPORT_SYMBOL_GPL_FOR_MODULES does not exist yet ... >> > I agree. I did not think about backporting conflicts when sending the patch. > > Christian, I can send it as 2 separate patches to make it easier? The proper way is to send the fix without the export, and then add the export only when adding its user. > Thanks, > Shivank