* [PATCH] mm/pagewalk: use min() to simplify the code
@ 2026-01-20 9:49 zenghongling
2026-01-20 10:41 ` Lorenzo Stoakes
2026-01-21 12:05 ` David Hildenbrand (Red Hat)
0 siblings, 2 replies; 3+ messages in thread
From: zenghongling @ 2026-01-20 9:49 UTC (permalink / raw)
To: akpm, david, lorenzo.stoakes, Liam.Howlett, vbabka, rppt, surenb, mhocko
Cc: linux-kernel, linux-mm, zhongling0719, zenghongling
Use the min() macro to simplify the function and improve
its readability.
Signed-off-by: zenghongling <zenghongling@kylinos.cn>
---
mm/pagewalk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/pagewalk.c b/mm/pagewalk.c
index 9f91cf85a5be..82db421b5b34 100644
--- a/mm/pagewalk.c
+++ b/mm/pagewalk.c
@@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
unsigned long end)
{
unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);
- return boundary < end ? boundary : end;
+ return min(boundary, end);
}
static int walk_hugetlb_range(unsigned long addr, unsigned long end,
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/pagewalk: use min() to simplify the code
2026-01-20 9:49 [PATCH] mm/pagewalk: use min() to simplify the code zenghongling
@ 2026-01-20 10:41 ` Lorenzo Stoakes
2026-01-21 12:05 ` David Hildenbrand (Red Hat)
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Stoakes @ 2026-01-20 10:41 UTC (permalink / raw)
To: zenghongling
Cc: akpm, david, Liam.Howlett, vbabka, rppt, surenb, mhocko,
linux-kernel, linux-mm, zhongling0719
On Tue, Jan 20, 2026 at 05:49:32PM +0800, zenghongling wrote:
> Use the min() macro to simplify the function and improve
> its readability.
>
> Signed-off-by: zenghongling <zenghongling@kylinos.cn>
LGTM, other than nit below (Andrew, maybe you can insert a newline there?) so:
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> mm/pagewalk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/pagewalk.c b/mm/pagewalk.c
> index 9f91cf85a5be..82db421b5b34 100644
> --- a/mm/pagewalk.c
> +++ b/mm/pagewalk.c
> @@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
> unsigned long end)
> {
> unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);
Nit: Ideally we'd introduce a space between decl and statement below.
> - return boundary < end ? boundary : end;
> + return min(boundary, end);
> }
>
> static int walk_hugetlb_range(unsigned long addr, unsigned long end,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/pagewalk: use min() to simplify the code
2026-01-20 9:49 [PATCH] mm/pagewalk: use min() to simplify the code zenghongling
2026-01-20 10:41 ` Lorenzo Stoakes
@ 2026-01-21 12:05 ` David Hildenbrand (Red Hat)
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand (Red Hat) @ 2026-01-21 12:05 UTC (permalink / raw)
To: zenghongling, akpm, lorenzo.stoakes, Liam.Howlett, vbabka, rppt,
surenb, mhocko
Cc: linux-kernel, linux-mm, zhongling0719, Sahil Chandna
On 1/20/26 10:49, zenghongling wrote:
> Use the min() macro to simplify the function and improve
> its readability.
>
> Signed-off-by: zenghongling <zenghongling@kylinos.cn>
> ---
> mm/pagewalk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/pagewalk.c b/mm/pagewalk.c
> index 9f91cf85a5be..82db421b5b34 100644
> --- a/mm/pagewalk.c
> +++ b/mm/pagewalk.c
> @@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
> unsigned long end)
> {
> unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);
> - return boundary < end ? boundary : end;
> + return min(boundary, end);
There was a length discussion recently about changing this code:
https://lore.kernel.org/linux-mm/35ab82f052d248c0047c10bf01853e37e4f9b4e4.1764312627.git.chandna.sahil@gmail.com/
Changing the min only LGTM.
Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
--
Cheers
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-21 12:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-20 9:49 [PATCH] mm/pagewalk: use min() to simplify the code zenghongling
2026-01-20 10:41 ` Lorenzo Stoakes
2026-01-21 12:05 ` David Hildenbrand (Red Hat)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox