From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEBA8C433DB for ; Mon, 15 Mar 2021 15:27:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 530B764E45 for ; Mon, 15 Mar 2021 15:27:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 530B764E45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E6E4C6B0072; Mon, 15 Mar 2021 11:27:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1BD36B0073; Mon, 15 Mar 2021 11:27:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBD686B0074; Mon, 15 Mar 2021 11:27:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id AD3146B0072 for ; Mon, 15 Mar 2021 11:27:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 69449181AF5F4 for ; Mon, 15 Mar 2021 15:27:19 +0000 (UTC) X-FDA: 77922487398.04.CDB45FD Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by imf23.hostedemail.com (Postfix) with ESMTP id B9B20A06F40E for ; Mon, 15 Mar 2021 15:13:53 +0000 (UTC) Received: by mail-oi1-f174.google.com with SMTP id x78so34849091oix.1 for ; Mon, 15 Mar 2021 08:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MvLffGY2PDS6HPT4gIfMBvNzZ4NCk1hS/akJFXwFv14=; b=dbLAM1WhoHTn5xOOeGVbScgJG8gKQo/OU/0p6mPUVY8/4ztpqRilTab/zD2yGj8jFV SZ75dAe4FSJby+OEsdztV8G6t3PwMNXiFcN/a6Ktn/7my3KQkW6FuQGOQFqLjfiVJ7f9 F85VM8OUp1CMxUf730d5r299PKD0Ro+Di0SlRDXrw3K2bxqsV+pvqUSj18U56UPe+mgt PgOKe9oq190jzbwH018/UWMDnCvztwrydvpgdfsq0ASIfniK4xBmDfu2bZORyJG5vTGT KM148mzuMsV37ZSwJ44qdikeMjx+SGTn+RpUvh78GWpH1QC6W/WYwEfSWbh1WeiQ03ZO jlLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MvLffGY2PDS6HPT4gIfMBvNzZ4NCk1hS/akJFXwFv14=; b=Tg3I6XfBeX0MFJOw0icm2TMXR/8GzDfDQpR8sj3ykC12q1uljk4m18voj6WNoMzEqD UNYR5lBQpqwC7ecTf+bISmBJrzAv2TpQM4QbJTDCQQeQA1qnoHEykdpWmtDjwcpeDdIj nQcdg6zazqnD9KPargV7TrrYoUjvsd9+cJ0bd6r58RAWaAEew1UJYrI2WQ2pzuM4arDi s7G1u8wW/NWbMVWxwzamf6ehY4UrmQELnpWNpDSt/BZNxPugLNqVZRHvH73VyGKkjno1 cndokK/mP/WorHGhXAMhl8jzT5XwOOr/vZgMGK527/RU/VeQ2wnN419bGLhObVnqWCJJ ZtOQ== X-Gm-Message-State: AOAM531kxNzFK6X/BUEsZK6rqWydc8qYYdUJF80MnkxXnL5FxZ6SHK0x PFDjrtcQFZ4gmgHNd2R8rh4= X-Google-Smtp-Source: ABdhPJx7c0SgRBxx0OuCYhCrmq64zkwdaXggmOYaaEF6EG6NupRRMnLM+tMn2QRBtFrLqaK4G9KwyA== X-Received: by 2002:a05:6808:148a:: with SMTP id e10mr18888386oiw.138.1615821232643; Mon, 15 Mar 2021 08:13:52 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.56]) by smtp.googlemail.com with ESMTPSA id f197sm7496157oob.38.2021.03.15.08.13.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Mar 2021 08:13:52 -0700 (PDT) Subject: Re: [PATCH v2 1/8] memcg: accounting for fib6_nodes cache To: Vasily Averin , cgroups@vger.kernel.org, Michal Hocko Cc: linux-mm@kvack.org, Johannes Weiner , Vladimir Davydov , Shakeel Butt , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski References: <85b5f428-294b-af57-f496-5be5fddeeeea@virtuozzo.com> From: David Ahern Message-ID: <39f3f0ba-e169-f44f-3aae-5ebaca3c42a0@gmail.com> Date: Mon, 15 Mar 2021 09:13:50 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <85b5f428-294b-af57-f496-5be5fddeeeea@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: zrq5f3t3o1hx3xdyskjzaxxywhqmta9p X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B9B20A06F40E Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail-oi1-f174.google.com; client-ip=209.85.167.174 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615821233-902202 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/21 6:23 AM, Vasily Averin wrote: > An untrusted netadmin inside a memcg-limited container can create a > huge number of routing entries. Currently, allocated kernel objects > are not accounted to proper memcg, so this can lead to global memory > shortage on the host and cause lot of OOM kiils. > > One such object is the 'struct fib6_node' mostly allocated in > net/ipv6/route.c::__ip6_ins_rt() inside the lock_bh()/unlock_bh() section: > > write_lock_bh(&table->tb6_lock); > err = fib6_add(&table->tb6_root, rt, info, mxc); > write_unlock_bh(&table->tb6_lock); > > It this case is not enough to simply add SLAB_ACCOUNT to corresponding > kmem cache. The proper memory cgroup still cannot be found due to the > incorrect 'in_interrupt()' check used in memcg_kmem_bypass(). > To be sure that caller is not executed in process contxt > '!in_task()' check should be used instead > --- > mm/memcontrol.c | 2 +- > net/ipv6/ip6_fib.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Acked-by: David Ahern