From: Dave Hansen <dave.hansen@intel.com>
To: Baoquan He <bhe@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
pagupta@redhat.com
Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v4 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing
Date: Thu, 7 Jun 2018 15:47:05 -0700 [thread overview]
Message-ID: <39ec4f7c-2ef8-aaef-7034-e1f895eeb283@intel.com> (raw)
In-Reply-To: <20180521101555.25610-3-bhe@redhat.com>
On 05/21/2018 03:15 AM, Baoquan He wrote:
> In sparse_init(), if CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER=y, system
> will allocate one continuous memory chunk for mem maps on one node and
> populate the relevant page tables to map memory section one by one. If
> fail to populate for a certain mem section, print warning and its
> ->section_mem_map will be cleared to cancel the marking of being present.
> Like this, the number of mem sections marked as present could become
> less during sparse_init() execution.
>
> Here just defer the ms->section_mem_map clearing if failed to populate
> its page tables until the last for_each_present_section_nr() loop. This
> is in preparation for later optimizing the mem map allocation.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
Acked-By: Dave Hansen <dave.hansen@intel.com>
next prev parent reply other threads:[~2018-06-07 22:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 10:15 [PATCH v4 0/4] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-05-21 10:15 ` [PATCH v4 1/4] mm/sparse: Add a static variable nr_present_sections Baoquan He
2018-06-07 22:46 ` Dave Hansen
2018-05-21 10:15 ` [PATCH v4 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing Baoquan He
2018-06-07 22:47 ` Dave Hansen [this message]
2018-05-21 10:15 ` [PATCH v4 3/4] mm/sparse: Add a new parameter 'data_unit_size' for alloc_usemap_and_memmap Baoquan He
2018-06-07 22:48 ` Dave Hansen
2018-06-08 6:27 ` Baoquan He
2018-06-08 14:20 ` Dave Hansen
2018-06-08 15:17 ` Baoquan He
2018-06-08 16:13 ` Dave Hansen
2018-06-10 23:32 ` Baoquan He
2018-05-21 10:15 ` [PATCH v4 4/4] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-06-07 22:46 ` Dave Hansen
2018-06-08 7:28 ` Baoquan He
2018-06-08 7:41 ` Baoquan He
2018-06-07 22:17 ` [PATCH v4 0/4] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ec4f7c-2ef8-aaef-7034-e1f895eeb283@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pagupta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox