From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D5D8E8180C for ; Tue, 26 Sep 2023 01:39:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06C516B013F; Mon, 25 Sep 2023 21:39:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01C086B0142; Mon, 25 Sep 2023 21:39:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4D286B0144; Mon, 25 Sep 2023 21:39:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D23076B013F for ; Mon, 25 Sep 2023 21:39:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A4764120D93 for ; Tue, 26 Sep 2023 01:39:11 +0000 (UTC) X-FDA: 81277040502.02.8942125 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf10.hostedemail.com (Postfix) with ESMTP id 7296EC0002 for ; Tue, 26 Sep 2023 01:39:09 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695692349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ffxbBgymxyqFcXGD0V2rd+eOsa1IejguSpwDFjGc4KI=; b=5X/nSLKFqh2oE1CPCcPRaruPjMQZGUL9FlXg8pkBVGjuM47yJ9rPCqXxq1IMXsMv9JD/V2 Rt20WzyQNWsRC1LP9Z/tQRpI5dXcaLvNHDBELGSDT7qB9uGwt7wwKU5XxzvLUYbRHopRzc W6xaJgnigZDDGWq+vO6BSMOLEOy14Dg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695692349; a=rsa-sha256; cv=none; b=ULpUgimgSLvjmMCULtsqeGglAfife0SbPSz+BE2kdx96eKWtldNpTHdl5BNqrPCHYxe1SO 7rGp+cZKt3BzLmGjxHEn7/hPh9kFRGYXtHvotPQ0BXcjAJq9rzfx41DfwdJqWytNc8RBv3 WOy1sLe8DtpRuJ+NfKIzSe1pXD9ctj0= Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Rvj5b0Mg1zrSdV; Tue, 26 Sep 2023 09:36:51 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 26 Sep 2023 09:39:04 +0800 Message-ID: <39e981f0-3b73-d48b-1f58-cfedab6139fe@huawei.com> Date: Tue, 26 Sep 2023 09:39:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] mm/damon/vaddr-test: Fix memory leak in damon_do_test_apply_three_regions() Content-Language: en-US To: Andrew Morton CC: , , SeongJae Park References: <20230925072100.3725620-1-ruanjinjie@huawei.com> <20230925081400.9593189a7665c6ff1f812855@linux-foundation.org> From: Ruan Jinjie In-Reply-To: <20230925081400.9593189a7665c6ff1f812855@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 7296EC0002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ryytbremmibuu4e6o19nwrx37ab3usiz X-HE-Tag: 1695692349-882267 X-HE-Meta: U2FsdGVkX1/y9tUlDpxbNCqS9T0XV6isDF4RUNXZUODvH1EggpeaT0fs0lqwaXJrV2byIbbPS/VfvuicRcqitAK252oRQF3jD0XINNqOX10M5A4lo9qdkwaA4UJGo4Rs8CLo4JiredfGFf6zskYUGxTW37IBhnDSslStx5VKarUX27lxwWbU89DSdD6Ck1i5SUtkM9CtPym4gX05KwZf7Ys6vVajUknMeA61fsFYj6fhwMRxlWcrEHIdOhwTXUqAcrBm7Zgp1ip0YnIpE55a47+qAiiGJ9YACOGYCbJv+aLBeuaqxBachrAdPQWE37n3ZQRWzano0Wrukdor+1vR2cHV13UyrL4AEBeohm0nH3Zp8oegbe6C2ggXkAZaor/Fhy46Tw82BusTku5WZ5hPRCAte2s4FwF90HkrheUEO60LkPZa2OoS/uTJ17PzGcmPKyn2C9PTgs5b9NRxSXZGi/Rylv7c3Zk1JKNaW6fkoC4v7HmEcvFezRVQtunKRHdKt/tcmyzEXZ8+DtCQTmo7mtlzeZB1rrfqUyhnBAW9TA+tQnIj7MCVdpRE7U/gou6PyP/AaIwVbhUzp+RBcm302TXOMbhn3sHrC7wKO+omwDfh0CyBJURritLjt82o8vr0hp9IqEwpHQAcrs8UPlOS4fT4UzXquP5+0qGeVfEjwO+VaMUj4aYGhpr1Y2MPfGCOkXzYbOcN5soFKiL9LdhYeZk4qOpI5PtfoV9d4Yn8LUhHJ8I61I9t3MMGzemK9Nw4TvBdcWy9cWaQv7dkxg87G8KUnHp9NsTZIbTidsH84ZLjF1+Y9HbLUwSDTBYDfAIdhEXqbOLuKbHAk5CIjz7jci/8OVbCLH2sa7mxV+dtn+dToBbbIx8CxhU2DAzxQi5ANE70K98vZkS+wB+QjzfODZNfu06TOTegM0/EB0+ju8eaTyk4hEs0f25nOHjGuu+ar5sS6Bjrs/AKQVk271+ jOJej2IR Q5FG/MxuMeG8BUXOsdbystbX6vwi8gPdOAdzJhvjmPOKWBEljJ/GbIX5AWtG/UWWd9gLOndjEgUcW6W69QPF9wm7nG0Gz2S28ND3tef5MQTq1txb2Bq0noG0u4vYorCUxPWaGMSZIb4SwrlxeRQWNVXOTiMwELZ/xdQ3xKRCtV9Uw8OWFv/uuQZ09EpYoTIkQmM6jnpq3fcZHH0Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/25 23:14, Andrew Morton wrote: > On Mon, 25 Sep 2023 15:20:59 +0800 Jinjie Ruan wrote: > >> When CONFIG_DAMON_VADDR_KUNIT_TEST=y and making CONFIG_DEBUG_KMEMLEAK=y >> and CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN=y, the below memory leak is detected. >> >> Since commit 9f86d624292c ("mm/damon/vaddr-test: remove unnecessary >> variables"), the damon_destroy_ctx() is removed, but still call >> damon_new_target() and damon_new_region(), the damon_region which is >> allocated by kmem_cache_alloc() in damon_new_region() and the damon_target >> which is allocated by kmalloc in damon_new_target() are not freed. And the >> damon_region which is allocated in damon_new_region() in >> damon_set_regions() is also not freed. >> >> So use damon_destroy_target to free all the damon_regions and damon_target. >> >> ... >> >> Fixes: 9f86d624292c ("mm/damon/vaddr-test: remove unnecessary variables") >> Fixes: dae0087aeff4 ("mm/damon/vaddr: remove damon_va_apply_three_regions()") > > Can we please identify a single Fixes: target? Otherwise, how are > -stable tree maintainers to determine which kernels need the fix? Right！Thank you. Commit dae0087aeff4 just replaces damon_va_apply_three_regions() with damon_set_regions()，not first introduce damon_set_regions(). Sorry, there is a mistake. > > I'll go with 9f86d624292c for now.