From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B0BC8303C for ; Fri, 11 Jul 2025 10:50:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C7816B00A2; Fri, 11 Jul 2025 06:50:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19F356B00A3; Fri, 11 Jul 2025 06:50:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08E106B00A4; Fri, 11 Jul 2025 06:50:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EC8166B00A2 for ; Fri, 11 Jul 2025 06:50:47 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B96DA160500 for ; Fri, 11 Jul 2025 10:50:47 +0000 (UTC) X-FDA: 83651665734.10.BA98C13 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id CA98C4000B for ; Fri, 11 Jul 2025 10:50:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hm9b+2nT; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752231044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IaNhrf1vDIB1tcZYpLbfYHlYcscO1h0tIvRYBHcyJS8=; b=wqXh0FadMYjrqnUleukLxOIeB7pe0rxsUEOwUEmRACQ4OptBNZqMlbXCOpJVmmUDmmHz24 KVoSDYZPbpWu0PGKY/uiiBsvdmEarac7SxSzUFUsZwdpiBK7oob7gu8tZCibKmIv73rNAo AokF4jqVYBt6AHvv7rUDcKkhXEjU/Yo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752231044; a=rsa-sha256; cv=none; b=em9nyNdbO7ZJW211kF2MO2FXelasuqgTpaWcS7LpJA+fNMlrC9ieS8rFkoKUB4mzAvtyat HLVT0/T+XV9o9i62tSeoRqAre4rYoKwVyh2B2JiA8a+zg5e626Em/SQ2gLMQyBG524yU+h jVA4Fdm+ReiEROBDy1EO5HseQ125ZPk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hm9b+2nT; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752231043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IaNhrf1vDIB1tcZYpLbfYHlYcscO1h0tIvRYBHcyJS8=; b=Hm9b+2nTluzunwlWi+N6OjOg/Z4RwW/ayUKAvSen/8REuz0R6zVyaBjG08zrS6P126IA/f H2dIF/4f/RSt0AcIr40sKwzpesvvxe28edhgjbVzYsrk1/eQRL/oT+SAYM2TPmfLkkV3lW AdwTj+OEXGlLXKZn3OcJL2iWUGCg4wA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-Y8X--A9XM0Caoy351_fGxg-1; Fri, 11 Jul 2025 06:50:42 -0400 X-MC-Unique: Y8X--A9XM0Caoy351_fGxg-1 X-Mimecast-MFC-AGG-ID: Y8X--A9XM0Caoy351_fGxg_1752231041 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4532514dee8so15642625e9.0 for ; Fri, 11 Jul 2025 03:50:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752231041; x=1752835841; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IaNhrf1vDIB1tcZYpLbfYHlYcscO1h0tIvRYBHcyJS8=; b=b/ptBhstyGk4jiAJYEVhuylPL5yRJkCXSdbJCq/QsMroz7bcZfIDGwFN+2AYISxc1X Aqi0Szl2Xfrg4w2s6ndsgjVk+CV0Mf2V1O0Huba7/B1TCqnJoFgTNC6ONCgupq5Sl/7F Uy4fur7zaYef1EMRQEVdmRq2NRWMsyq9QB8IUoCzat89j4LsbJM7/PJ6M0JgULMySpkN 12iB972ngAMMw0J6h1hugMiUUnhE/ULpfj8jOi/wKh02vUenU/RH/L8Np0nm6t12ZLs4 w+Ie0zuN8AuYRXiPV7mg0ZbqcGMVJ+bCy9eHehA38oCnd3SoLK7+w8Z7jseflo6KwkyU SMxg== X-Forwarded-Encrypted: i=1; AJvYcCUo6gxocgoSTlL5zRZ9Pu0tB3gzg1nM1kW78PEsuDQMDI2tfw4KlVrswc/ZkhCxl7C8swaTXI5w6Q==@kvack.org X-Gm-Message-State: AOJu0YzM1qe6LOhzVNn36t6yTa8WtmU2lEDNgrMA9EdXtiGgtX14B2X0 mQnTrucBxsjCPS7CFIqayxsiXE9wOkw3qDbqEEnxDw24JeQ1Cn7uwi5XnHu5Lgl2/k9zoZ9VyOi LsJZsyJh9bladuyKiPy0lyJqs+lnz+o4T8561xVQPtGhLHiOJjyhX X-Gm-Gg: ASbGncukFCpxv8Rb/MyY8BrZUVB/zmFvF3g0pYaWbe7UhNpvkZaC8STVfxabYKf/cWH 16T4afpEBvC7OGGl7/b97eA+CeiIzVGvWqwDNbLQ8SQ8HKyqWMCnFuDLPaopg/7xPgI/7LYmMO3 F5EkBimtaRboB0hJdositOq50Z3ajGTedEbcZXKRN1PTeF/B6S036xKPCoCSdcsU2gmvipyoTg9 iNw5vYRAvnMSlBLI82Griz2R5EhyW47w0M2Q1aOC8QfLEeTCBTO2rp7qwn5F9dyi+emgWPr6+j4 O0BfvTOmERrdR8TSlBDrZLB3OvWW2UEN8L+g/NEVN59Rreeb65/nx8d5bNZwLcd6PlN1pJ3jO2h YWnRTDicqygpr9RDyLsrUVPVjYwI2I6lnYgiwY4QAKqy8kO7Ewwv1C/GQVewn8Mwn9NI= X-Received: by 2002:a05:600c:350e:b0:450:b240:aaab with SMTP id 5b1f17b1804b1-454ec13e155mr23023415e9.8.1752231040547; Fri, 11 Jul 2025 03:50:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8U71ECaPsCVjPVmqRpdPwRIokASxhL+QMhmtfISD+bMHDtWhYaJy/EGrxKUsA5eatuAcOMA== X-Received: by 2002:a05:600c:350e:b0:450:b240:aaab with SMTP id 5b1f17b1804b1-454ec13e155mr23023185e9.8.1752231040070; Fri, 11 Jul 2025 03:50:40 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454dd439051sm44045995e9.8.2025.07.11.03.50.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 03:50:39 -0700 (PDT) Message-ID: <39cfb01a-88f2-479a-898d-cbcbb869821d@redhat.com> Date: Fri, 11 Jul 2025 12:50:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm/memory.c: Use folios in __access_remote_vm() To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , Jordan Rome , Andrew Morton References: <20250709194017.927978-3-vishal.moola@gmail.com> <20250709194017.927978-5-vishal.moola@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250709194017.927978-5-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AVq6wha3KFczy4m9ZHAz8xGBPSVo_Jr8W-GoLq7I4C8_1752231041 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CA98C4000B X-Stat-Signature: q87acarpzz86x989rkw5fjhpqyc7zq68 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752231043-609206 X-HE-Meta: U2FsdGVkX1+blrHDGNnuszpqjeVC7RAn42wdXmWQlymk5JFi9HBITTF/U0j2A9IqAaXEOMXQMPlnHIQCxgc86RVYYcqShHqCzz3x9z4sQMpu+SjqsEH9LvQQG0+XHStBifjGNmnP3We3nCgxVbbdpaYHx78v7YtJX7KyLvF45ZbA0aqObEKWLZmhLUWpxaVghtJUEYhG6H7PgzpyJzWWV+HXnS24Qjcj4OU1OzxGGvxdZMy8aFmETq8Zms9eQ+PVirhYJsaDQ8PhM4x+Pz6rwKvXao9i2Sapv80zOR2f9xSYUmI2Jpr73xKhJC1d/9nzldCvZOWtlV9jVpS1xelbXcpnsTv+ryoE9ZrAuA5Ms4hE0q08b/0LeSQtFXBUUl1drgE+y9K1sG8E2krZyH5he2j/13P9VqaYKfMxb0I9Lt4/VNxfxAsvK3Cwp+yK2srKCxqReJL/nk7Wa517FSpN+mJ+aIqh5M63yM0r7/Sv89lwenENrqVbU1SugGPmqwlqFesuGFckU0k92ilw8K9niBU/W/uGmMBwCj0xjVBU2gKjAFmmvWDMPoY3G7O7ThUSP/mvdC13v81YCc8CbyQ/ztFP45ijL1u8n0vmGmKPwZWkiOzDa2KIRvjKaxs7MHPM8sb8I7CZrL1DcSLfQYgR2re97g7/kXG1URHDb8hJpkfXpMBMWnP9AtWZMV7+G8X3xps+6VZJOy5kKbmJr1dja3JTARYRBQaHtQvbhpWMUuOloIhDPTpT3orYvu3zvuX5BgV6LxSZdfY4Xwuv2uNTAFKxivUOpy8Rs/xzvWlLfX/i1JNVHyIeuiNp8qcLzcE8DY4/rETBDTyCw2mfQ64k8mwAIp85/EqsprvkAUubZ6RR86Dmyn9MHSgagXzGrST/mLPw7YD4AIm6I7dAuSo04pVqnIkYOssOqwM9wvGAiUMkmO2qoyw9lTtHmF6czk1l50k2kxUMP9AueGNcqex S5GauR8G bUiIwlDyLvp0AVJmpJ5xZTuX352Wx2pT5/SSdAYCzWgrwIJ3I7o/K5G04DiKLC9eU46UhM9ojSe2Y9rY0DKOmNhLATZdlaxOnJcnrIJJRHpMNMA7HOeeuM0dIYag4wJMSe1UrAQ4O9yN32yyGQrS/SUEIwRBgdvdfgyrUX+X9dRSq0Zl7DQKUwcYLAT8DTpwtoJcqbSmWwyNGNdGL4BhuWQX6hgrvphNKiSPjWDN8XAg+0dUeti2gseq56q5RGfuV4qalal4iaHUoE7VpuvhXIGWK4UznDp0BmFCDH6nKyEJ3K2/IP8RnDh3qq6wjmqrkAmsrSRXK3p6CR9ovOa8n9oEmqj7uy8LeMIC5iq1WP4G5srUUsExBBYW8ocvdRPnFTkv9DTCNxM7nTkYj5vkoerABQV23oGIFGrPRccMYxI4Cg53P8e6DOBNWY4B/eF5stvdZZ4qA+HZu9Hq6wxPrJlZscw3mdwlWYwRnJlQTbMtEzrL5CSXa5ze8h7NwegLtEAPKrhpsgjpKKxnWba/VnyaKrtSbbfLwY1Zmm9EgTVohkbHljAz2BzasHV4J4GGVdegXdsBsJBY6U3fv1lEV1Bxz8pWT4ZtgncIOoUAU2S5sC7sxZ/fbfJxw/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.07.25 21:40, Vishal Moola (Oracle) wrote: > Use kmap_local_folio() instead of kmap_local_page(). > Replaces 2 calls to compound_head() with one. > > This prepares us for the removal of unmap_and_put_page(). > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/memory.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index d63f0d5abcc9..3dd6c57e6511 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -6691,6 +6691,7 @@ static int __access_remote_vm(struct mm_struct *mm, unsigned long addr, > while (len) { > int bytes, offset; > void *maddr; > + struct folio *folio; > struct vm_area_struct *vma = NULL; > struct page *page = get_user_page_vma_remote(mm, addr, > gup_flags, &vma); > @@ -6722,21 +6723,22 @@ static int __access_remote_vm(struct mm_struct *mm, unsigned long addr, > if (bytes <= 0) > break; > } else { > + folio = page_folio(page); > bytes = len; > offset = addr & (PAGE_SIZE-1); > if (bytes > PAGE_SIZE-offset) > bytes = PAGE_SIZE-offset; > > - maddr = kmap_local_page(page); > + maddr = kmap_local_folio(folio, folio_page_idx(folio, page) * PAGE_SIZE); > if (write) { > copy_to_user_page(vma, page, addr, > maddr + offset, buf, bytes); > - set_page_dirty_lock(page); > + folio_mark_dirty_lock(folio); > } else { > copy_from_user_page(vma, page, addr, > buf, maddr + offset, bytes); > } > - unmap_and_put_page(page, maddr); > + folio_release_kmap(folio, maddr); Acked-by: David Hildenbrand -- Cheers, David / dhildenb