From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB2BC4707F for ; Tue, 25 May 2021 08:02:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 52D9C613F9 for ; Tue, 25 May 2021 08:02:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52D9C613F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 334826B0075; Tue, 25 May 2021 04:02:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEFD86B007D; Tue, 25 May 2021 04:02:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77ACB6B007B; Tue, 25 May 2021 04:02:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 258A96B006C for ; Tue, 25 May 2021 04:02:37 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B3DEF1DEA for ; Tue, 25 May 2021 08:02:36 +0000 (UTC) X-FDA: 78179011512.08.F539232 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id BCFBB6000248 for ; Tue, 25 May 2021 08:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621929755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KdzzhH9MuT9PQyoXnAFbYsHqkL1GMnixyvsQG0pApvo=; b=MWevpJjBnqKN5pZuwv9swg/T4hHp1kyPcnV6y4qoVV0s+ieBi8DhHG4aek4444zeIDO/GH w9ZNazNzP/ij82/TMY/wlPPxbXb0IixleGg56VweolXbtDpdbBITTkCUr63J/IQZLDvn2L yoxSSaFuWSvZUK4JkaCKcLQrDBAbInc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-Hw7w9NkyNbWUEWNP2-DybQ-1; Tue, 25 May 2021 04:02:32 -0400 X-MC-Unique: Hw7w9NkyNbWUEWNP2-DybQ-1 Received: by mail-wr1-f70.google.com with SMTP id h22-20020adfa4d60000b029011244156c68so4220154wrb.13 for ; Tue, 25 May 2021 01:02:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=KdzzhH9MuT9PQyoXnAFbYsHqkL1GMnixyvsQG0pApvo=; b=GlrrFJSC9Jr+emBSEzEgI//wtK5v15X8sWA+9yvkGtZ4q8Ffvb+J25SsqyarH3mD+R JzIZKqhs5xcVqmxneMHMq0ay2ebwjU+/psg7SKyQAqUarEAQf9eKTPcK3vGVZRIsrRFR P9pxxF2q3Js9xGSRnUm9rtcbSVvhz3pKWJphGQAMuDeWPhAARLAdZZ5NiC3lwWkddGAb D4iFnTaBRGRLaoFRDUkCl0S8tqJxFsUBDkyZmvmJQWfkfihiae6ISuGQ7QVY09MFO1Wl gUPQ+h/+JXuPD61mRK/fm9ULomLJNQ7gkyxPeKcEIpb4tO0elYPXNp34JCF1/CRDbvO3 CJRA== X-Gm-Message-State: AOAM530+B9d5D6CDRevCydCC2n1nJb585en0ileWpbKlR/IWsVwJOfD9 FjEoODHvyEJLgC3o/CKZGoxFHq4d73hklGIqDFVK9mn6YK5GeZ8sKfSDjyCb2JNFrAoHB4QY5j+ o153N7N1tMg0= X-Received: by 2002:a5d:62cb:: with SMTP id o11mr27147134wrv.28.1621929751638; Tue, 25 May 2021 01:02:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyILXAUQzZsT2VXvr8oVAB6PdFxRbJxA8RVksfNvjtxZNA4CkQSxiw1nUjhoXCdfw35muvm8w== X-Received: by 2002:a5d:62cb:: with SMTP id o11mr27147120wrv.28.1621929751465; Tue, 25 May 2021 01:02:31 -0700 (PDT) Received: from ?IPv6:2003:d8:2f38:2400:62f4:c5fa:ba13:ac32? (p200300d82f38240062f4c5faba13ac32.dip0.t-ipconnect.de. [2003:d8:2f38:2400:62f4:c5fa:ba13:ac32]) by smtp.gmail.com with ESMTPSA id t204sm1922750wmg.38.2021.05.25.01.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 01:02:31 -0700 (PDT) Subject: Re: [PATCH] mm/huge_memory.c: Remove unused variable unmap_success To: Souptick Joarder , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot References: <20210518200927.69011-1-jrdr.linux@gmail.com> From: David Hildenbrand Organization: Red Hat Message-ID: <39cd7470-2c45-ba3a-166a-b7285c7d7282@redhat.com> Date: Tue, 25 May 2021 10:02:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210518200927.69011-1-jrdr.linux@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MWevpJjB; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf09.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BCFBB6000248 X-Stat-Signature: xt18fmmhinqfgiimzd5uy1omembngrzy X-HE-Tag: 1621929752-928281 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.05.21 22:09, Souptick Joarder wrote: > Kernel test robot throws below warning -> > > mm/huge_memory.c: In function 'unmap_page': >>> mm/huge_memory.c:2345:7: warning: variable 'unmap_success' set but not used [-Wunused-but-set-variable] > 2345 | bool unmap_success; > | ^~~~~~~~~~~~~ > > Remove the unused variable unmap_success. > > Reported-by: kernel test robot > Signed-off-by: Souptick Joarder > --- > mm/huge_memory.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 52ca04b905cf..ff79a12993c9 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2342,14 +2342,13 @@ static void unmap_page(struct page *page) > { > enum ttu_flags ttu_flags = TTU_IGNORE_MLOCK | > TTU_RMAP_LOCKED | TTU_SPLIT_HUGE_PMD; > - bool unmap_success; > > VM_BUG_ON_PAGE(!PageHead(page), page); > > if (PageAnon(page)) > ttu_flags |= TTU_SPLIT_FREEZE; > > - unmap_success = try_to_unmap(page, ttu_flags); > + try_to_unmap(page, ttu_flags); > } > > static void remap_page(struct page *page, unsigned int nr) > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb