From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C409EC6FA8E for ; Thu, 2 Mar 2023 09:02:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDBB46B0071; Thu, 2 Mar 2023 04:02:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D64BF6B0073; Thu, 2 Mar 2023 04:02:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB8C26B0074; Thu, 2 Mar 2023 04:02:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A629B6B0071 for ; Thu, 2 Mar 2023 04:02:41 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60A3FAB6C4 for ; Thu, 2 Mar 2023 09:02:41 +0000 (UTC) X-FDA: 80523367722.04.751356A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 370C0C0015 for ; Thu, 2 Mar 2023 09:02:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LpZdwiEZ; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677747758; a=rsa-sha256; cv=none; b=2kzgm4mtgo1WRVBfHvXunTwyeXgBPuE2ox3q7m68BG3Ds7hwMeAfgmXNhOC4TuOHK7eJHl jWzlUVUGGxowz/GG9w1hhNk/o5D8MSVg/HMtk97FRotNURoWjU3d0iM4vrWpjJGhn517HO GmvhgEqTTozkRZ4z4oYhOImfkz1N++Y= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LpZdwiEZ; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677747758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rzx2MwJyGFazUQ+bL7x8PG/wxOPeZdsHQ/JpovqZTbo=; b=wIh4CngFJ/25V2xz10tjgSvdC5RkqYz08mPPN3WP9Sv+Sto9+XEmC8lQokhRENWqoDkU0c 2j9s9kbRteDGVX79wkim+Yr/Ra8kEWosWe+FU10aD5lO3o7qVtDNMtoKdbT6BlPrvgESBB FXugFPG1gdq1oKaR5gRnDL7k8sdnwd0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677747757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rzx2MwJyGFazUQ+bL7x8PG/wxOPeZdsHQ/JpovqZTbo=; b=LpZdwiEZXB0WXMbeWVTFCUEGmBYZMGb1kxpuodWDd4g62z7aEPrJrpCLbmmAh8/PmzB9eW PDrTAWzb1WDml4WrDyt8M2Eh0TlvInNEl4ET4pDxZrUspsaVjDcVlXV8a1Cby3gmqx2uz5 8E/Y6Z6E8YKII3z9pvJ9XnJSQzPE+50= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-286-ShPqp5TwOji389dP3r08pQ-1; Thu, 02 Mar 2023 04:02:36 -0500 X-MC-Unique: ShPqp5TwOji389dP3r08pQ-1 Received: by mail-wr1-f71.google.com with SMTP id u5-20020a5d6da5000000b002cd82373455so1940792wrs.9 for ; Thu, 02 Mar 2023 01:02:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rzx2MwJyGFazUQ+bL7x8PG/wxOPeZdsHQ/JpovqZTbo=; b=QEeLzfeSEu9eeITY19CjuNpAhMHBcd4NPPryRJEjhtLjMh4jR748/fTHz0l9Pmlm0G 5y1h4jFkZ3uvB5FhRdkzrA1DZTFjNzdTk4ONDTpwqsEZUH1amJj6BIsv3fSaJo7d47ge HeKNmFBR7tsyOoYwkWRYgXBLjdnemYte/txBfz7dThDbYj8SO3w3wGNIVUKm3kqE3Pcc LnZ3qDuGj0Az2vYM77HASsjs86s79gQVhiLClxUtYHDpS8LPZ5A76PFx/MojZpOlAWV5 7JRV4TbfK7z5AGe2XujVbbw1EOpbc50omdsgoULICDExe0bjsZ8KYXQK38s9srZv9ko2 +FxA== X-Gm-Message-State: AO0yUKW9Z7T7Qsq7Clw3xdgX3+LWYPfGPaI43um4wzrTsGWDFG6ahP2l es/kfbcUvT018/8zXglwIA/16OhyjTu872oXk9dONIuv6A32aPhFFwyT7djrp/SeHVQTB1vqoHG 5gZAp4H9pd3c= X-Received: by 2002:adf:f18d:0:b0:2c9:5a1f:5864 with SMTP id h13-20020adff18d000000b002c95a1f5864mr7629283wro.21.1677747755292; Thu, 02 Mar 2023 01:02:35 -0800 (PST) X-Google-Smtp-Source: AK7set/b4hGgvgRD+4LWvfowqtA9986Zt0gXO0AP3E31VaZ2FjsborxxglzdVgHluaBsx+EJCrSayg== X-Received: by 2002:adf:f18d:0:b0:2c9:5a1f:5864 with SMTP id h13-20020adff18d000000b002c95a1f5864mr7629264wro.21.1677747754963; Thu, 02 Mar 2023 01:02:34 -0800 (PST) Received: from ?IPV6:2003:cb:c70e:4f00:87ba:e9e9:3821:677b? (p200300cbc70e4f0087bae9e93821677b.dip0.t-ipconnect.de. [2003:cb:c70e:4f00:87ba:e9e9:3821:677b]) by smtp.gmail.com with ESMTPSA id s2-20020adfeb02000000b002cda9aa1dc1sm4385622wrn.111.2023.03.02.01.02.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 01:02:34 -0800 (PST) Message-ID: <39c91d34-9d77-8e63-388c-6893b40c31d9@redhat.com> Date: Thu, 2 Mar 2023 10:02:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm/migrate: Drop pte_mkhuge() in remove_migration_pte() To: Anshuman Khandual , linux-mm@kvack.org Cc: mike.kravetz@oracle.com, Andrew Morton , linux-kernel@vger.kernel.org, Christophe Leroy References: <20230302025349.358341-1-anshuman.khandual@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230302025349.358341-1-anshuman.khandual@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 370C0C0015 X-Rspamd-Server: rspam01 X-Stat-Signature: zqyiwucteehqwmy73ifojtthprgphjwt X-HE-Tag: 1677747758-722740 X-HE-Meta: U2FsdGVkX1/BJ1/ad7vN90EjS4lm1srjx2fCsV0cqejC4nrLGw1ecdCZ7BiUnkMjon3PQwx53QFWs3VRqPNJdjS+/rWzgxPMi0P/rNNjVZCtYecczC5bED1jWMJS2UPnDxddbawLXWCt6qs6yIWPbEQVEiasS/+Fp9jsxOFG3VDOzohbc7KgbELbHnct6AnwFSMw9tQ0D8Chsbwb2BP749b0IV3PdGn1F187Dp8Zu17GQKJKpiicWkdpiOxpzMCs2ymKfUJ1PcuCedxTmw3Cz4P0kMghsc2gHX93bD6OPWnebNjRyfkGWm14uaPjwAjx93Ir9KbXt16TfEG993lWouoh4xL+6To9QbpGnoRraPFvpOZdP0w+Gfnu1j3JackBSrOxL8S6txJq6TJ9GbrMeh90WmrxLTp6fq4B+T0x6hMSkmjm3McxfxddxG0NKhTNqco9Bb08P+kCHrvFY4Q3ldTuUIwdxzjV8RnurzbvM14Ly42mOW5LZ7FhFXkHWQgDzquqNYijOVohmzahcZle7EduBsSGq477TXo27pZdy+X4IcW7zaK6v8ERE5zKibQWCphctHHmsJm16F6x8aSPhDbYldA3TXsr9zu/wzoWJQMR6zxR09NsAHwHNq6m13Cuzng2sf1DKesipkNpEUQk00sd41tySxZmtqKj4nNrPtoXJ4V4YY9CwdowE7HlX8MTBEuR+6ri1/2bFumZUwgZoFZkSln0kO2QT+zRdu8v/JkPjTBbBgO0LbNILxDtNDcKfUwvMLSeNHN12kkd6OethqHs0ANmejMSj1b+HHmNJq2849yMFew11tYhiS4/O7vefKpwSLYBJmNJ9UqLBv7DhZ/Df2XA1owROYXmyZ4EJsb5/DAwOz6pNF+a+FABn+oyj7dl7Fsedy1GiE6AmXdPQfe+lOTBn5o/pMjUiUS5nvi6I+dEv5BL7XjgeRDa2T0mVAl8y1s30AAfIGNBFB9 cnVy5Jy3 t5ikql3cn6UE0D1xL0yt3OjVA+5iEOkLBbVFdus1D8h5dbwjSxdLbWuGAvyGIYvifV6fJbJwfJeIhDEOSN/OQW0MdSFdLcb8uPe+71W1O0JGqfag1UKwP77qmjRtvwQxbFmsoNeZXmhtARj9mwKQR8ugsWH5izHADBiFYkhTK3iCYLnOd0AiQpp6E00RV6ctMmsJi/iCqrfdjFJ1dm3B/AvjXA8hPu+HWM9L9ICaDFYjPQmmFldtYR9SUYLFs7CzXl+ea6sULa1JW+EhT+Y/D1xlyfUwNjmqoRdr6VtQDV2QikH+Q2ky64sTjZXr31/DmHz2CMuNqG94fU/dzq/9VQBMZIk+Il9YjEJ2Non3kiTYdHGUwBtSsbB58i/V9+MumlDUFccykEExWshT3xM2nA0asK2NsIvtn90ss3IjFLn243N1b6xEZswD4rTeGUjS2WOO8wvkZZwhdiaumxQou8oNvWMC4+ZlpcN8o1h1bTEKLwsivzw+g65nBOrGuNdGei9cySy/W8ohi5zHq78Gxwd0sXGhk1DiASF6gSpoDvia9smOcY/BFgqeORNhZ3ClpcNHiHv7bFuJCu2/Nwizs3KGT3E5KBbpJcf7HL9VhKcpIOWuW/0Q5pbE/j1nSux8KG3pJYBNeZ8jAMg3ergbh1VIpt3L6f4ZPlOb6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.03.23 03:53, Anshuman Khandual wrote: > Since the following commit, arch_make_huge_pte() should be used directly in > generic memory subsystem as a platform provided page table helper, instead > of pte_mkhuge(). This just drops pte_mkhuge() from remove_migration_pte(), > which has now become redundant. > > 'commit 16785bd77431 ("mm: merge pte_mkhuge() call into arch_make_huge_pte()")' > > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Reported-by: Christophe Leroy > Link: https://lore.kernel.org/all/1ea45095-0926-a56a-a273-816709e9075e@csgroup.eu/ > Signed-off-by: Anshuman Khandual > --- > This applies on latest mainline. > > mm/migrate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 37865f85df6d..d3964c414010 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -249,7 +249,6 @@ static bool remove_migration_pte(struct folio *folio, > if (folio_test_hugetlb(folio)) { > unsigned int shift = huge_page_shift(hstate_vma(vma)); > > - pte = pte_mkhuge(pte); > pte = arch_make_huge_pte(pte, shift, vma->vm_flags); > if (folio_test_anon(folio)) > hugepage_add_anon_rmap(new, vma, pvmw.address, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb