From: Mike Kravetz <mike.kravetz@oracle.com>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "x86@kernel.org" <x86@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Roman Gushchin <guro@fb.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H.Peter Anvin" <hpa@zytor.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH v3] mm/hugetlb: split hugetlb_cma in nodes with memory
Date: Wed, 15 Jul 2020 10:05:32 -0700 [thread overview]
Message-ID: <39b23985-5611-5fba-4ec6-03f70593dea5@oracle.com> (raw)
In-Reply-To: <B926444035E5E2439431908E3842AFD258764F@DGGEMI525-MBS.china.huawei.com>
On 7/15/20 4:14 AM, Song Bao Hua (Barry Song) wrote:
>> From: Mike Kravetz [mailto:mike.kravetz@oracle.com]
>> huge_page_size(h)/1024);
>>
>> + if (order >= MAX_ORDER && hugetlb_cma_size)
>> + hugetlb_cma_reserve(order);
>
> Hello, Mike,
> I am not sure if it is necessarily correct as the order for gigantic pages is arch-dependent:
> https://lkml.org/lkml/2020/7/1/14
>
See my reply to Wil.
The code to allocate gigantic pages from CMA depends on the arch independent
definition of gigantic page which is 'order >= MAX_ORDER'.
--
Mike Kravetz
prev parent reply other threads:[~2020-07-15 17:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 12:09 Barry Song
2020-07-14 23:21 ` Mike Kravetz
2020-07-15 8:18 ` Will Deacon
2020-07-15 16:59 ` Mike Kravetz
2020-07-16 8:12 ` Will Deacon
2020-07-16 18:25 ` Mike Kravetz
2020-07-17 5:02 ` Anshuman Khandual
2020-07-17 8:36 ` Will Deacon
2020-07-17 9:51 ` Anshuman Khandual
2020-07-17 17:37 ` Mike Kravetz
2020-07-20 6:14 ` Anshuman Khandual
2020-07-17 17:02 ` Mike Kravetz
2020-07-20 6:22 ` Anshuman Khandual
2020-07-20 18:17 ` Mike Kravetz
2020-07-27 14:37 ` Aneesh Kumar K.V
2020-07-27 17:52 ` Mike Kravetz
2020-07-15 11:14 ` Song Bao Hua (Barry Song)
2020-07-15 17:05 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39b23985-5611-5fba-4ec6-03f70593dea5@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=guro@fb.com \
--cc=hpa@zytor.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=mingo@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=song.bao.hua@hisilicon.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox