From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5576BE7718F for ; Fri, 3 Jan 2025 10:36:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC6206B007B; Fri, 3 Jan 2025 05:36:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D760D6B0082; Fri, 3 Jan 2025 05:36:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3E026B0083; Fri, 3 Jan 2025 05:36:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A82856B007B for ; Fri, 3 Jan 2025 05:36:16 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 32DF11A0730 for ; Fri, 3 Jan 2025 10:36:16 +0000 (UTC) X-FDA: 82965784356.10.0729CCF Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 3FCD410000A for ; Fri, 3 Jan 2025 10:34:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735900526; a=rsa-sha256; cv=none; b=eSQcDhB5RUKxxs0d1vjpC9qLrHEnylqe6NxphZKZ1b9bajQgn8HCVENLb/xrcqVKGtE1HF 4PPaPDo+JSxD0C8S3MXHDf0OeNyvXG2iuuxYeO9jDr2HTOlMp4Yvxrxg3G8FuB6sDV4leK jvWbnoxoATlb3m+FLhG7Ko6c4x8cyPo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735900526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KqzYXTStRwHdA2r44yWtS6M9tFw/JByatD25oVsaaPw=; b=oVCpf6b2YRbZ57b1NcxVP1H12ZdaIdBiiF0dGgowDe3D7OhHvz3BrnWgI6nfoU739Ztiml s9/+wPCINbFtzczRmfb9arLQXV9MDhrCyOILilc3YGc2+mgqhveGmy9xsQMXLL+Fm6+MHL Sj89hc213cW44j3VYl8vcX1wWtlcIeM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45A1D150C; Fri, 3 Jan 2025 02:36:41 -0800 (PST) Received: from [10.44.160.93] (e126510-lin.lund.arm.com [10.44.160.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8736A3F6A8; Fri, 3 Jan 2025 02:36:06 -0800 (PST) Message-ID: <39925677-4619-411d-b0b1-40f9db09374f@arm.com> Date: Fri, 3 Jan 2025 11:36:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10] riscv: mm: Skip pgtable level check in {pud,p4d}_alloc_one To: Alexandre Ghiti , linux-mm@kvack.org Cc: Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , Peter Zijlstra , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org, Qi Zheng References: <20241219164425.2277022-1-kevin.brodsky@arm.com> <20241219164425.2277022-6-kevin.brodsky@arm.com> <2aed338a-97a4-40e3-8a95-99458756ca28@ghiti.fr> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <2aed338a-97a4-40e3-8a95-99458756ca28@ghiti.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3FCD410000A X-Stat-Signature: kjnpi56k55mgpx58feifb1ijbi117p13 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1735900475-965051 X-HE-Meta: U2FsdGVkX1+wJ8kGzcO0+4CwtWu4UrVZUtd9Ip7fRucP3qH4QbwOcaUV07p1c2dUxPzFc87zQrLaOGti9IMa9KL8tBAyimdiRozj2Wt12SO5PdXExjBpeoIJQ6q/dlabZ9LY3JUU4ZTrNvG3HFbvzfwimkTvDshmkimTDNr1fRR91Y/KTwYfYH1MwkaKtraRkTAqJvRjvH4rTvPbyT/AsyGX1opkc8VSjxGzFqvaCS7tAX1/Hw1+PV0uRGgLL7yS30H9OLDqatFYmMwbwrZ7eofzQB59lYE66nAQpax36oa5tutJMVVaJ0wJCaIubZNvfg9V3RgptOeEkGeSkwmFa4Do/9YrRXFOLtGit6IWc2BXSN6+7O0sjVQ8pwU0SSecBwOHFAcHYtomOy7WunPokDvcK6Sqn1Z86vULn4n+veEx2UCXnkJCt5JzuPobKIHYZCtudkIKG/wKV6VpjeKSIEBvULLbMvGNPcaspGO1maXT9gG/HyTH9CDQ9cBqPg4BqB2CLESH9b4QuugMUIhEOrxCmTq2dUsi3/gCW5Vq3v4J8I9I539aHenmpDXK5wd/NqZ8sgx19Lgi4M3Lv8hITIJeWkJTsSxnbeadTao6zo19+I5xJsJmyecWha7PGHu9zpwXpPe9t45RAursrn/j/QyIhyYinL9gxax8Gmsa4XQq7iZ4DO7qBb4avGw9o4EkL1bYRDPuQL7i75YezG3LhMxKnkS/9ZRiEUWivEkgycb7w04xe1ymJTMUOAb9+MZrH9PAH2SlhUOr8FCy20rFh+JtLTLUNYCFs1CRiMKJzih/9qu/jSFjl0uV7qkGGKWdAmWT30ytOC1XoKr2uhxE3I3GG2mhfvysRvCRrpeLNpWSMuRf+Co5vourq/F8VZevv4ZQGWcDkIPvY6HbGQUCdmHCx/bn6YlBL1qB0zJMLzo0AgY4zV/S9RtbZc7dB6Z8BZulqmhgC+h2h2XmYNp Shsv2rxA C64FFJp8WbAHHllK1fRftsRP4MkXUyWQb/YvHmBBoYHIK3ZrI0l3cMy5Zli4meFrgOqnFDqgeXJYSz+3KzdeILnecN9DPWMft6+G24/tKYWwD7/AhJug3whOLwgH1zxxK0r6wKk5WOPbBeDOROOXrmVR4poKoAuwpCWIx1EmaPiVeSq444CgWA1KpYusnse13CxhVGk9GjA8TMU3EAjcFDfjdnprKxED1YuB1K/KdobvV533+IH2XCEwMqbC8MkHL+VNs9mhsTmFe57Z9dDnnIlo5GMY01mUM5uNROMkzo3Ne/+j4WHZGYVRHXRqO6VGsdHxxC5/G2DoGYMq4crMWTTHzUpe/AF7SB1jQ9AGg7G6aqFrJF7fHrX1SNcj14SARfhsR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: +Qi On 03/01/2025 11:31, Alexandre Ghiti wrote: > Hi Kevin, > > On 19/12/2024 17:44, Kevin Brodsky wrote: >> {pmd,pud,p4d}_alloc_one() is never called if the corresponding page >> table level is folded, as {pmd,pud,p4d}_alloc() already does the >> required check. We can therefore remove the runtime page table level >> checks in {pud,p4d}_alloc_one. The PUD helper becomes equivalent to >> the generic version, so we remove it altogether. >> >> This is consistent with the way arm64 and x86 handle this situation >> (runtime check in p4d_free() only). >> >> Signed-off-by: Kevin Brodsky >> --- >>   arch/riscv/include/asm/pgalloc.h | 22 ++++------------------ >>   1 file changed, 4 insertions(+), 18 deletions(-) >> >> diff --git a/arch/riscv/include/asm/pgalloc.h >> b/arch/riscv/include/asm/pgalloc.h >> index f52264304f77..8ad0bbe838a2 100644 >> --- a/arch/riscv/include/asm/pgalloc.h >> +++ b/arch/riscv/include/asm/pgalloc.h >> @@ -12,7 +12,6 @@ >>   #include >>     #ifdef CONFIG_MMU >> -#define __HAVE_ARCH_PUD_ALLOC_ONE >>   #define __HAVE_ARCH_PUD_FREE >>   #include >>   @@ -88,15 +87,6 @@ static inline void pgd_populate_safe(struct >> mm_struct *mm, pgd_t *pgd, >>       } >>   } >>   -#define pud_alloc_one pud_alloc_one >> -static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned >> long addr) >> -{ >> -    if (pgtable_l4_enabled) >> -        return __pud_alloc_one(mm, addr); >> - >> -    return NULL; >> -} >> - >>   #define pud_free pud_free >>   static inline void pud_free(struct mm_struct *mm, pud_t *pud) >>   { >> @@ -118,15 +108,11 @@ static inline void __pud_free_tlb(struct >> mmu_gather *tlb, pud_t *pud, >>   #define p4d_alloc_one p4d_alloc_one >>   static inline p4d_t *p4d_alloc_one(struct mm_struct *mm, unsigned >> long addr) >>   { >> -    if (pgtable_l5_enabled) { >> -        gfp_t gfp = GFP_PGTABLE_USER; >> - >> -        if (mm == &init_mm) >> -            gfp = GFP_PGTABLE_KERNEL; >> -        return (p4d_t *)get_zeroed_page(gfp); >> -    } >> +    gfp_t gfp = GFP_PGTABLE_USER; >>   -    return NULL; >> +    if (mm == &init_mm) >> +        gfp = GFP_PGTABLE_KERNEL; >> +    return (p4d_t *)get_zeroed_page(gfp); >>   } >>     static inline void __p4d_free(struct mm_struct *mm, p4d_t *p4d) > > > Reviewed-by: Alexandre Ghiti Thanks for the review! Just FYI this patch is now part of Qi's series [1], I will drop it when posting the next version of this series. - Kevin [1] https://lore.kernel.org/linux-mm/84ddf857508b98a195a790bc6ff6ab8849b44633.1735549103.git.zhengqi.arch@bytedance.com/