From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68565C54E58 for ; Wed, 20 Mar 2024 14:09:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE6E46B007B; Wed, 20 Mar 2024 10:09:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6FBA6B0082; Wed, 20 Mar 2024 10:09:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC2CD6B0083; Wed, 20 Mar 2024 10:09:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A85F76B007B for ; Wed, 20 Mar 2024 10:09:24 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 443DB8136A for ; Wed, 20 Mar 2024 14:09:24 +0000 (UTC) X-FDA: 81917599848.23.F4BF422 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id D97ED40029 for ; Wed, 20 Mar 2024 14:09:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dV+lORDQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710943762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IRvqxmMSsEU1UbdY8gpToz+TWcSUE9yP2hNLdT2PgOY=; b=I1Yh81991B3VS0mjQmaPBBm/hLbBOQTxaiKKMKvXyykWvSb9AU8Lwa80GK2b+Z+zusPkkR Fq3gzG0H/vWPufGu8w/VgechyQ+Biip/TTgSf/A+Mxf9Ws5oUDlZ6XH1k4ObauVfaKDg3j CVUxpPg2zXfmR969+On+MFfW+lbbbWA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dV+lORDQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710943762; a=rsa-sha256; cv=none; b=UI2AVXiJSRuvhKUZEbBERlf6Vany1GlIh/rTMHm3iPS70N9SijIWpbUx/3xF2UKP5Z/L/2 tbQ+6o4ddxI2gW68re2DdlHl8r5j1UlsdcaiyFgcxVuugHg34g6xH2pyMdjeiEwG1rIJgg wG8xMtn/l0ZrovQyDzTao7is1ZWqmY4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710943761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IRvqxmMSsEU1UbdY8gpToz+TWcSUE9yP2hNLdT2PgOY=; b=dV+lORDQ+3G2l9RQxPWIpYAe2eN8z4jdZpvmHFWIODFf7FCPHExXkPwfNMWuXeN2in9xTR +NTgGw9ic8udrtwbg55RTDwztOk0lOmlIpAFx/oLsAZ6s3W32U7v3e+4D9ddfmPzALzUM1 Ay+CljhanBJ8pqQEU0i0lhQbhWMuy6E= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-536-jiHiN4sjNpOJP5KKMiKhww-1; Wed, 20 Mar 2024 10:09:18 -0400 X-MC-Unique: jiHiN4sjNpOJP5KKMiKhww-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-33eca6f6e4bso3440513f8f.0 for ; Wed, 20 Mar 2024 07:09:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710943757; x=1711548557; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IRvqxmMSsEU1UbdY8gpToz+TWcSUE9yP2hNLdT2PgOY=; b=tID5qXhcopb3erxoHaD9rGqCtzml0uUzvPCCwF6vL9g1yuwLnM19IZ31YAhcNO9Tn9 eIIw9Qg34b7C5VQXxlQJQoD5LTzH2n1h+GMGX7SyfJpFNiE1Jl1CLEfAaGaTcRdQzwb/ M8XVvZu7UZdefXgd1HfhPH0cXm8jWN8kG97D/2wJAZUKxUahOIg/AfpO+tpr9tc9REzw jeemlGSvu5F8+awDvx6mgvus1XqTA/Holn9UOqC2rnJv8sLDiiq/E8ZBs6Utai6oB+9P aewQzD/LZOretAbTrIQ6LTZJ/PKyDEOVsRZJxCrA2i3TNV8ZoEHAJzqK+8rUB0qBHBYz a7rg== X-Gm-Message-State: AOJu0YwonvFWATsqhiQPnoFhhPDSD+dHSRd7zHjsmeAC16XeEqFS3aWw 2SQfGd4NZ5sq/o3N09sI75e1gzRziFz4P5SRRsnKuWcnZFbqXktpwH6Q9GVUqyPda260LAh+ZsD AAj+g4+AMapNo2GWQXIZ/WEHJcxp1dzMzBtSbky5azlfnQN4G X-Received: by 2002:a5d:6645:0:b0:33e:b78b:5831 with SMTP id f5-20020a5d6645000000b0033eb78b5831mr1578688wrw.52.1710943757385; Wed, 20 Mar 2024 07:09:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFA3Yxa+dHzherfiMY+Rq9ZcrubT8x74pqFkK320EoIxNXxG/3cL8Sg0WfmVhxdCZts7f03IQ== X-Received: by 2002:a5d:6645:0:b0:33e:b78b:5831 with SMTP id f5-20020a5d6645000000b0033eb78b5831mr1578666wrw.52.1710943756923; Wed, 20 Mar 2024 07:09:16 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:c400:9a2:3872:9372:fbc? (p200300cbc709c40009a2387293720fbc.dip0.t-ipconnect.de. [2003:cb:c709:c400:9a2:3872:9372:fbc]) by smtp.gmail.com with ESMTPSA id u17-20020a5d4351000000b0034180f6d3cfsm5378763wrr.73.2024.03.20.07.09.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 07:09:16 -0700 (PDT) Message-ID: <3987659f-2adc-477b-b507-ead2f10c1849@redhat.com> Date: Wed, 20 Mar 2024 15:09:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/6] mm: madvise: Avoid split during MADV_PAGEOUT and MADV_COLD To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240311150058.1122862-1-ryan.roberts@arm.com> <20240311150058.1122862-7-ryan.roberts@arm.com> <9ce7b66f-f84e-4e94-863c-2f02dcff4bd3@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9ce7b66f-f84e-4e94-863c-2f02dcff4bd3@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 4o8yfqxrc6uk8phrhrsqc9m3fmrx7wrd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D97ED40029 X-HE-Tag: 1710943761-887628 X-HE-Meta: U2FsdGVkX1+Yck6mx32Rd1oCwt0g+HXvAV6FxZQ4V69o/nuca8Kmx3FHr11ta33IFaAtEVF00lPy0q8juNXWhcywAyYRjvAi9Xz3UMVSzMDNmlEApXOE0IND/9pErJVJa/fv4SsZjicK9yMsK+53/9+yG/gqvV53ZEQvX7XonulmTBokYHxtwiXPUh67++hYtAKmUYss7CeiRnv1+Ve1WNNeUA/mFP5AuaPEqJfkw9mhOeHTMYvUcCisv1mX1J5GyGwfnTPXDf+xqgbawij+ABmPVRNPrYVZ8chsx0SgoL1CINxT0haupYZt+ZwWxYCuTZQqVqTv+6xsvibsLm919YGztJwJwoiMkvlbZ22G3m9LRit6RQjfC/n/d0TkEj5OJNRKYhRCOSzxTeqmVlzl5YBmSfCqmcAZdW1eaw0ZPIDtWrWgUQ9hFjwK5CI/5haCeVNzsb/RKo4BGCAj7DH6RC1LdnwcZWXg+m2ABLB8CY61JF5Y8z+r8twdRjitL4neb74LkvfTRsDVIes4cMZpWC1zEhigIOq4vm903JdCBM/m3Gr1eFbXgfhcmGSGgddvIlI6RIw3HMqXpA/AXH2GN5Z1r91yo44eRTYz3v6ns/aiw+orUP2wJEmE8hBGNXKYA+bV7GcTl9AEnfmjl6v1zRmyCtsZ5LV9rsDNOZW26iSRiNOuVvCLEa6mwvSzSj53UsZwk6iSI7HI1ld+Z89EgCWpZj2J90PjDEIqwH+0SXuv7B51RXZNpFIUoipm7tyhin5hV8M10vzyN9x4VOEiahnZZxicHez3BFsWyIOnzUqQVfJY3MGfC6I63Kab3UwYycI1gS0OusOfmzEqKX0m9PQ1GF/ubKTSfPFHp0I+iPdTZQlQUlDcicci/LkeWBFRXB60dD1asdRJIwhB9JuwDFUTkTLm2xmd7T8nFAKDCLcL46dMwTDjjZlPEpkOdzJYwKDcGAnY1fYXHtumXiI 716UnwP0 UMfMmSN5eG5W1QkPDmKL72oZdVScPkLd4Sf6PXJIIr8VUHs82YEhUeAiTqZFn9l+tlBGJr/hkkjnEiFDhixJoAbAXQev7UUowQJPf91RUk+wAbWdS2nG/kBu2dOHGhlUpl+sJNSko0VvpZkiiNleYwT8Vqa7gNmnM8YBPissrVqrexWRzDN2HLoxLnW7VhxT9P2yeJg3anEzD4fOUf9JKAgAkMLO0dDq6AzPKsIqCNNhkgAa+C1DyeXcHE+gZ4TLJEYeyBfJ7XlpNWtRPMJwe138FbdeQ06p6Ta4OwPHeHN8uHtVpmJMVrUCHWG2VFJ7cRKWX2vwuBhmq7kDgbAyjEmaPkZbifldNIlGgkopDGebuoOa0JnTgh1xY97m9tTIUyTLONvjbA0Wen5+E8ibcGbDa9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.03.24 14:57, Ryan Roberts wrote: > On 15/03/2024 10:35, David Hildenbrand wrote: >>> -        if (!pageout && pte_young(ptent)) { >>> -            ptent = ptep_get_and_clear_full(mm, addr, pte, >>> -                            tlb->fullmm); >>> -            ptent = pte_mkold(ptent); >>> -            set_pte_at(mm, addr, pte, ptent); >>> -            tlb_remove_tlb_entry(tlb, pte, addr); >>> +        if (!pageout) { >>> +            for (; nr != 0; nr--, pte++, addr += PAGE_SIZE) { >>> +                if (ptep_test_and_clear_young(vma, addr, pte)) >>> +                    tlb_remove_tlb_entry(tlb, pte, addr); >>> +            } >>>           } >> >> >> The following might turn out a bit nicer: Make folio_pte_batch() collect >> "any_young", then doing something like we do with "any_writable" in the fork() >> case: >> >> ... >>     nr = folio_pte_batch(folio, addr, pte, ptent, max_nr, >>                  fpb_flags, NULL, any_young); >>     if (any_young) >>         pte_mkyoung(ptent) >> ... >> >> if (!pageout && pte_young(ptent)) { >>     mkold_full_ptes(mm, addr, pte, nr, tlb->fullmm); > > I don't think tlb->fullmm makes sense here because we are not clearing the pte, > so there is no chance of optimization? So planning to call this mkold_ptes() and > remove that param. Have I missed something? Agreed. -- Cheers, David / dhildenb