From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84213C46CD2 for ; Tue, 30 Jan 2024 04:34:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C79B46B00B4; Mon, 29 Jan 2024 23:34:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C02806B00B5; Mon, 29 Jan 2024 23:34:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA3266B00B6; Mon, 29 Jan 2024 23:34:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 94C276B00B4 for ; Mon, 29 Jan 2024 23:34:22 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 38A501A0792 for ; Tue, 30 Jan 2024 04:34:22 +0000 (UTC) X-FDA: 81734710764.13.3ADC112 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 768A440015 for ; Tue, 30 Jan 2024 04:34:20 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706589260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GfHw5ZZByjt9qO2d/+SVY0a6eTt9STK5ptxi7K71cA0=; b=iuuhdA85MCJRquBunovcAA4nTQOvTIBp2P3JO07jSG5gzdoitbgBjuvvQ6DXMzNPvyiNQt cYJiwv+YGO0a4oqe8wSLBH4OH9C3Bj/6S+sUYQ+X1eu4QFeFwTUcGxHlafqCz6gu59nda4 QPbhe3aDZUCm++jb9Ybqep4FxNyMuXM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706589260; a=rsa-sha256; cv=none; b=GYjF5ryxpECRd2jleYPLeVizjg9e4hmCnSZa/DLs4tOc5lwWZtPhx0n+3hcUqk0NXeKZ4N m+S7a0rWf3U1JtkZyFSq2B4V8/E9do3FcImLrjrfTyKGTzoLsNrBRiZIXTDE7XgA4epA2C W/hGGlnANdFVENIvkMuJxqYgso6uEI0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3BC74DA7; Mon, 29 Jan 2024 20:35:03 -0800 (PST) Received: from [10.163.41.110] (unknown [10.163.41.110]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6E3CB3F762; Mon, 29 Jan 2024 20:34:06 -0800 (PST) Message-ID: <3983416f-b613-42c7-bb42-d3ab268ea1be@arm.com> Date: Tue, 30 Jan 2024 10:04:02 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 04/35] mm: page_alloc: Partially revert "mm: page_alloc: remove stale CMA guard code" Content-Language: en-US To: Alexandru Elisei Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-5-alexandru.elisei@arm.com> <966a1a84-76dc-40da-bde2-251d2a81ee31@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 768A440015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: me5kfu7extpy7orzbx59qjacb496tyzc X-HE-Tag: 1706589260-910917 X-HE-Meta: U2FsdGVkX193KpRyRfGLKthlf12e8e671DqwDsd9UGMAP+CRpQc9uW4M0uCnkjKrvEnfe0YwcUI1eWf5eD+J7pOgJeBTlUruRjcG0yM4EllBx7mw4P6TWpzFr5AwTqKMboYMRYS93EV0M+j7p0onWHGP2O9xzI7AU74sUE1t5eZ5KlO7y1N9RUNsUbJV0Dp90ZqH25ics35j8bOlzb6rm+NjfMRfr1tneUtDZpfe8aMATW0R0jkXHW0fM8pxaFwo0gKR8wPfxYdGTdHtWbuEV7TT+oEcfI09A3o2u8krdgmIJK62LOrk77tgi/7Sa82VN4bf8dDTp4/hn4R6NjNoB4GCCius38pd8mTTKtpdT7MFZ5/Yt0OMrm1CcRJYMiRfJvloa6grbpIwKCe3kEjUHddCtJG3LWtV0Vuv3sZT1cHHOBwSN7gw30x0J/5mLV1V8WUEpBLE1zOjhzaslI99QGGBBnivyzrfLyDBP7/Gz3Bf/UZxZ/5pxTFuJbh4/77utv1Yja9CQ8VJ6Yb+fmcfmMyKhkm1lFN9xs6Bd7bj+gRoVDxjC0qNsLT758yqdqVh/8ygQyxaPqf/R200ZT5C22SoD320DEcX705uxbdPrzzqb/qPbtqXF8qrtqE5PCXgqTGfFSJGrP+NCAxVAL5G44x9z55AJbG49feT4jeHLCX7xjwuSZcAv2b2GXygBdt7JnBjvl5c3BmTXK3H0OZ7OSHts6B9LNxNS6k9VHFJcs/LEO0iMcmuXKshm60VPPr2gIOMkV+Q8m86lC2S3r8J+PC7l6HvwmDIj9/hHSegZeoffWcQrLe6eXUAkS6FBRlvILD/EsDxq4yZBXI3mFmExzZ1l6doIZOGA8pq6RkXdpNEsFOCEUAcY8+mxbluMLYer3Fs/rvBsQNQRztYtPLS8O3FtBFNnjQzI/p2degD/bDKY3VhvZ6j9z/mqAKDObZtSgMTfzBYJeYFirXclqS R7v7e3eT rWtTyQM6T2sWgxzBCKdsZ7QH6fBuw4zDoo5ZJcTc7KEl6E/23HeNrQ6iIx9appLBjS2eucJ0exG7YYlvR31Y6V20LpKou/wRWYuJ5s56eJLQrZpiTrA8nhnqs6DhQhT4v+uQO8b5oUJ8TB3CB0VN+usC4ilJA4hxcLQ1UCvco2u7BMGdc9SpRx/uLbVuGTP6ZHcCg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/29/24 17:16, Alexandru Elisei wrote: > Hi, > > On Mon, Jan 29, 2024 at 02:31:23PM +0530, Anshuman Khandual wrote: >> >> >> On 1/25/24 22:12, Alexandru Elisei wrote: >>> The patch f945116e4e19 ("mm: page_alloc: remove stale CMA guard code") >>> removed the CMA filter when allocating from the MIGRATE_MOVABLE pcp list >>> because CMA is always allowed when __GFP_MOVABLE is set. >>> >>> With the introduction of the arch_alloc_cma() function, the above is not >>> true anymore, so bring back the filter. >> >> This makes sense as arch_alloc_cma() now might prevent ALLOC_CMA being >> assigned to alloc_flags in gfp_to_alloc_flags_cma(). > > Can I add your Reviewed-by tag then? I think all these changes need to be reviewed in their entirety even though some patches do look good on their own. For example this patch depends on whether [PATCH 03/35] is acceptable or not. I would suggest separating out CMA patches which could be debated and merged regardless of this series.