From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0C6EC04FF8 for ; Mon, 15 Apr 2024 15:05:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 585676B008A; Mon, 15 Apr 2024 11:05:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 535056B008C; Mon, 15 Apr 2024 11:05:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 387316B0092; Mon, 15 Apr 2024 11:05:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 153396B008A for ; Mon, 15 Apr 2024 11:05:04 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 83E3B1405B7 for ; Mon, 15 Apr 2024 15:05:03 +0000 (UTC) X-FDA: 82012088886.04.F3E6CA3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 57CFB8000B for ; Mon, 15 Apr 2024 15:05:01 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YxkUupc1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713193501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TF7bkVJrx1aH7MvweFhEZtnv8SR9+bz0TmbKC8c2sKQ=; b=wRLc+1MS4iSrYSNsOoQyYNuxWZq2/tG31P04RYSJOXDIGVopT4MJrh27vS1/UWVmCYbW5v 1jEOUGyNkhwr2SS0P+9nlWAJPVaEBZNLsnL5Ix2qt2e8X15AHKabzTVZ5Rg8S92952vz4p t3zDnq+5Vcxrse6hMCTemQGY746giRQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YxkUupc1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713193501; a=rsa-sha256; cv=none; b=KG/y2a3B6mgI416lOhVQZ4G7V59+8HJsQJN2wkRJYYXEgqHtE2sKBeeLmw9NT7sABGg6fO RtUEcM+J6Ns85fw738KfIk7TDfsY5uzi79gwqb1b06yr89/b+rAhohZfYBrwqSsnT6l65m Dw4eH1Gaw4HiWy+9SK1jSqL2xZ38CxA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713193500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TF7bkVJrx1aH7MvweFhEZtnv8SR9+bz0TmbKC8c2sKQ=; b=YxkUupc1MS2DV2HWUcMlCVZnQg0M2aT3z7qEEerji9WKJDHEOpT/VYRHZ9t6YqcoE4sEBN DVM04u7RRmfJq0kzzwNI1LBg/x1xcwdsetpC6FbLooxXvjLAxhk6zjQXaTruixBkCkVA3Y LWC8KXmW0KNV9f06Rv8keEPwUcX6cHc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-290-9sIVBA8GOgGO74OM2X8a-g-1; Mon, 15 Apr 2024 11:04:56 -0400 X-MC-Unique: 9sIVBA8GOgGO74OM2X8a-g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41663c713b7so21355355e9.0 for ; Mon, 15 Apr 2024 08:04:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713193495; x=1713798295; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TF7bkVJrx1aH7MvweFhEZtnv8SR9+bz0TmbKC8c2sKQ=; b=U3yZXcUdh2ogXBYfEGp2hmEZ+5HKq7aOnBj1Oh380O5CHltw+cXqxYJ3t/GC26QRyM zrInOhtXLO92ILcr8RvTXNbf3SlEqGz6duDsA9HGrRa6VO8tf3/KT1/6s9N0yQ0i15pf bA/tRNUbBz+1MCZz/hjLQa5fdPCE0MfSYkj3/El4A9+QaGS+SVWG+vXmgbSCZori0nzi oLsw74y+AYfXzCKbtG10+Rm0M5iHh/bAJ2eZHK3zpJlIgvZzkaiNSsFIIAZbMcW0crF7 tdv5rdBOTbzoFjYM1l0wTRmi7QV/oNWEeRQREPa6aDZOVfTKD5akSEJY/Fm4RVK+eTTt aWwg== X-Forwarded-Encrypted: i=1; AJvYcCXPCV16hUEx9PyXKXzOIApg4JFIFoK5ILZJG8IIeYG3lLdL1fMmuWGnOhcO5Vdr1xwXJHQLGK+9stxyZ1EdommEUyE= X-Gm-Message-State: AOJu0YzXMBVCSUuG/c3ws0dmsyyoNa2l67FSh/FtgkkrUVAin9b3PQAw FPwPRWbdYgMCh6wDPi+LtiVGkH/vnYkxMTn1+2z+oRnr44rg1O9AYLlLHxyhxe9CjTRwPtPz0h7 qP+TFt/9JjOYmp/VZs3EnPc9KLNP0MvpWxpaaiE30N42LiAYp X-Received: by 2002:a05:600c:450d:b0:417:d01a:6d64 with SMTP id t13-20020a05600c450d00b00417d01a6d64mr8797485wmo.5.1713193495761; Mon, 15 Apr 2024 08:04:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7BkTxm8FFb16vkwqCrM+M3c0z+jpsn+daUGwUsD7BSMU7IyLfzGd2qrhIDaZwpFSdX8hCZw== X-Received: by 2002:a05:600c:450d:b0:417:d01a:6d64 with SMTP id t13-20020a05600c450d00b00417d01a6d64mr8797462wmo.5.1713193495484; Mon, 15 Apr 2024 08:04:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:d800:568a:6ea7:5272:797c? (p200300cbc706d800568a6ea75272797c.dip0.t-ipconnect.de. [2003:cb:c706:d800:568a:6ea7:5272:797c]) by smtp.gmail.com with ESMTPSA id fc16-20020a05600c525000b00417f65fb982sm13543550wmb.6.2024.04.15.08.04.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 08:04:55 -0700 (PDT) Message-ID: <3980b722-e45e-41bb-8b6a-afce44b6c3a0@redhat.com> Date: Mon, 15 Apr 2024 17:04:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 2/3] virtio_balloon: introduce memory allocation stall counter To: zhenwei pi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org References: <20240415084113.1203428-1-pizhenwei@bytedance.com> <20240415084113.1203428-3-pizhenwei@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240415084113.1203428-3-pizhenwei@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 57CFB8000B X-Stat-Signature: 7ga4q5gdpux19y4y4f6szqbaoir6gnp7 X-HE-Tag: 1713193501-198765 X-HE-Meta: U2FsdGVkX18vUdAE/JUq5fssIul11j4cEJ/Lchef/rPfaFvx3xcct1zm6lULY6FYNXsxb7M9vAk853nGssDD+vqraDZNnKfdgf2UGIj/RS08fJJRGYkIjcW2LKmd0W4VTWYcYvKipxPuDuqX6bHtCsUe2PT5hQRIYzIV/lDb2pkgd6Hku8X+fBx2UxDI3f7WpVwnYjPTwNn7A1h2+/tdOFUPf1HBLj0UwJxba18XFfKJcm8FgRGSvppFdLonO9DRSNbCKh0CQ8OW/9nGb58d07PLuxnUlqk884ZUrTmMFfCSmW5iVhuPY2FQtHyjFrDmTEU41BLW5gn4+B6uUggOUJ8JKDTz4/SzZVfZxt7TreJBhmyWZFd/oSVE6Fr7dT8k709BqL0jHFQfb2dokWg6/XuNbQ7hYtEyBlpuMVvDzmC1KxaNA2TTNjcr+XG7kbJjTkqCT4BClNAGyWht981s/84YjQsv1BiUSVWpc8M42TtTzX6vGrUWEiL16x8D93vQhuvnQ93cN+wyW9XYsGxx9AM14tF1m+6fnQgSPzaUeTBAMw+trrPFh6Cy3JYQ0Dknrs6Zaqh9+lmjquJtjuzXDWhDEDy7zg1afBGdhCe478rif4BsKGPiracW4h3rAwvpRKrSCbjWgZB+ane9104SnU8Lp/ZTXJ1AjQMnbPtt1PpP2hof3X1UJhYUAyCaaK4poOsw/8ZM014BfbGK9IAbhhiy5S+rcz/hH3fMqWIBezp7VHWTjKzZvRn6WAjmLyh3h7WUaVHjmu8gcyUqroJRn7jvaRBQquSsFV4zywjSn8G66Yn++0CnjNUb57Y/V/o8vstF5Pnw65K1Rmquu29MiW+ya28O0H4OkjyE6mWJ1p6nHcml9v5rWrp1LDlBR7JIM13idu5NPu5RFUQfMVOsRg6o5e84VoFwfxnofz235ZjVXK3Qpb8R3ovE+79mccVdh35cyAt21jBCDB704me A721lKZm XagokPORrNJ5YWKGn/hkQ2TWYLgeqe7QntyrarkZJFCGdsjDF5ZKX21fwO/36WgEo92ZcpSFk3W3C3/lhP71gApH1/cDZy82yiesLRqoc3bc1jV/DYqI/ee0jU/NsY6R3YCuBF2VD5mk4/0kGjDxP88r0E0aSvKKcyDoL4IkUH907mGk0mXT0sg9LQz8NAQ/lswGWlHCZfbWsaAfG9alNoLP/xQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.04.24 10:41, zhenwei pi wrote: > Memory allocation stall counter represents the performance/latency of > memory allocation, expose this counter to the host side by virtio > balloon device via out-of-bound way. > > Signed-off-by: zhenwei pi > --- > drivers/virtio/virtio_balloon.c | 19 ++++++++++++++++++- > include/uapi/linux/virtio_balloon.h | 6 ++++-- > 2 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index fd8daa742734..4b9c9569f6e5 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -321,7 +321,7 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb) > unsigned long events[NR_VM_EVENT_ITEMS]; > struct sysinfo i; > unsigned int idx = 0; > - long available; > + long available, stall = 0; > unsigned long caches; > > all_vm_events(events); > @@ -355,6 +355,23 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb) > update_stat(vb, idx++, VIRTIO_BALLOON_S_OOM_KILL, > events[OOM_KILL]); > > + /* sum all the stall event */ > +#ifdef CONFIG_ZONE_DMA > + stall += events[ALLOCSTALL_DMA]; > +#endif > +#ifdef CONFIG_ZONE_DMA32 > + stall += events[ALLOCSTALL_DMA32]; > +#endif > +#ifdef CONFIG_HIGHMEM > + stall += events[ALLOCSTALL_HIGH]; > +#endif > +#ifdef CONFIG_ZONE_DEVICE > + stall += events[ALLOCSTALL_DEVICE]; > +#endif > + stall += events[ALLOCSTALL_NORMAL]; > + stall += events[ALLOCSTALL_MOVABLE]; > + update_stat(vb, idx++, VIRTIO_BALLOON_S_ALLOC_STALL, stall); > + > return idx; > } > > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h > index cde5547e64a7..13d0c32ba27c 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -72,7 +72,8 @@ struct virtio_balloon_config { > #define VIRTIO_BALLOON_S_HTLB_PGALLOC 8 /* Hugetlb page allocations */ > #define VIRTIO_BALLOON_S_HTLB_PGFAIL 9 /* Hugetlb page allocation failures */ > #define VIRTIO_BALLOON_S_OOM_KILL 10 /* OOM killer invocations */ > -#define VIRTIO_BALLOON_S_NR 11 > +#define VIRTIO_BALLOON_S_ALLOC_STALL 11 /* Stall count of memory allocatoin */ > +#define VIRTIO_BALLOON_S_NR 12 > > #define VIRTIO_BALLOON_S_NAMES_WITH_PREFIX(VIRTIO_BALLOON_S_NAMES_prefix) { \ > VIRTIO_BALLOON_S_NAMES_prefix "swap-in", \ > @@ -85,7 +86,8 @@ struct virtio_balloon_config { > VIRTIO_BALLOON_S_NAMES_prefix "disk-caches", \ > VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-allocations", \ > VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures", \ > - VIRTIO_BALLOON_S_NAMES_prefix "oom-kill" \ > + VIRTIO_BALLOON_S_NAMES_prefix "oom-kill", \ > + VIRTIO_BALLOON_S_NAMES_prefix "alloc-stall" \ "alloc-stalls" -- Cheers, David / dhildenb