From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1603C46CD2 for ; Mon, 22 Jan 2024 22:01:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A9AF6B007E; Mon, 22 Jan 2024 17:01:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 232F16B0080; Mon, 22 Jan 2024 17:01:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AC956B008A; Mon, 22 Jan 2024 17:01:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DB8AB6B007E for ; Mon, 22 Jan 2024 17:01:30 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 71E041A06B8 for ; Mon, 22 Jan 2024 22:01:30 +0000 (UTC) X-FDA: 81708319140.07.8894D5A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 7E894C0007 for ; Mon, 22 Jan 2024 22:01:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RJjT56Ii; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705960888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YgorZ9y1ABigf+8AfYUUWexSMaoGg5QlyfBL6eKu5CY=; b=A9+8dJcZMvu6tAc/BnRNtPh7L/1IPr/m+3HWK4YGAcke8cKHUgWRTVTf75ab5HBaj11zBb TIgw44NkyAHWelQt9M7r1CH9F4zZk2GvVHRATfhYsImBtSre0S3QLxbkQdX+j+aQbbh5M2 lTJ8gVtq9gsADzi5ckUJrXOo0rmuYTg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RJjT56Ii; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705960888; a=rsa-sha256; cv=none; b=WEBtrYrLIjjeNHufDQMezUfuMXptGXF5jQ4gDYJkjxmu5bOqVjkSHZ7vQgIHqEIcqpfodV oZblNDShOwCDO6CzczjyUnXCkvtEvIjtM2pTGYk57KXRJE/ebxaS6OvreCyKOMMavyykl4 0s7plDJSB0rKiDv9KC3dvaEb36uvn/0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705960887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YgorZ9y1ABigf+8AfYUUWexSMaoGg5QlyfBL6eKu5CY=; b=RJjT56IiUiW5b9TpNIT0/HVi3FAPwuSwEv3AvB3nsUngLqALCnVEA/uqOA8ADEmUJNqAXJ UP+YTHj6buCM6BCX4vsnljfXgTN7WZ2Tl+63I41ONlFoAZiqTAdKeIIIYXm5gopmLDOZ7f K0GbZPGvxYuSs/Kwtg3lJ3CuNLEVMgA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-FVBxaMfkOUaLwqIkj88Zsg-1; Mon, 22 Jan 2024 17:01:24 -0500 X-MC-Unique: FVBxaMfkOUaLwqIkj88Zsg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D9621845E60; Mon, 22 Jan 2024 22:01:22 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 77F78492BC6; Mon, 22 Jan 2024 22:01:20 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <7790423f-665e-44cc-b4ae-d3f3d2996af5@linux.alibaba.com> References: <7790423f-665e-44cc-b4ae-d3f3d2996af5@linux.alibaba.com> <20240122123845.3822570-1-dhowells@redhat.com> <20240122123845.3822570-7-dhowells@redhat.com> To: Jingbo Xu Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Marc Dionne , Gao Xiang , Chao Yu , Yue Hu Subject: Re: [PATCH 06/10] cachefiles, erofs: Fix NULL deref in when cachefiles is not doing ondemand-mode MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3980815.1705960879.1@warthog.procyon.org.uk> Date: Mon, 22 Jan 2024 22:01:19 +0000 Message-ID: <3980816.1705960879@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Rspam-User: X-Stat-Signature: n7pd81j6s6po8hs4ui31gxu5q4c6huax X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7E894C0007 X-HE-Tag: 1705960888-483057 X-HE-Meta: U2FsdGVkX199qkGxz15fd3oJ8SRttV4Qpt1D0A9Yx7ziPsleHSeJYqVRy93nhmQh8ANu6MdWj2H5VbPil2zW7AmDP4txAUD72QcZZSRqh5kWhurhkMVxdWzSsrE9nlskgaxAm9p41UK4dPYwdpopFF3mycMeVZDcaEp88WVn1HYYkoN/bwWe6IjBeJ178bb/Eq6PH/+FY3frKZr3KIgo7AEYbo745r2nn/la8PiKfsvAxmXmwoEgQRj2+QDvvJisy2dhyumhcpFk5aZL02oe53Lz157tRe10YzC7LZOArskUHXwpulkI2tr2YCyr0qb7zRYVK9F0rf0euc/cszJSnZGQKi8hNG2xU96FMN1v0jfvx+aLF/C4CUbGXE/cBrgfp7esD6pgm0JP0aXygC8jnz9zSxMgArI/a0PY5QdQDdWcGMEt0lRmSR6hWF0PfgYCIRn6BYZYZKLxqEmLZuWSKB+Kniunpua23DlZfk3UdrRtuvJYydKiX4wPS/eZ3nnr4sG7cNYcMPe57QUUC79S9CRWfZjoDi8LTQSFFPFontIvUTLLFvVsBdNMBB980jWKpZBW+anWKxwootxw5B/A3p/xBDxZ0vQOFEceSDPoF371xba1YeZz84stWsRVKmL0q2MEfluOMInGU18e7pIiWTTe7EfRqaR/Y1T6NGVk4vGTe0YawIJdqAQ9A1r4WmH4EKxGp7iirSclR0fiiuqvrDtdZbwFO/115OvCGF5XzNVjgRuyMti33a8BEcwnxY07Uh2DEMVIAywLeuFNJbr8NMfokm7VZOvGfqNzo1mBUsrSZzGiMNtWMYqvUrk0PQojN+1pQkbmSVJ9Zk6dQTvhyyaYMBaW3iYOTkpTW7ucl3FsQontXWBXwDXBmajFtDFbxmWWLqw9VkWytiYdvdIonfrGv64rlHyMQL8VTvBi3/cqJPmatSl7tS+frbzejvDInDWrF2XOs3I15uqPQ7C s+efpIM1 CBfEkcSyaNAGAKwJ2GtkuO2lPaxsVTK3TBwJ9051DUs1rQULIh5yFZAB08CKKtnFTMd6URuueqEYKtZ6TwXOygePXuEKsLlo7hI2Ug0gnQLef8T9Ee2utsr10klYfckHBwOAW9NO1TTb3pbr68ze9e3QTgzQXGr3sjPJPMc6Nyq5gnRgiChO6c0CxuTrwlhwU7R6Jc7O4697Iqiw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jingbo Xu wrote: > > - ret = cachefiles_ondemand_init_object(object); > > - if (ret < 0) > > - goto err_unuse; > > + if (object->ondemand) { > > + ret = cachefiles_ondemand_init_object(object); > > + if (ret < 0) > > + goto err_unuse; > > + } > > I'm not sure if object->ondemand shall be checked by the caller or > inside cachefiles_ondemand_init_object(), as > cachefiles_ondemand_clean_object() is also called without checking > object->ondemand. cachefiles_ondemand_clean_object() won't trigger the > NULL oops as the called cachefiles_ondemand_send_req() will actually > checks that. Meh. The above doesn't actually build if CONFIG_CACHEFILES_ONDEMAND=N. I think I have to push the check down into cachefiles_ondemand_init_object() instead. David