From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24970EB64DA for ; Wed, 19 Jul 2023 07:49:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4A68280039; Wed, 19 Jul 2023 03:49:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD3658D004B; Wed, 19 Jul 2023 03:49:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97424280039; Wed, 19 Jul 2023 03:49:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 854678D004B for ; Wed, 19 Jul 2023 03:49:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5BA9E1A01B0 for ; Wed, 19 Jul 2023 07:49:01 +0000 (UTC) X-FDA: 81027585282.10.9C155B2 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 326F64001E for ; Wed, 19 Jul 2023 07:48:59 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689752939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kZnfnJCnF7636FlKlqqUUdtvtBbpidcyKmQaXK/2hbQ=; b=j/ks6DgYNzLpluPr5qFHDhzeCFyPPURWUcx3sY17gbvXx8BrZxd9t4d9Ox1czCs14xsGs1 u8bpyyyMH4JUPph0qV+3WMpPvgIB60VcxKxu0/wbYE0tI5jITGxWh80QNffPeG+9a0zkFu LRbG+A2YSJLZnFvan+INUCLI0ajJpnU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689752939; a=rsa-sha256; cv=none; b=OPeSj8QuT+0GNDvDkQjaTclkP/N5tGPAHFIf1mj/kBSzLHOy1fSGMVI8wcjVF0VWynfiBA FiEHTqnNeL2jKBH52H5ToA45LxTd+K0D7EuVzQc437+i1nW0cDGFeduvU/4Vv2tbd4GI8c oXVQxGOCgQxR85iKmE7xo00e0Y7+qCo= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E4152F4; Wed, 19 Jul 2023 00:49:41 -0700 (PDT) Received: from [10.162.40.17] (unknown [10.162.40.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 758CE3F738; Wed, 19 Jul 2023 00:48:56 -0700 (PDT) Message-ID: <397768bc-b861-1f6e-4c12-8fbbdff0900f@arm.com> Date: Wed, 19 Jul 2023 13:18:53 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] mm/mm_init.c: drop node_start_pfn from adjust_zone_range_for_zone_movable() Content-Language: en-US To: Haifeng Xu , rppt@kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230717065811.1262-1-haifeng.xu@shopee.com> From: Anshuman Khandual In-Reply-To: <20230717065811.1262-1-haifeng.xu@shopee.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 326F64001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gucfgnp5uu594yhau5rk7fsc9ebicnqb X-HE-Tag: 1689752938-91400 X-HE-Meta: U2FsdGVkX1+1whP8IkaibUGK0bcG9d7kR6JwOjwrq6/Se2B9rNTujDfiNMyLSnGIGw4ggq+ECRiO5Ec6a1tel33HQ+BDAC1wZNFeJsDS9DiaD46+LLhl4OGmmADphl9sxLwkKhHOuMvcgeArYtXbggyYmJoN5RqWAWRBaoQiHG20yuqADogyBMFSnFz+Z4YbikdvlJaFln9SOpeRl31H+UJjMsvcMOdWpw8lLcEU1M9lqkQOf0XGshRdapEoH+skkPLQdkWfl9bwn+xFbvfAqIak8PKiNOhZyfdKqbEd/xXeTsTCXXDu7lNsaE0Z2hopwmPlS7WFJ0bwou/z+yuAA9F5S8w9veoqNPdeH79ejrniq5Ut9+9R56enFBk2wKAorl+8QwwN0kSEKEen4jp/Ljq3sHvsc2Sfkcc+KbmWK7su9ub8FKX32WSHwSy2pOzfyKOfk7j0zlrfFmXm9e44ICUaLQcrlzqmzJn1DCY1QHrykyKahTvrQku9yYfuSkz1ZHyiMs91rswz0MC2eCQHcNVJFAPp/7NCUjhFsIHR2Xt2zj2MO1o4t/ZNKi2Yh8l8UI2zbd/Vah7HEctVUvC7Na5whEcowBLGgP8yQD2SuxNoHEeILCgO/yoX00HwcC7rhsoz1cGxG7QDWOG9QfTfieF6OGyZr7kPnG/bO8S+oVJh0qIbRFWfMjYlqFRudS/cmbeCxus+XN7yO+YM0lXjmM7GJosvgR3YtsrXbVIGr0Mai0dc/9XSr1jz4h4wl0dZV59KCnyK61GFSw3vXVMI3sMmyzzKZmeCW4NlV3Aq1xwBQFA61LPuDAbcPXldivlsRtyFpPqQ0L/SGXFy854UJOA4fxun9kvCt2A1mFLoRFbwv8DByAxDxR4Cg9ng5U6h6zM3QtYMFXdzwFbEV8kHwTEVdeGLEDiezh1LU7lqVi9n62vBi9uXH8bOOzTA/ACpn+9qmWn2VM0vQfjl1wn YZ2qhhLs jjhZ/pyKxHgeIP0bQzSXdJxax7CtofwVEIL9J3PY8Av+fxZ5qRbJW0e4c+JC1SY748LmYiUBvPIJHw5GiLNKp6BebJLG4aTNoGmYU2d56Jg0tzRe2CSXzKpKq97ZepcZ+lTBeaVgRMVm336IgFPeUzCSZguf301O7ijfXWxdDor0lmCAoT2mZADpIf55RRk1asww3nExKAvnIbNXbY4QytEb0az5ERI/iQUUfLk8spjlj1DB/0ydQhvudhnb6sQX2y03QVHAQOIl9kdY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/17/23 12:28, Haifeng Xu wrote: > node_start_pfn is not used in adjust_zone_range_for_zone_movable(), so > it is pointless to waste a function argument. Drop the parameter. > > Signed-off-by: Haifeng Xu Reviewed-by: Anshuman Khandual > --- > mm/mm_init.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a313d1828a6c..23d50541e1f7 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1105,7 +1105,6 @@ void __ref memmap_init_zone_device(struct zone *zone, > */ > static void __init adjust_zone_range_for_zone_movable(int nid, > unsigned long zone_type, > - unsigned long node_start_pfn, > unsigned long node_end_pfn, > unsigned long *zone_start_pfn, > unsigned long *zone_end_pfn) > @@ -1222,9 +1221,8 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, > /* Get the start and end of the zone */ > *zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > *zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); > - adjust_zone_range_for_zone_movable(nid, zone_type, > - node_start_pfn, node_end_pfn, > - zone_start_pfn, zone_end_pfn); > + adjust_zone_range_for_zone_movable(nid, zone_type, node_end_pfn, > + zone_start_pfn, zone_end_pfn); > > /* Check that this node has pages within the zone's required range */ > if (*zone_end_pfn < node_start_pfn || *zone_start_pfn > node_end_pfn)