From: Vlastimil Babka <vbabka@suse.cz>
To: Wei Yang <richardw.yang@linux.intel.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge
Date: Mon, 13 Jan 2020 14:22:04 +0100 [thread overview]
Message-ID: <396ba7b6-15e7-998d-6c64-59519882e211@suse.cz> (raw)
In-Reply-To: <20200113070322.26627-1-richardw.yang@linux.intel.com>
On 1/13/20 8:03 AM, Wei Yang wrote:
> No functional change, just leverage the helper function to improve
> readability as others.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/gup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 7646bf993b25..7705929cc920 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
> pmdval = READ_ONCE(*pmd);
> if (pmd_none(pmdval))
> return no_page_table(vma, flags);
> - if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
> + if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
> page = follow_huge_pmd(mm, address, pmd, flags);
> if (page)
> return page;
> @@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
> pud = pud_offset(p4dp, address);
> if (pud_none(*pud))
> return no_page_table(vma, flags);
> - if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
> + if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
> page = follow_huge_pud(mm, address, pud, flags);
> if (page)
> return page;
>
next prev parent reply other threads:[~2020-01-13 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 7:03 Wei Yang
2020-01-13 13:22 ` Vlastimil Babka [this message]
2020-01-13 21:03 ` David Rientjes
2020-01-14 19:07 ` Ralph Campbell
2020-01-15 1:52 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=396ba7b6-15e7-998d-6c64-59519882e211@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox