From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C45C02185 for ; Mon, 20 Jan 2025 14:01:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF80028000B; Mon, 20 Jan 2025 09:01:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA7E228000A; Mon, 20 Jan 2025 09:01:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D47E728000B; Mon, 20 Jan 2025 09:01:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B8FBB28000A for ; Mon, 20 Jan 2025 09:01:24 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 766211C5559 for ; Mon, 20 Jan 2025 14:01:24 +0000 (UTC) X-FDA: 83027992488.08.6D29CAA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id E3C82100027 for ; Mon, 20 Jan 2025 14:01:20 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fuSi5zzF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737381681; a=rsa-sha256; cv=none; b=U1Ee0Y7QSONH0AaF5Vn7CVWL0ElFxDN9HfohYlvQhm5DMy/Pc5QP/C8skQskF/Ii6KnhrS xBlMzxgOPnbs2ejRYEwH4L9/NP72ryk9WD6MXFU2LinzuELIrVst+teE6Rs8Iew+uZOVCe XtRpkqo+x2RFQ4ryfFLfq43XW3UWsEQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fuSi5zzF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737381681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s/mkn72W8t1XUEbeDrh1A3farpkJnU2/T6YwPc/jj1M=; b=QD/SoLW3ExtclAfJg5c8OigEZowOQsbBtVb8CoxcgZsUdO+fjXA85Pzxjbw36xpGqqStvE uUIsMNiwHvAIYIrPb6gnrXd7uLhHf3W4X61h8nDudj/S0Mg+mvUoWrHe9+xDL7qUJC/tth 79HNOhRK4yltYpZKhHA4C3myIxCwS1g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737381679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=s/mkn72W8t1XUEbeDrh1A3farpkJnU2/T6YwPc/jj1M=; b=fuSi5zzFzX1glLmkSstwZ++syAkA3dTj8Hy0NT8EGKb90EdMqnPQlK32UNka/vbwy/rzBJ 3ONkkq8QYw3ATpLNi0krXxp+aTthYlH+ez73S0x14DQQ/o1v1p9IQrzdAVfz+UAasQV+Sq AzXyyHaZqIZ95b9INj9hiNN+CYVJ99w= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-o1S6WvLLPviy0PD3oHJCDQ-1; Mon, 20 Jan 2025 09:01:16 -0500 X-MC-Unique: o1S6WvLLPviy0PD3oHJCDQ-1 X-Mimecast-MFC-AGG-ID: o1S6WvLLPviy0PD3oHJCDQ Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385ed79291eso2615580f8f.0 for ; Mon, 20 Jan 2025 06:01:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737381676; x=1737986476; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=s/mkn72W8t1XUEbeDrh1A3farpkJnU2/T6YwPc/jj1M=; b=MLXinnA1qq21E9v3HyqFCdXkKPjBSDskJJSXLwQEV/pi3bsQ3VG4j3NXmK7/ib7sOp Zb2h5e0dY5hdTNOn5r5xJkz5UeyRaGvyTPmwd/kH0ObaHjynYSBuHGrn6JsAlozzCXLM rruMaod+cSh5ITEaQhukWN5NqtNJz3XWryN9RiasAyUqHPmbP0zPXO6HVUIVEEgxeAyt i4wR+5J2ex571rwnrTCM6i9CTg1GbGaZ9mXqf/pOin9ExK2TPX7qqK4zVfteYXhZeMnB Wxr0NQgdWGBOx06/NrrjkoLIGrba+6gDMh+CmC8xpK4Gv3Hadd3VdiOCBp4c/qHTmjWJ wSrQ== X-Forwarded-Encrypted: i=1; AJvYcCU4ztnZNVFGZrOzo3S+UtZGZQCNYB6HEgJyyo9QEmNB9Fdd4q08w9bOwZuoMpTzfag2RwX3Vvy81w==@kvack.org X-Gm-Message-State: AOJu0YzT1wDoEHTsWhlFivqx3ln/4I/NatwIxdyADOySzgtb++pBxNDY xn4PeQQFKZtnyK2DmWbqhP3wK43fvuKjOgKn7pgXHbS/O50ogmazuJYQOG3PUFC576ZRSk7DVMF i15YV0KFn+hWMdybRtJpgmECUU6r+Mnr+OC4TmHSHYpBpxg+4 X-Gm-Gg: ASbGnctM803CHN7Z6p7nSZZUQdksdOYjnzgClCs/ezfxgwp4RXEjVTPyrBMCESYn4/H 56MvjF+N92+Z/l6Ngupfxtt57Vf/gTUJyIxT33oOcPkrIJ1RedRe5SJAs6OHIpATLAgBUKeZuQV zILoWg6SwCHj50pDE5UUkWEu1MwjI0Is4NEP8in2mh7es6Fe6lo0sqDWefWu1QtfgdK2tWmvKXV bq6T5yX0KwF/041fdsy/L1Fmp68iQrsXoaJoUFiHy14SMekIfxg9uwg+9j4pgYkz23JlhvAMbz2 MMLJhHJ9pZoxk/flUWWJXTgJUzcuzbpUOjgD62GJk84Vim6g38mZ75WA/ap00mFujeWAUNMRjpx Kd1DJjGKQdrIh/IM72PX/FQ== X-Received: by 2002:a5d:64ad:0:b0:38a:5dc4:6dcd with SMTP id ffacd0b85a97d-38bf5b02b35mr11556563f8f.22.1737381674258; Mon, 20 Jan 2025 06:01:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkvpw6N9bbmfHHasViK+AHy/K6leeD0foDQE8jUVDigAwqhSf9+Yp1CRL595t8b3c+PzTPbg== X-Received: by 2002:a5d:64ad:0:b0:38a:5dc4:6dcd with SMTP id ffacd0b85a97d-38bf5b02b35mr11556158f8f.22.1737381670471; Mon, 20 Jan 2025 06:01:10 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3221b70sm10384941f8f.26.2025.01.20.06.01.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 06:01:09 -0800 (PST) Message-ID: <3964f3ff-ce24-4656-ae4b-bc9ffdf6532a@redhat.com> Date: Mon, 20 Jan 2025 15:01:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] mm: Clear uffd-wp PTE/PMD state on mremap() To: Ryan Roberts , Peter Xu Cc: Andrew Morton , Muchun Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Shuah Khan , =?UTF-8?Q?Miko=C5=82aj_Lenczewski?= , Mark Rutland , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, stable@vger.kernel.org References: <20250107144755.1871363-1-ryan.roberts@arm.com> <20250107144755.1871363-2-ryan.roberts@arm.com> <873aede9-bfcd-4c95-a93d-ec1881554f39@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <873aede9-bfcd-4c95-a93d-ec1881554f39@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tCVt0Gm435P3mSSSx-8AdZMIrpaaI8R0ooNUpm0MrF0_1737381676 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: E3C82100027 X-Rspamd-Server: rspam10 X-Stat-Signature: iziaiqhou9axgyzawuwcibeoxbcci996 X-HE-Tag: 1737381680-705590 X-HE-Meta: U2FsdGVkX19ut9GkjGBCY3qc1S9OLxFr8cExh4WEKVBf7acMJWh7Excqc/AB0cGOQDqA+XkOOoRDU8mYnRRLA9CrSsim9ZdXV3Onrw7SX9cth9x3AjqYzmM2pm9Iw1DB06lgp1eJe2qag21sf0ghr4WBcl9hFj1MrEK4kGsdVfliUHycyqBZcgeR0nWZy+U9X/IY7UqdSXtRo/R55//BuGELj6nuqFKcAc4K6zeIXw+SxCd/2bQkGgDCTdioryCT6/8vMn7UgdGbCYdyG8lQNes4WydkToQ8Im8vDAH78ejtELiS6xV6UPVvNS2VAZ7OkUOEu8nYs6T/2EUZRTJ+a6N6/qjbQyel61eb+GvbCZlxos6R66qEGk/2WqP8cPXR+fl6xrd15MvhOYPWaTIbhWoBt2KMsUA87d+nCwWEqrIrIOfQsFusJlP+CYxU3RUbvvlrMA1QVda520Apt3Rx7F5Azmbu0p21NyM1ZscZZXgnA0a4sBFBZMsGk23jmw58KGJ4QtMPhXMUqC83d+cvNcIYa1oqWR6W1tWwYCtE9qBq7YYd4k0o621GXiJW8oo0Kt8JYQ5cWLi7UCDbBaIwL8rWoG1lmkQmNmJLN0wCsjE8HA8JRK+dbvW6XXWkwAFkNxHFK8ftLYta4xM74HZ+WAwBWiZj4SuAHawCXZWZ095JzsvbieWqx9KmL04bs+A5UF9z2DPi3UOriRGCKX0/GTfQDoCbNkEdN3e41b8KSuaUv5tUD+PPNGrhuDqeDod2tmYcbP+kg9aFdcWyJ7UaBshXY3h6b/iB+W+kcrkSbMLrF4s5W7yYkLLv2OH9JEZRQNX2mhrnisFbnc0IAvQQJn1l+VkgbfWKzYsYpk4F9QNVgY8C8ITF9v70RStp8Ukt/WRovE67zl+etr/WyFjd1TMHqUfQ27snwXeafnbhM20XLE1Ls4OKk3P0ufmD0IG9s3ayXYkTFwPj9x0WfOn ZMruuf0u x7AfSTzViNWJlsZ+oJLqD+fa1NEi80gaQGdMwbDmLvOHMfV5SMK/tTv0UesDwM9iXMzJFawBIwgrHI0fBFZXWGa/Jbjkb4fj0+66Wyt9qh8dbnHFw6DouNOvtylwUlrij/q8o3FCUMkGqfOuDDVIah3C/4hyswvXHvvTwkD5A4H1W7bA6sL9H27nJ0RJbnB4MGSiNQrHH93TIJxZrKbMFWmoP02kd3dCQ0FgbzQfZvUM8WO0EVDOvMfyADCOsoJM4pwfFNwJMxfMRDiMVfuH9VT3h0mxWfuwfMcv1e9APM8kiYUhWLeRTUcWmKFxqZMkIZiXSUr1qXZjsIqOtf9gBIx79O5gXU4o3/spgFWbQoxlW3FuCA8jtzVGteT/pGYGQt1fKeU7CPdS+6BkTztA+E6c2/WPZ418MusiDMH6RhEsv97i4R97EMBRGMWvT4AZnumA3tjaupLkOhxVu5oJb8ngU6z3h9asC7m3w2nFk5VZEDvnIvoCxHaaHQZN160nKMdP1X0ZFbUZuNe1LP0Ov+g+UpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000090, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.01.25 10:04, Ryan Roberts wrote: > On 15/01/2025 20:28, Peter Xu wrote: >> On Tue, Jan 07, 2025 at 02:47:52PM +0000, Ryan Roberts wrote: >>> When mremap()ing a memory region previously registered with userfaultfd >>> as write-protected but without UFFD_FEATURE_EVENT_REMAP, an >>> inconsistency in flag clearing leads to a mismatch between the vma flags >>> (which have uffd-wp cleared) and the pte/pmd flags (which do not have >>> uffd-wp cleared). This mismatch causes a subsequent mprotect(PROT_WRITE) >>> to trigger a warning in page_table_check_pte_flags() due to setting the >>> pte to writable while uffd-wp is still set. >>> >>> Fix this by always explicitly clearing the uffd-wp pte/pmd flags on any >>> such mremap() so that the values are consistent with the existing >>> clearing of VM_UFFD_WP. Be careful to clear the logical flag regardless >>> of its physical form; a PTE bit, a swap PTE bit, or a PTE marker. Cover >>> PTE, huge PMD and hugetlb paths. >>> >>> Co-developed-by: Mikołaj Lenczewski >>> Signed-off-by: Mikołaj Lenczewski >>> Signed-off-by: Ryan Roberts >>> Closes: https://lore.kernel.org/linux-mm/810b44a8-d2ae-4107-b665-5a42eae2d948@arm.com/ >>> Fixes: 63b2d4174c4a ("userfaultfd: wp: add the writeprotect API to userfaultfd ioctl") >>> Cc: stable@vger.kernel.org >> >> Nothing I see wrong: >> >> Reviewed-by: Peter Xu > > Great thanks! Thanks Peter, for your feedback while I was out. I remember that I skimmed over it without anything obvious jumping at me, but decided to set it aside for later to take a closer look .... which never happened. Took another look, and it looks good to me! (we really must clear the uffd-wp flags when losing the VMA flag) -- Cheers, David / dhildenb