From: kamezawa.hiroyu@jp.fujitsu.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org, balbir@linux.vnet.ibm.com, xemul@openvz.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH 1/2][-mm][resend] res_counter limit change support ebusy
Date: Mon, 28 Jul 2008 17:39:14 +0900 (JST) [thread overview]
Message-ID: <3950798.1217234354197.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20080722014043.92272350.akpm@linux-foundation.org>
----- Original Message -----
>On Mon, 14 Jul 2008 17:11:54 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fuji
tsu.com> wrote:
>
>> +static inline int res_counter_set_limit(struct res_counter *cnt,
>> + unsigned long long limit)
>> +{
>> + unsigned long flags;
>> + int ret = -EBUSY;
>> +
>> + spin_lock_irqsave(&cnt->lock, flags);
>> + if (cnt->usage < limit) {
>> + cnt->limit = limit;
>> + ret = 0;
>> + }
>> + spin_unlock_irqrestore(&cnt->lock, flags);
>> + return ret;
>> +}
>
>Need I say it? This function is waaaaaay too large to be inlined.
Will rework and make this uninlined. (in this week)
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-07-28 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 8:11 KAMEZAWA Hiroyuki
2008-07-14 8:15 ` [PATCH 2/2][-mm][resend] memcg limit change shrink usage KAMEZAWA Hiroyuki
2008-07-22 8:45 ` Andrew Morton
2008-07-28 8:43 ` kamezawa.hiroyu
2008-07-28 8:53 ` Andrew Morton
2008-07-22 8:40 ` [PATCH 1/2][-mm][resend] res_counter limit change support ebusy Andrew Morton
2008-07-28 8:39 ` kamezawa.hiroyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3950798.1217234354197.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox