From: "Mika Penttilä" <mpenttil@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Hildenbrand <david@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
Balbir Singh <balbirs@nvidia.com>, Zi Yan <ziy@nvidia.com>,
Matthew Brost <matthew.brost@intel.com>,
Marco Pagani <marpagan@redhat.com>
Subject: Re: [PATCH v7 5/6] mm: add new testcase for the migrate on fault case
Date: Mon, 30 Mar 2026 09:40:35 +0300 [thread overview]
Message-ID: <394bec19-7313-46e2-b0b2-640492454d8a@redhat.com> (raw)
In-Reply-To: <acoWems-CNYT3cwo@infradead.org>
Hi,
On 3/30/26 09:21, Christoph Hellwig wrote:
> On Mon, Mar 30, 2026 at 07:30:16AM +0300, mpenttil@redhat.com wrote:
>> From: Mika Penttilä <mpenttil@redhat.com>
> This seems to lack a commit message.
>
> Also where is the real user of your changes? It seems like only this
> test case consumes it currently and you actually add dead code?
>
The changes add the possibility to do migration initiated by hmm_range_fault()
while handling faults. There are some advantages to it, like more efficient
flow, and you get the VMA populated (needed for migration).
Also, the current migrate_vma_setup() initiated flow is changed to use the new code,
so it's not dead code.
Thanks,
Mika
next prev parent reply other threads:[~2026-03-30 6:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 4:30 [PATCH v7 0/6] Migrate on fault for device pages mpenttil
2026-03-30 4:30 ` [PATCH v7 1/6] mm:/Kconfig changes for migrate " mpenttil
2026-03-30 6:20 ` Christoph Hellwig
2026-03-30 4:30 ` [PATCH v7 2/6] mm: Add helper to convert HMM pfn to migrate pfn mpenttil
2026-03-30 4:30 ` [PATCH v7 3/6] mm/hmm: do the plumbing for HMM to participate in migration mpenttil
2026-03-30 11:05 ` kernel test robot
2026-03-30 11:05 ` kernel test robot
2026-03-30 4:30 ` [PATCH v7 4/6] mm: setup device page migration in HMM pagewalk mpenttil
2026-03-30 4:30 ` [PATCH v7 5/6] mm: add new testcase for the migrate on fault case mpenttil
2026-03-30 6:21 ` Christoph Hellwig
2026-03-30 6:40 ` Mika Penttilä [this message]
2026-03-30 4:30 ` [PATCH v7 6/6] mm:/migrate_device.c: remove migrate_vma_collect_*() mpenttil
2026-03-30 6:22 ` Christoph Hellwig
2026-03-30 6:47 ` Mika Penttilä
2026-03-30 11:56 [RESEND PATCH v7 0/6] Migrate on fault for device pages mpenttil
2026-03-30 11:56 ` [PATCH v7 5/6] mm: add new testcase for the migrate on fault case mpenttil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=394bec19-7313-46e2-b0b2-640492454d8a@redhat.com \
--to=mpenttil@redhat.com \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=david@kernel.org \
--cc=hch@infradead.org \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marpagan@redhat.com \
--cc=matthew.brost@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox