From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA4E0C4708F for ; Wed, 2 Jun 2021 18:37:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 68C12610CB for ; Wed, 2 Jun 2021 18:37:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68C12610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C3A946B0036; Wed, 2 Jun 2021 14:37:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEB166B006C; Wed, 2 Jun 2021 14:37:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A64016B0070; Wed, 2 Jun 2021 14:37:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 71BE26B0036 for ; Wed, 2 Jun 2021 14:37:10 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 11027181AC9C6 for ; Wed, 2 Jun 2021 18:37:10 +0000 (UTC) X-FDA: 78209641020.02.799117F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id B7E6FC00CBE8 for ; Wed, 2 Jun 2021 18:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622659029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ktmy9OPHs7EKpTut0wBFjcJ9rL9I98RB0SACOwd6rGU=; b=ATD2IQBKULSZ+aJBYQKYVH9V3Ek/NhkC2dIgQBMbK04bcGGOIEj+k0/gad/kqFjYxP7bcq vcy7VinQQBiH3bkN6HQh1sfWtLeDiF7BgJWoEsJnHR9ZY3mYvN/7cZaPVRXMln+n62Mk6h Oa+SAj9zDpY8ixK7vTvuhH19IfgV5uY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-xKppD4X0PZGil_CUowZayw-1; Wed, 02 Jun 2021 14:37:04 -0400 X-MC-Unique: xKppD4X0PZGil_CUowZayw-1 Received: by mail-wr1-f69.google.com with SMTP id y11-20020adfe6cb0000b0290114d1db9b88so1366040wrm.19 for ; Wed, 02 Jun 2021 11:37:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ktmy9OPHs7EKpTut0wBFjcJ9rL9I98RB0SACOwd6rGU=; b=UH8opd7vd4ZR70UF5a+WLyRhcxybGQ7akBa6CoBW8PmHIbSAT83YtW0VdOG+bRtE6C 6kcZL4BvltLL/2q6gIdv5L7XmrvLIfGTcI9RExlAXXJ/sn/eABfw/fo/clJeLSclxFkx SKzdvBeS9XI8PFPlg5HOTVLjKPvZwRI68X92k3/WmPnUzNUn4PfI8lhPvR/xUjMamR1S 7ivS3wXrzHlPit3z6hEnZtbxnOz3m9ZH7c/PjX3ku/hZgqt5mEa3/pLFyqyG6yGKOtnr bdwo0JafB0feLWN+V1CltaMX6cYOiogarjBkv3nRJ1eZDLKMhRlHZ+rZne1wKziLtKNN W4EA== X-Gm-Message-State: AOAM5310zUKec+H0pTD6sP0GzMIjMxSNEmW4QEYE2TF7Gwdw4E1Akhf9 Yu/AyFNsZiyvgMsP8P6+yZg42a4Unv/UHCQowEO++Cl1Xid7kcpDo3qbDBGe0uD1W/0R412tfvL r3a5WShDxseU= X-Received: by 2002:a5d:638b:: with SMTP id p11mr34423236wru.90.1622659023530; Wed, 02 Jun 2021 11:37:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBuZOl6CTO6xLJEMDKsbIrEohcw7mAJ1hiJmAPcx8wm+2snvnOfx9z+oQgLtu61Q7rte0ThA== X-Received: by 2002:a5d:638b:: with SMTP id p11mr34423216wru.90.1622659023253; Wed, 02 Jun 2021 11:37:03 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6b6d.dip0.t-ipconnect.de. [91.12.107.109]) by smtp.gmail.com with ESMTPSA id 30sm851918wrl.37.2021.06.02.11.37.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 11:37:02 -0700 (PDT) Subject: Re: [PATCH v2 1/3] mm,page_alloc: Use {get,put}_online_mems() to get stable zone's values To: Oscar Salvador , Andrew Morton Cc: Dave Hansen , Michal Hocko , Anshuman Khandual , Vlastimil Babka , Pavel Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210602091457.17772-1-osalvador@suse.de> <20210602091457.17772-2-osalvador@suse.de> From: David Hildenbrand Organization: Red Hat Message-ID: <39473305-6e91-262d-bcc2-76b745a5b14a@redhat.com> Date: Wed, 2 Jun 2021 20:37:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210602091457.17772-2-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ATD2IQBK; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: ofqg1n8st657ykpipmnkh7iw1oprhw1z X-Rspamd-Queue-Id: B7E6FC00CBE8 X-Rspamd-Server: rspam02 X-HE-Tag: 1622659015-513495 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.06.21 11:14, Oscar Salvador wrote: > Currently, page_outside_zone_boundaries() takes zone's span_seqlock > when reading zone_start_pfn and spanned_pages so those values are > stable vs memory hotplug operations. > move_pfn_range_to_zone() and remove_pfn_range_from_zone(), which are > the functions that can change zone's values are serialized by > mem_hotplug_lock by mem_hotplug_{begin,done}, so we can just use > {get,put}_online_mems() on the readers. > > This will allow us to completely kill span_seqlock lock as no users > will remain after this series. > > Signed-off-by: Oscar Salvador > --- > mm/page_alloc.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index aaa1655cf682..296cb00802b4 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -582,17 +582,15 @@ void set_pageblock_migratetype(struct page *page, int migratetype) > static int page_outside_zone_boundaries(struct zone *zone, struct page *page) > { > int ret = 0; > - unsigned seq; > unsigned long pfn = page_to_pfn(page); > unsigned long sp, start_pfn; > > - do { > - seq = zone_span_seqbegin(zone); > - start_pfn = zone->zone_start_pfn; > - sp = zone->spanned_pages; > - if (!zone_spans_pfn(zone, pfn)) > - ret = 1; > - } while (zone_span_seqretry(zone, seq)); > + get_online_mems(); > + start_pfn = zone->zone_start_pfn; > + sp = zone->spanned_pages; > + if (!zone_spans_pfn(zone, pfn)) > + ret = 1; > + put_online_mems(); > > if (ret) > pr_err("page 0x%lx outside node %d zone %s [ 0x%lx - 0x%lx ]\n", > It's worth noting that memory offlining might hold the memory hotplug lock for quite some time. It's not a lightweight lock, compared to the seqlock we have here. I can see that page_outside_zone_boundaries() is only called from bad_range(). bad_range() is only called under VM_BUG_ON_PAGE(). Still, are you sure that it's even valid to block e.g., __free_one_page() and others for eventually all eternity? And I think that we might just call it from atomic context where we cannot even sleep. Long story short, using get_online_mems() looks wrong. Maybe the current lightweight reader/writer protection does serve a purpose? -- Thanks, David / dhildenb