From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A9AD3F281 for ; Fri, 18 Oct 2024 19:59:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69E316B00B5; Fri, 18 Oct 2024 15:59:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64DBC6B00B6; Fri, 18 Oct 2024 15:59:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A0636B00B7; Fri, 18 Oct 2024 15:59:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2A7086B00B5 for ; Fri, 18 Oct 2024 15:59:13 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 070E1819DE for ; Fri, 18 Oct 2024 19:59:02 +0000 (UTC) X-FDA: 82687786734.04.F00DD0D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 9FD3410001E for ; Fri, 18 Oct 2024 19:58:48 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KKR7pIDk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729281389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yIWx5rAtlYV9ME/Wl3a+Ac61PPsd2eNTIjoROcoLAxY=; b=DNQz6HSfO/ZwLJ3gkrTblBvF4It7wVFUwkarRcSI5xKADk3amBEuVVB6hcVN3GAzJx6+u5 UgTXtiLFzmNpvjsQ4/W6v7GcCfmHJrDXnR6zvliOInILRnG0VpaeROnoLQ0ePa3ARFhYKR D/I4vc498/Y9vuxPt3D4kuhq/uodxwA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729281389; a=rsa-sha256; cv=none; b=e9x2WV3k77DlrsWHe4ScbLghqSh4bswkEntOfKsmdFUGwSCPgHPbzpsEdvfKkxTH8qz6VA +ljcl0DK4GHwkLqgylPYuxPdm3xUKFtQpeDDXHNjx9vnV2xW0XSrvt4+py1t33KQ0jKTJ9 xLzwNASjU8XYw5tpm0BIFMibrjaLo9A= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KKR7pIDk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729281549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yIWx5rAtlYV9ME/Wl3a+Ac61PPsd2eNTIjoROcoLAxY=; b=KKR7pIDkACXXD6MZP5CoJwamSZ8T1pNpNCbmIFg193EutLxuobMnAiQ4y6DyBNiPrSXrkb to/QVluhAeRzqqSDc90yjSQi0BX3PxkYUa4gdBZH0sI/EtE0WAyruM58y/yOcko0bblvjh BEB9/+zvKPOhp2NVKeyYZCsoYXYm1wI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-Y5yZd-EUMQyzmjFuT8q-Kg-1; Fri, 18 Oct 2024 15:59:08 -0400 X-MC-Unique: Y5yZd-EUMQyzmjFuT8q-Kg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d609ef9f7so1227743f8f.3 for ; Fri, 18 Oct 2024 12:59:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729281547; x=1729886347; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yIWx5rAtlYV9ME/Wl3a+Ac61PPsd2eNTIjoROcoLAxY=; b=j6c3oOD5bGgexN/zF/jiYAxhgui3aoRmCt5979AiQ7iNJysRITXlLBJCygFxL+xBol AD8LndwI5V606+wMIjpkRJgLIx6M7kabypjXqIFIOtL8xIK6qhFV3zzGD2D5rco3HJgW mMXT0An3mZwCkCh3kAKPbR6W1U0/o897W+do960gzAF4SWKtBkFjHq2ofilst7QhEGGw lvTq49/mIVmC+OxmAbyl/OR+84s8cyQ8Og/YSeZjsw/+fbDMqrQiLFM2eqN3LVMHhS1E 4VfUcg4DcWhEtNj9ehIqryTQIfK0QggN6xnERXcSqNLnSVKmLrOuSWi5YtvwcsNHWmxM KiqA== X-Gm-Message-State: AOJu0Yy+8rKFC0JMwriWHhSqmUaWhQe/1f7WzobrXU/ABHAm5V8UyDnV PCNekHocMcOLGRGjuQ6tLs1aVeSo0jsiYbzVwyYrWlrs4FdW8/eS2oO7RyxTOyA/7e/JrvC+dnv X60jOdraVaYJs9kghgGca2nFhMh4uPC3I8Qqa/VZLeK0Errhd X-Received: by 2002:a05:6000:b45:b0:37d:47b3:7b86 with SMTP id ffacd0b85a97d-37eab6e4b77mr2520355f8f.44.1729281547094; Fri, 18 Oct 2024 12:59:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgZDJCtFrOUlaYYBqxBaEe63qGqkm5glFS1z/pNFJ9LP+nLq1MA80y9bEBSuZnI284nFHvwA== X-Received: by 2002:a05:6000:b45:b0:37d:47b3:7b86 with SMTP id ffacd0b85a97d-37eab6e4b77mr2520338f8f.44.1729281546634; Fri, 18 Oct 2024 12:59:06 -0700 (PDT) Received: from [192.168.3.141] (p4ff23b63.dip0.t-ipconnect.de. [79.242.59.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ecf027b89sm2676358f8f.16.2024.10.18.12.59.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2024 12:59:06 -0700 (PDT) Message-ID: <39370a6a-b0d8-4591-89b5-05817dea9ce5@redhat.com> Date: Fri, 18 Oct 2024 21:59:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 0/1] Buddy allocator like folio split To: Yang Shi , Zi Yan Cc: linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Ryan Roberts , Hugh Dickins , "Kirill A . Shutemov" , Yang Shi , Miaohe Lin , Kefeng Wang , Yu Zhao , John Hubbard , linux-kernel@vger.kernel.org References: <20241008223748.555845-1-ziy@nvidia.com> <7ec81ff8-5645-42a1-a048-c8700aff07fa@redhat.com> <9A314663-43F1-49B5-9225-0E326A4DB315@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9FD3410001E X-Stat-Signature: iwohtczst4tmg79r45jasew7bfft399j X-Rspam-User: X-HE-Tag: 1729281528-963773 X-HE-Meta: U2FsdGVkX19FHkx/XLVx2TjMU2iq2ptqQAxZlFGwYxIhxz8ilsZmMrhJbMZW4N9zzUNU9ecOyyj6D7JKQBUk2AkY250knrpIWdono32qqDrTvIkudbZG9CDpbIlywgQF4H5WWf6S3CLx3JKO9UdtINA4M/FxNJ6GJ1mJ4EGVP+mTiZmj5WRnX9IED4XYDFQ7Og24WCOgSx+yySrktNPbU9JFrnyaa//TglbpYZGWEwQSPfZeSpQtpqW8BowIvbuyH6AhsptOERas40RmP8PDYB3yeM0FhPVtadXvw30yBZYBYKt64TU8gPHCCpTlBENSXzjF+NGObQKB1u9HLua2pa2mRv3aJxnHJJgyyG+oeVCKfnzjD1PZLOQSlE4smXTPYujChtq/Uoryixtu+pTgbqyrdiKqnYNhtOY+TokI6Pbg1JeKVfMGi3Kv3fNDiF9yjhq6edzc1ehf4xc6giCi+ClwLPM2k9iy2sfckV3qDjSIgOr5oRQpWiKXXjodc67O+YJrC4lthIhC9qrpxkr7+Jd0/Vs3RbBIyb0OVy0pO7hVvk2Lxkmd0+L8g+5AQ0pOxbOoMP0RcUh02zMwSFwjTR9ItuVQIjKejdkbYb0Od/5jpGTlZT11U5tSMIh1bR7eUqG64RiX4SHM7YTgKliX6LYePaviHnzku3HV8qMsIgCyrJt4QP6bE4lgEpiM+6ha26heDVXJaTCmQnI/lxW7GJd6gEJSKHs+lP67sFPrW4hzybPVE7HIu6rG3QDMCqO3Mm9cEkHNfpEFxiCL3fKWFfZkf167UYQgFi7HqMakQ/iBwYZpzSG0xcYjYjM4abRejaC+HeOZmma6EXHBSI2mLSq93uPC4JWjcrN5wc/0C/NUOtjmksfpQE5qNPOwHTwf4XbFnRcpnjA2gTm7msqKAn04UXWD02xBmoZX5W5JDxp0JkbUcRhNgd/86EuDgnJhArTO6j1pxA+iN1h6u5N xlKu2Suv TOQRpTejC5X39ZrF4w5T+hMUzrqHByRZsy8hOCi71SoAnlAUljsytfR1TyUPe2v+O0c0NOcgzs5c2CNfpbbjGZW/NyHr9flOJVn3WZys9J9wAq5jrGCq2tJnGT4ZDQoGBMh9P/6WvfF2gFd/qoAUYefDbUeOpVMfttXdgnpfIKgUM1gOpL4XBesNv3ZSk4nK1EcuySXH7850K8ufdDIOJM6upg+fvIW3iwNgKc2FshEetZzUsZMVePN1vOrL9pi/73QtoWlz6tLTD0ZYtw6Tth8h4kQQ9BtiE/2sSGOn9pYWM/R/jBYw5Guxj2tacVsNMKh1RNhiB1CeIg/E69OXFl1mQ+4ADhZRxH0htKyj0OMZCI5jlrmZT4nLnpYl1Z6AxbjIGyNGjg15VoJYKjDdkRxNrkYwZyv3W7XWNCqdkkFmRb1SoHXG+2L0sEawiZjfIJ3+Eb29cXM4N4rEzsB90+qvvxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.10.24 21:44, Yang Shi wrote: > On Fri, Oct 18, 2024 at 12:11 PM Zi Yan wrote: >> >> On 18 Oct 2024, at 14:42, David Hildenbrand wrote: >> >>> On 09.10.24 00:37, Zi Yan wrote: >>>> Hi all, >>> >>> Hi! >>> >>>> >>>> Matthew and I have discussed about a different way of splitting large >>>> folios. Instead of split one folio uniformly into the same order smaller >>>> ones, doing buddy allocator like split can reduce the total number of >>>> resulting folios, the amount of memory needed for multi-index xarray >>>> split, and keep more large folios after a split. In addition, both >>>> Hugh[1] and Ryan[2] had similar suggestions before. >>>> >>>> The patch is an initial implementation. It passes simple order-9 to >>>> lower order split tests for anonymous folios and pagecache folios. >>>> There are still a lot of TODOs to make it upstream. But I would like to gather >>>> feedbacks before that. >>> >>> Interesting, but I don't see any actual users besides the debug/test interface wired up. >> >> Right. I am working on it now, since two potential users, anon large folios >> and truncate, might need more sophisticated implementation to fully take >> advantage of this new split. >> >> For anon large folios, this might be open to debate, if only a subset of >> orders are enabled, I assume folio_split() can only split to smaller >> folios with the enabled orders. For example, to get one order-0 from >> an order-9, and only order-4 (64KB on x86) is enabled, folio_split() >> can only split the order-9 to 16 order-0s, 31 order-4s, unless we are >> OK with anon large folios with not enabled orders appear in the system. > > For anon large folios, deferred split may be a problem too. The > deferred split is typically used to free the unmapped subpages by, for > example, MADV_DONTNEED. But we don't know which subpages are unmapped > without reading their _mapcount by iterating every subpages. Yeah, and I am still hoping we can get rid of the _mapcounts. If you know a folio is exclusive, at least synchronously during MADV_DONTNEED you know what you can try split. Deferred would require an rmap walk -- if it's really worth it. -- Cheers, David / dhildenb