From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF9BC43603 for ; Tue, 17 Dec 2019 14:16:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 376DC20663 for ; Tue, 17 Dec 2019 14:16:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="R4VeKMX5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 376DC20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D58DA8E006C; Tue, 17 Dec 2019 09:16:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0A028E0040; Tue, 17 Dec 2019 09:16:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF8BC8E006C; Tue, 17 Dec 2019 09:16:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id AAB778E0040 for ; Tue, 17 Dec 2019 09:16:39 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 2F13145A8 for ; Tue, 17 Dec 2019 14:16:39 +0000 (UTC) X-FDA: 76274834118.03.root07_1ce71d450793b X-HE-Tag: root07_1ce71d450793b X-Filterd-Recvd-Size: 3714 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Dec 2019 14:16:38 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id x1so8325025qkl.12 for ; Tue, 17 Dec 2019 06:16:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=ZkdzLix0g7TLx3w5KL71e42yAFa7G9Wu3yCJiO5zBhs=; b=R4VeKMX5z+UpczXH2iwhnXxVtV/oF7T7YQHHVdhLWz3zDT3WeJr7l93DvuR8yvVTv1 b8K8T6PxnmokRbgIrYOjdgQoidBrClvkj/ONfMxQ5qwk5O8VdAzKcNBZJRcqHTxrR9fv 6oZkLQMCNFUQ5RqfDFqqCiEYcPxcbVXU0GWa+V3TiQSvhU1WYhVdc+Wyyy3uWM0/S5EK hEiB9TnfsOs25eWmyhQX7mf8iQrlU2obMGSU/PBQ/Kdp7Cpq5otTFcelPh4cIsg5+vi1 l7/uWYHT18DpZM2q2zh8DATf6vrIqr3vrPVB6SD6pC+LUQX8NwBm0Pev0kzsqmMQ18g+ 1smA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=ZkdzLix0g7TLx3w5KL71e42yAFa7G9Wu3yCJiO5zBhs=; b=c+CF+1QjMOtUeZbOHE2rUVZh6aqyY87g2+i0qhUd8nwgMhT0gpabWpUKvylJORFS2U R8EacNC6LPOXQ6OCEf7OorMad4Vsfi/9tXhUXXoYSlM2TfBaweq/5Yb5jJivHjghhqQA W4SimDet/gvaBBYUfCCJNo+GFlUKfWa/pdfQtvx93h2+dR0MuutGQclGYy1PGyFYHdNs D5EHrEZypv2RJLmg5YxKKxTLSqFSpOEfFeN/2zDYyGnkagmwPSFsE9f+hNdu3UufU5Xg 6vEW5lesYlu1fNojj30/+8FoUq+zAmKTM7KmQfZ62OSkA2YO1g/tUnnZhVm7yMr3q7eT VlGw== X-Gm-Message-State: APjAAAWTPdIYHvHjjTcZzcSSE9kmsHi4moHB94vsZiW8i4yZszVKfpRk nzAGid1nUSKTCod6rrnYJ6uSgA== X-Google-Smtp-Source: APXvYqyIaW9SH9dIo0nTwluwbMjOkaOIBAywH/CZvwYvSZJusUJQDeyKQIEbOh3B2HI/AZvYCG2apQ== X-Received: by 2002:a37:a807:: with SMTP id r7mr5369874qke.346.1576592197757; Tue, 17 Dec 2019 06:16:37 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id v2sm7089372qkj.29.2019.12.17.06.16.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 06:16:37 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU Date: Tue, 17 Dec 2019 09:16:36 -0500 Message-Id: <392D7C59-5538-4A9B-8974-DB0B64880C2C@lca.pw> References: <20191217135440.GB58496@chrisdown.name> Cc: Michal Hocko , Kuninori Morimoto , Johannes Weiner , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20191217135440.GB58496@chrisdown.name> To: Chris Down X-Mailer: iPhone Mail (17C54) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Dec 17, 2019, at 8:54 AM, Chris Down wrote: >=20 > Let's just add __maybe_unused, since it seems like what we want in this sc= enario -- it avoids new users having to enter preprocessor madness, while al= so not polluting the build output. __maybe_unused should only be used in the last resort as it mark the compile= r to catch the real issues in the future. In this case, it might be better j= ust ignore it as only non-realistic compiling test would use !CONFIG_MMU in t= his case.=