From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1D7C4727D for ; Tue, 22 Sep 2020 10:13:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E804238D6 for ; Tue, 22 Sep 2020 10:13:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E804238D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE172900052; Tue, 22 Sep 2020 06:13:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6A3D900036; Tue, 22 Sep 2020 06:13:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0AA1900052; Tue, 22 Sep 2020 06:13:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 85911900036 for ; Tue, 22 Sep 2020 06:13:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 364EC3623 for ; Tue, 22 Sep 2020 10:13:40 +0000 (UTC) X-FDA: 77290285800.08.paste06_4e0b1cf2714c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 1760A1819E76C for ; Tue, 22 Sep 2020 10:13:40 +0000 (UTC) X-HE-Tag: paste06_4e0b1cf2714c X-Filterd-Recvd-Size: 2449 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Sep 2020 10:13:39 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90D4F1516; Tue, 22 Sep 2020 03:13:38 -0700 (PDT) Received: from [10.37.8.152] (unknown [10.37.8.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE4853F718; Tue, 22 Sep 2020 03:13:35 -0700 (PDT) Subject: Re: [PATCH v2 22/37] arm64: mte: Add in-kernel MTE helpers To: Catalin Marinas Cc: Andrey Konovalov , Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <4ac1ed624dd1b0851d8cf2861b4f4aac4d2dbc83.1600204505.git.andreyknvl@google.com> <20200917134653.GB10662@gaia> <7904f7c2-cf3b-315f-8885-e8709c232718@arm.com> <20200918093656.GB6335@gaia> From: Vincenzo Frascino Message-ID: <392180d4-95cf-fed9-5650-bbf52ec5c087@arm.com> Date: Tue, 22 Sep 2020 11:16:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200918093656.GB6335@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/18/20 10:36 AM, Catalin Marinas wrote: >> Same as above but I will use the orr in the next version. > I wonder whether system_supports_mte() makes more sense here than the > alternative: > > if (!system_supports_mte()) > return 0xff; > > ... mte irg stuff ... > > (you could do the same for the mte_get_mem_tag() function) > This would have been my preference from the beginning but then you mentioned alternatives ;) Anyway, more then happy to change the code in this way, seems more clean and easy to understand. -- Regards, Vincenzo