From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304BCE77180 for ; Tue, 10 Dec 2024 21:12:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24CFC6B0192; Tue, 10 Dec 2024 16:12:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FC546B0196; Tue, 10 Dec 2024 16:12:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C3FD6B0198; Tue, 10 Dec 2024 16:12:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E16E86B0192 for ; Tue, 10 Dec 2024 16:12:18 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9462F80AD6 for ; Tue, 10 Dec 2024 21:12:18 +0000 (UTC) X-FDA: 82880295960.20.FA247F6 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf03.hostedemail.com (Postfix) with ESMTP id E199A20011 for ; Tue, 10 Dec 2024 21:12:05 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=Ks6wF4WD; spf=none (imf03.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733865113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pWl+DoLp0B19v+ccbH7KTwZvEdcgO1RiPrIKqvG36yw=; b=3+WibQ0gos747TqzXr/VUDvu/shckKZdBEh1oyjTx+OKLlUkAoGY4dqixcyF/pYRLGcnrm rflr6torDp/VHOjs+R/prAhIH21QnU2jOQdrAc3WwQTGe0ymIw/bweY8+VyXkrMvDTUCr/ I0aAkjbzfbJOXf+/RgNKGlKeSgHhop0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=Ks6wF4WD; spf=none (imf03.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733865113; a=rsa-sha256; cv=none; b=6HcNmWvRXuaZJJ9XQ9yLNc0e4+tqjPc33mDlxV1lcR6yuYA+QQDO2We2GXnuolfY4TtLvU zStFnhY7TYhZJ62JXVnU0Iw9B0vwlZmfcpKKi3KR2q0u2fXFnfVIJc7voxJvFDtZSz7DP+ bn9YH8tfc48aBKtAX9/5tR6bQ6FfoGU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:To:Subject:MIME-Version:Date:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=pWl+DoLp0B19v+ccbH7KTwZvEdcgO1RiPrIKqvG36yw=; b=Ks6wF4WDIa88ZrBviT77i64QEP z0/eIDYnsI/5C9SnKcBLOIaEsQptBDTNSppYZBTHejy7xYSX3Ko/R/9Rdyyog2GMaAXjJKFi1ih3t Bx1OW6DQKGu5atLQyau93Jk8XFWygjeYMJ1jd3nT3qvQOAAf//2ylD4vCJZkBGQqQiqHE5sXCBDCt 9MWkT609GGtB8kgRbGx6eg4MEQLvimXloVYVdwAsW1NwRrUj0pFc8P/MKty0M/tafxIC5ZXt3/6Bp 9KgR+NKrouP6tI8wSUpeEvw+fYF+R1lmH79NgQ3hO/jr6r5G6PXKSJsGhQy+ZYOB/6/eKtdsD8P/q kx7tzKdg==; Received: from [50.53.2.24] (helo=[192.168.254.17]) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tL7WZ-00000003jG4-3hSc; Tue, 10 Dec 2024 21:12:08 +0000 Message-ID: <391b9d5f-ec3a-4c90-8345-5dab929917f7@infradead.org> Date: Tue, 10 Dec 2024 13:12:01 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 16/19] fsnotify: generate pre-content permission event on page fault To: Klara Modin , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org References: <5d0cd660-251c-423a-8828-5b836a5130f9@gmail.com> Content-Language: en-US From: Randy Dunlap In-Reply-To: <5d0cd660-251c-423a-8828-5b836a5130f9@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E199A20011 X-Rspam-User: X-Stat-Signature: h38h9fz59gyg9jdx16e51r1iwn4tzjzk X-HE-Tag: 1733865125-822689 X-HE-Meta: U2FsdGVkX1+ngDnk/WrISMeSMcXCl/NWtxWAVGlsFAS8YYbwUkNDCFcstlNds27lUsmpGIkyH+KVYyYJP/tV/VKGaH2gNt3TU3TxzSqM6J4/2OM4XK76AaqE4JL66FSLio3aJTE/myszIdkhDK/bxONY2SvfBZ9Xy6NTASLEeG4wxaR1D8OJ8ns/g2TzZpeN0kR01sU4Ttt2/ghMoJlopFPq6UvaR6ikJuEVk1GcFE+84kqmbTuN5eO5qet9WZMs1h9kPphPCZ5OUtspdyE+NvnJ398dd8H7/Cl/3oXZoG5UrEc1wv6mEl5Dq6w5C4B1hFuwJZhqyLp4cvJ/pLvOi3YANKwa9jVK0digrvPOe7SaAl8gqM0GAPmhsoZokFR6edDo8QPf3i5AKWdq6GegDnlvSVtsNWrnmdCl04nz+dqlzqCQBRCuCnHgfuRTzLYVI2oWWCUQn6LyIhC/mrg6S2Q+GpCNLKAfte3hrhB+TMJrXTfd+IHuBVhIJrqboujWmG0P0dCv7Br2xe1NgjOlivMefu2F31/2+nbNOFPqDEq9XThpbT/rcXIeq01epak+f7+xK0hCWoj/PPMnOPW8zAPZl/i7l2wueoUaqiM7a+B/146iYmKQ2VD+Zc/dICrOW2IbnVJvZaiosO1f3OBpmwYIBmiHqSXGIcEp5VvPwrAayXsPRxdnddvX/P6hyhaNViqiutQFvqEjWrub8nDL2hKTF7yCwyrhgaDiTIgQR/vZaAxtuZIZs++Gce2Avo6+jiK6qWI1o9s4brOJx+UPmamT3ZC+J9Aju2UKdNbEaWxMpxsMtXyW1xFS+oR6V6m0Ins5/Q4SZ/4DzU2TZdCCr/tTUBzkceoC9Dr82/qYBs2R0ZEkrVaS/CF6GiW24kUxd36/7MZ0hi5oWhUYWrXKS5Mj/tmsuyAm81Y8VYP2rWHIqZTSjUN/HB9wlIWCz+hqVRYN6KIxgKPQ4iYcEzv cIavTFd0 Xahpo/Dk3RlT87h7EeXR96p6MsD1RGEZH5oAOJqrkU+y1hd7jWxmp1M96v/7vxAmh6553/BK/eqC0YA7cPFfQ9DOk+Ijsgr08xtabZW51ivNQ6UmyLi4hVn76SLuB4NLPUO45XLoVLg7S51YRHuhunAjyA5BIqHxvIp1an3Zyv8IFnPXv3PZJ48avBqOm25Lcnd9N9HRNHFbTjnWZyuTBMgHwR8rryWSzaUh+PRLplzuLpoZV+CsvalPzD2nvm2OMsXJtresRaGnHzSpWdX+aItuzLGDpeSNwsQhd9dtzhB6sCl6mud6lGEJeFA6laWNb3BmTmozQxGjN10yZ0Smp56AGH42+F1Ovy3Hhsgg39LOC4xoFeWMBap0HsjVLSCIWxMp1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/8/24 8:58 AM, Klara Modin wrote: >> +/** >> + * filemap_fsnotify_fault - maybe emit a pre-content event. >> + * @vmf:    struct vm_fault containing details of the fault. >> + * @folio:    the folio we're faulting in. >> + * >> + * If we have a pre-content watch on this file we will emit an event for this >> + * range.  If we return anything the fault caller should return immediately, we >> + * will return VM_FAULT_RETRY if we had to emit an event, which will trigger the >> + * fault again and then the fault handler will run the second time through. >> + * >> + * This is meant to be called with the folio that we will be filling in to make >> + * sure the event is emitted for the correct range. >> + * >> + * Return: a bitwise-OR of %VM_FAULT_ codes, 0 if nothing happened. >> + */ >> +vm_fault_t filemap_fsnotify_fault(struct vm_fault *vmf) > > The parameters mentioned above do not seem to match with the function. which causes a warning: mm/filemap.c:3289: warning: Excess function parameter 'folio' description in 'filemap_fsnotify_fault' -- ~Randy