From: "Luck, Tony" <tony.luck@intel.com>
To: Toshi Kani <toshi.kani@hpe.com>, "bp@alien8.de" <bp@alien8.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM
Date: Mon, 26 Oct 2015 16:46:28 +0000 [thread overview]
Message-ID: <3908561D78D1C84285E8C5FCA982C28F32B5F6D2@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <1445877115.20657.88.camel@hpe.com>
> + ((param2 & PAGE_MASK) != PAGE_MASK))
> return -EINVAL;
>
> The 3rd condition check makes sure that the param2 mask is the page size or less. So, I
> think we are OK on this.
Oops. The original was even on the screen as part of the diff (which I signed off on just two years ago).
I'd be happier if you made it the 1st condition though, so we skip calling region_intersects_*() with
a nonsense "size" argument.
-Tony
next prev parent reply other threads:[~2015-10-26 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 15:03 Toshi Kani
2015-10-26 16:26 ` Luck, Tony
2015-10-26 16:31 ` Toshi Kani
2015-10-26 16:46 ` Luck, Tony [this message]
2015-10-26 16:51 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3908561D78D1C84285E8C5FCA982C28F32B5F6D2@ORSMSX114.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=rjw@rjwysocki.net \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox