From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com [209.85.192.181]) by kanga.kvack.org (Postfix) with ESMTP id 56E556B0032 for ; Mon, 29 Jun 2015 19:12:02 -0400 (EDT) Received: by pdbep18 with SMTP id ep18so102541650pdb.1 for ; Mon, 29 Jun 2015 16:12:01 -0700 (PDT) Received: from mga03.intel.com (mga03.intel.com. [134.134.136.65]) by mx.google.com with ESMTP id ty5si66710962pac.54.2015.06.29.16.12.00 for ; Mon, 29 Jun 2015 16:12:01 -0700 (PDT) From: "Luck, Tony" Subject: RE: [RFC v2 PATCH 7/8] mm: add the buddy system interface Date: Mon, 29 Jun 2015 23:11:30 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F32AA124A@ORSMSX114.amr.corp.intel.com> References: <558E084A.60900@huawei.com> <558E0A28.6060607@huawei.com> In-Reply-To: <558E0A28.6060607@huawei.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Xishi Qiu , Andrew Morton , "H. Peter Anvin" , Ingo Molnar , Hanjun Guo , Xiexiuqi , "leon@leon.nu" , Kamezawa Hiroyuki , "Hansen, Dave" , Naoya Horiguchi , Vlastimil Babka , Mel Gorman Cc: Linux MM , LKML > @@ -814,7 +814,7 @@ int __init_memblock memblock_clear_hotplug(phys_addr_= t base, phys_addr_t size) > */ > int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t s= ize) > { > - system_has_some_mirror =3D true; > + static_key_slow_inc(&system_has_mirror); >=20 > return memblock_setclr_flag(base, size, 1, MEMBLOCK_MIRROR); > } This generates some WARN_ON noise when called from efi_find_mirror(): [ 0.000000] e820: last_pfn =3D 0x7b800 max_arch_pfn =3D 0x400000000 [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: CPU: 0 PID: 0 at kernel/jump_label.c:61 static_key_= slow_inc+0x57/0xc0() [ 0.000000] static_key_slow_inc used before call to jump_label_init [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.1.0 #4 [ 0.000000] Hardware name: Intel Corporation BRICKLAND/BRICKLAND, BIOS B= RHSXSD1.86B.0065.R01.1505011640 05/01/2015 [ 0.000000] 0000000000000000 ee366a8dff38f745 ffffffff81997d68 ffffffff= 816683b4 [ 0.000000] 0000000000000000 ffffffff81997dc0 ffffffff81997da8 ffffffff= 8107b0aa [ 0.000000] ffffffff81d48822 ffffffff81f281a0 0000000040000000 0000001f= cb7a4000 [ 0.000000] Call Trace: [ 0.000000] [] dump_stack+0x45/0x57 [ 0.000000] [] warn_slowpath_common+0x8a/0xc0 [ 0.000000] [] warn_slowpath_fmt+0x55/0x70 [ 0.000000] [] ? memblock_add_range+0x175/0x19e [ 0.000000] [] static_key_slow_inc+0x57/0xc0 [ 0.000000] [] memblock_mark_mirror+0x19/0x33 [ 0.000000] [] efi_find_mirror+0x59/0xdd [ 0.000000] [] setup_arch+0x642/0xccf [ 0.000000] [] ? early_idt_handler_array+0x120/0x120 [ 0.000000] [] ? printk+0x55/0x6b [ 0.000000] [] ? early_idt_handler_array+0x120/0x120 [ 0.000000] [] start_kernel+0xe8/0x4eb [ 0.000000] [] ? early_idt_handler_array+0x120/0x120 [ 0.000000] [] ? early_idt_handler_array+0x120/0x120 [ 0.000000] [] x86_64_start_reservations+0x2a/0x2c [ 0.000000] [] x86_64_start_kernel+0x14c/0x16f [ 0.000000] ---[ end trace baa7fa0514e3bc58 ]--- [ 0.000000] ------------[ cut here ]------------ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org