From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Chen, Gong" <gong.chen@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: RE: [RFC PATCH 2/3] x86, MCE: Avoid potential deadlock in MCE context
Date: Mon, 21 Jul 2014 22:03:04 +0000 [thread overview]
Message-ID: <3908561D78D1C84285E8C5FCA982C28F32871435@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20140721214116.GC11555@pd.tnic>
> And drop all the homegrown other stuff like mce_ring and all?
mce_ring should be easy ... the "mce" structure has the address
from which we can easily get the pfn to pass into the action-optional
recovery path. Only thing missing is a direct indication that this mce
does contain an AO error that needs to be processed. We could
re-invoke mce_severity() to figure it out again - or just add a flag
somewhere.
Not so sure about mce_info. This one passes from the
MCE context to the same task when we catch it in process
context (set_thread_flag(MCE_NOTIFY)). Back when I was pushing
this code it, I really wanted to just add a field to the thread_info
structure to hold the address ... because this really is some
information that belongs to the thread. But I was unable to
convince people back then. We must be able to find the
page frame when we arrive in mce_notify_process(). So we
can't stash it in some limited size pool of "mce" structures that
might decide to just drop this one.
-Tony
next prev parent reply other threads:[~2014-07-21 22:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 2:34 Some RAS bug fix patches Chen, Gong
2014-07-16 2:34 ` [PATCH 1/3] APEI, GHES: Cleanup unnecessary function for lock-less list Chen, Gong
2014-07-20 8:01 ` Borislav Petkov
2014-07-16 2:34 ` [RFC PATCH 2/3] x86, MCE: Avoid potential deadlock in MCE context Chen, Gong
2014-07-21 8:47 ` Borislav Petkov
2014-07-21 17:14 ` Luck, Tony
2014-07-21 21:41 ` Borislav Petkov
2014-07-21 22:03 ` Luck, Tony [this message]
2014-07-21 22:44 ` [RFC PATCH 2/3] x86, MCE: Avoid potential deadlock in MCE Tony Luck
2014-07-22 17:20 ` Borislav Petkov
2014-07-22 17:26 ` [RFC PATCH 2/3] x86, MCE: Avoid potential deadlock in MCE context Borislav Petkov
2014-07-22 21:24 ` Tony Luck
2014-07-23 7:48 ` Chen, Gong
2014-07-16 2:34 ` [PATCH 3/3] RAS, HWPOISON: Fix wrong error recovery status Chen, Gong
2014-07-16 19:57 ` Naoya Horiguchi
2014-07-19 8:05 ` Some RAS bug fix patches Chen, Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3908561D78D1C84285E8C5FCA982C28F32871435@ORSMSX114.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox