linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Tejun Heo <tj@kernel.org>, Tang Chen <imtangchen@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Tang Chen <tangchen@cn.fujitsu.com>,
	"Moore, Robert" <robert.moore@intel.com>,
	"Zheng, Lv" <lv.zheng@intel.com>, "rjw@sisk.pl" <rjw@sisk.pl>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"trenn@suse.de" <trenn@suse.de>,
	"yinghai@kernel.org" <yinghai@kernel.org>,
	"jiang.liu@huawei.com" <jiang.liu@huawei.com>,
	"wency@cn.fujitsu.com" <wency@cn.fujitsu.com>,
	"laijs@cn.fujitsu.com" <laijs@cn.fujitsu.com>,
	"isimatu.yasuaki@jp.fujitsu.com" <isimatu.yasuaki@jp.fujitsu.com>,
	"izumi.taku@jp.fujitsu.com" <izumi.taku@jp.fujitsu.com>,
	"mgorman@suse.de" <mgorman@suse.de>,
	"minchan@kernel.org" <minchan@kernel.org>,
	"mina86@mina86.com" <mina86@mina86.com>,
	"gong.chen@linux.intel.com" <gong.chen@linux.intel.com>,
	"vasilis.liaskovitis@profitbricks.com"
	<vasilis.liaskovitis@profitbricks.com>,
	"lwoodman@redhat.com" <lwoodman@redhat.com>,
	"riel@redhat.com" <riel@redhat.com>,
	"jweiner@redhat.com" <jweiner@redhat.com>,
	"prarit@redhat.com" <prarit@redhat.com>,
	"zhangyanfei@cn.fujitsu.com" <zhangyanfei@cn.fujitsu.com>,
	"yanghy@cn.fujitsu.com" <yanghy@cn.fujitsu.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH part5 0/7] Arrange hotpluggable memory as ZONE_MOVABLE.
Date: Mon, 12 Aug 2013 20:49:42 +0000	[thread overview]
Message-ID: <3908561D78D1C84285E8C5FCA982C28F31CB74A1@ORSMSX106.amr.corp.intel.com> (raw)
In-Reply-To: <20130812202029.GB8288@mtj.dyndns.org>

>> This point, I don't quite agree. What you said is highly likely, but
>> not definitely. Users may find they lost hotpluggable memory.
>
> I'm having difficult time buying that.  NUMA node granularity is
> usually pretty large - it's in the range of gigabytes.  By comparison,
> the area occupied by the kernel image is *tiny* and it's just highly
> unlikely that allocating a bit more memory afterwards would lead to
> any meaningful difference in hotunplug support.  The amount of memory
> we're talking about is likely to be less than a meg, right?

Pretty safe to assume double-digit gigabytes for a removable chunk
(8G DIMMs are fast becoming standard, and there are typically 4 channels
to populate with at least one DIMM each). 16G and 32G DIMMs are pricey,
but moving in too.  So I don't think we need to assume that early allocations
are limited to some tiny amount measured in single digit megabytes. We'd
be safe even with some small number of gigabytes.

> I don't think it's a better solution.  It's fragile and fiddly and
> without much, if any, additional benefit.  Why should we do that when
> we can almost trivially solve the problem almost in memblock proper in
> a way which is completely firmware-agnostic?

So we do need to make sure that early memory allocations do happen from
the free areas adjacent to the kernel - and document that as a requirement
so we don't have people coming along later with a "allocate from top of memory
downwards" or other strategy that would break this assumption.  If we do that,
then I think I stand with Tejun that there is little benefit to parsing the SRAT
earlier.

The only fly I see in the ointment here is the crazy fragmentation of physical
memory below 4G on X86 systems.  Typically it will all be on the same node.
But I don't know if there is any specification that requires it be that way. If some
"helpful" OEM decided to make some "lowmem" (below 4G) be available on
every node, they might in theory do something truly awesomely strange.  But
even here - the granularity of such mappings tends to be large enough that
the "allocate near where the kernel was loaded" should still work to make those
allocations be on the same node for the "few megabytes" level of allocations.

-Tony

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-08-12 20:49 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08 10:16 Tang Chen
2013-08-08 10:16 ` [PATCH part5 1/7] x86: get pg_data_t's memory from other node Tang Chen
2013-08-12 14:39   ` Tejun Heo
2013-08-12 15:12     ` Tang Chen
2013-08-08 10:16 ` [PATCH part5 2/7] x86, numa, mem_hotplug: Skip all the regions the kernel resides in Tang Chen
2013-08-08 10:16 ` [PATCH part5 3/7] memblock, numa: Introduce flag into memblock Tang Chen
2013-08-08 10:16 ` [PATCH part5 4/7] memblock, mem_hotplug: Introduce MEMBLOCK_HOTPLUG flag to mark hotpluggable regions Tang Chen
2013-08-08 10:16 ` [PATCH part5 5/7] memblock, mem_hotplug: Make memblock skip hotpluggable regions by default Tang Chen
2013-08-14 21:54   ` Naoya Horiguchi
2013-08-15  5:15     ` Tang Chen
2013-08-08 10:16 ` [PATCH part5 6/7] mem-hotplug: Introduce movablenode boot option to {en|dis}able using SRAT Tang Chen
2013-08-08 10:16 ` [PATCH part5 7/7] x86, numa, acpi, memory-hotplug: Make movablenode have higher priority Tang Chen
2013-08-09 16:32 ` [PATCH part5 0/7] Arrange hotpluggable memory as ZONE_MOVABLE Tejun Heo
2013-08-12  6:33   ` Tang Chen
2013-08-12  8:54   ` Tang Chen
2013-08-12 14:50 ` Tejun Heo
2013-08-12 15:14   ` H. Peter Anvin
2013-08-12 15:23     ` Tejun Heo
2013-08-12 16:29       ` Tang Chen
2013-08-12 16:46         ` Tejun Heo
2013-08-12 18:23           ` Tang Chen
2013-08-12 20:20             ` Tejun Heo
2013-08-12 20:49               ` Luck, Tony [this message]
2013-08-12 20:54                 ` Tejun Heo
2013-08-12 20:57                   ` H. Peter Anvin
2013-08-12 21:06                     ` Yinghai Lu
2013-08-12 21:08                       ` Tejun Heo
2013-08-12 21:12                         ` H. Peter Anvin
2013-08-12 21:14                           ` Tejun Heo
2013-08-12 21:11                       ` H. Peter Anvin
2013-08-12 21:11                   ` Luck, Tony
2013-08-12 21:25                     ` Yinghai Lu
2013-08-12 21:28                       ` H. Peter Anvin
2013-08-13  5:14                     ` H. Peter Anvin
2013-08-13  6:14           ` Tang Chen
2013-08-13  9:56             ` Tang Chen
2013-08-13 14:38               ` Tejun Heo
2013-08-13 22:33               ` Yinghai Lu
2013-08-14  1:22                 ` Tang Chen
2013-08-15 19:06                   ` Toshi Kani
2013-08-15 20:28                     ` Yinghai Lu
2013-08-16  2:08                       ` Tang Chen
2013-08-16  4:21                         ` Yinghai Lu
2013-08-19  3:07                           ` Tang Chen
2013-08-19  3:28                             ` Yinghai Lu
2013-08-15  8:42                 ` Tang Chen
2013-08-15 12:19                   ` Tejun Heo
2013-08-15 12:44                     ` Tang Chen
2013-08-15 12:49                       ` Tejun Heo
2013-08-15 12:52                         ` Tang Chen
2013-08-15 14:37                       ` Yinghai Lu
2013-08-15 14:45                         ` Tejun Heo
2013-08-15 15:05                           ` Yinghai Lu
2013-08-15 15:10                             ` Tejun Heo
2013-08-15 19:49                               ` Toshi Kani
2013-08-15 19:08                             ` Luck, Tony
2013-08-15 19:34                               ` Yinghai Lu
2013-08-15 14:35                   ` Yinghai Lu
2013-08-16  1:16                     ` Tang Chen
2013-08-12 15:41   ` Tang Chen
2013-08-12 15:46     ` Tejun Heo
2013-08-12 16:19       ` Tang Chen
2013-08-12 16:22         ` Tejun Heo
2013-08-12 17:01           ` Tang Chen
2013-08-12 17:23             ` H. Peter Anvin
2013-08-14 18:22               ` KOSAKI Motohiro
2013-08-12 18:07             ` Tejun Heo
2013-08-14 18:15               ` KOSAKI Motohiro
2013-08-14 18:23                 ` Tejun Heo
2013-08-14 19:40                   ` KOSAKI Motohiro
2013-08-14 19:55                     ` Tejun Heo
2013-08-14 20:29                       ` KOSAKI Motohiro
2013-08-14 20:30                         ` H. Peter Anvin
2013-08-14 20:35                         ` Tejun Heo
2013-08-14 21:17                           ` KOSAKI Motohiro
2013-08-14 21:36                             ` Tejun Heo
2013-08-15  1:08                               ` KOSAKI Motohiro
2013-08-15  1:21                                 ` Tejun Heo
2013-08-15  1:33                                   ` Tejun Heo
2013-08-15  1:44                                     ` KOSAKI Motohiro
2013-08-15  2:22                                       ` Tejun Heo
2013-08-15  1:38                                   ` KOSAKI Motohiro
2013-08-15  1:51                                     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3908561D78D1C84285E8C5FCA982C28F31CB74A1@ORSMSX106.amr.corp.intel.com \
    --to=tony.luck@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=gong.chen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=imtangchen@gmail.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=jiang.liu@huawei.com \
    --cc=jweiner@redhat.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lv.zheng@intel.com \
    --cc=lwoodman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=mingo@elte.hu \
    --cc=prarit@redhat.com \
    --cc=riel@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=robert.moore@intel.com \
    --cc=tangchen@cn.fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=trenn@suse.de \
    --cc=vasilis.liaskovitis@profitbricks.com \
    --cc=wency@cn.fujitsu.com \
    --cc=x86@kernel.org \
    --cc=yanghy@cn.fujitsu.com \
    --cc=yinghai@kernel.org \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox