From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C49D3CCF9FA for ; Fri, 31 Oct 2025 10:20:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D9DD8E00F9; Fri, 31 Oct 2025 06:20:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28AA68E0042; Fri, 31 Oct 2025 06:20:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A0E28E00F9; Fri, 31 Oct 2025 06:20:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0A7518E0042 for ; Fri, 31 Oct 2025 06:20:00 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0F39E1A0462 for ; Fri, 31 Oct 2025 10:19:59 +0000 (UTC) X-FDA: 84058013718.14.A8BF71C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 89BC340002 for ; Fri, 31 Oct 2025 10:19:56 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CIWITPg3; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1761905996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OUhdGI6/kAp9JoyXZrueKpHAebmQrRzAuLyMXHq++7U=; b=Hms1mTCrh8gAid4HBOLDX8mlEQC4Nme7sqaeXUUMCuh9aqcamybY6xnjl0HztLr83hrJit O7gthqcTueS1Vf6yk4pd+n40dTAV074EsQw2z6HOLju2hpgSkK6WbLjKK8TjTDYlCe5Yb+ 0YJuZnFVFzhnpD4r2wWKxVixLdbebW0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CIWITPg3; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1761905996; a=rsa-sha256; cv=none; b=EE4aojPnmTISFwGWtdAdh2v+Pr4QPD6b6djv5bGej1J9856d8n1Mz/63LgFYwgpMkMvzo+ 8vc/WmWvN0CcqudVWpIPxAqHwpEx4T+OyyZppNfvE/2d7HvHliZYAiKN0KMg3JeilyV8jd LBIyqt+Lzca8o+hMb8Hk1CoD+0Q7zWc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761905995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OUhdGI6/kAp9JoyXZrueKpHAebmQrRzAuLyMXHq++7U=; b=CIWITPg31tL1kWewY4c8mkm8Ted60gx0xRVrmVq6h3kHdzA43NERw6SD0RTfrG8H6FYwBB eHHcckWDex/DHefc3A7PsNnQG6TY0ljkllWia2nXeT5FZvHK7lEAkrfPl6NRyJlc7MjTwG ScJRQsE1m6m7altX5MO7N2/EmFi9x3c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-49-zw7_YjWGOMWOS2S-q1iFJA-1; Fri, 31 Oct 2025 06:19:54 -0400 X-MC-Unique: zw7_YjWGOMWOS2S-q1iFJA-1 X-Mimecast-MFC-AGG-ID: zw7_YjWGOMWOS2S-q1iFJA_1761905993 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-475de1afec6so9679795e9.1 for ; Fri, 31 Oct 2025 03:19:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761905993; x=1762510793; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OUhdGI6/kAp9JoyXZrueKpHAebmQrRzAuLyMXHq++7U=; b=F0fttTR6bjJSB2OlrCwv6KvsZ44Ou9d22A8nxwxjSr1eSDFaXsSGO7E2/JdRoTX6Mo Y916H19NxuGrqLzzZvuLO06s77F9A7fcC5l9CoZk37AWMQq8vOO31nMRAH++2RbkGueZ mBU8n/GETroY6PdcwaX8q/U37fYb8gzZeLOTgM7HDiNO/1Cqo46PhUrrFxesO4Gm5uOJ 6xUJLlCYG6jsg/Fk3ODWFbf2arYakMt0U62XjDdfIsvdyDHbBQCTbBOsuJuXR6E4TNZt q2QXfoUyTgihVOhhDZxb6IOzZifOYyKOdU6lk7IEth8eMhK/r/KSryzBbBmD/a2lDO30 4msQ== X-Forwarded-Encrypted: i=1; AJvYcCUqo146X0da68pL5cAUZTPOOvSZMcZxfRukoOYiZyym9g1PE/d4tuWydywNshyu29ym5E4FznIlVw==@kvack.org X-Gm-Message-State: AOJu0Yxwrmz6NM0jo2wqsF7KEqFD+sibLbnV4m2/pfuZ0/GVPyskcSsJ 3/l2r2ulL2kQGyj7tUlS6nU0Sdc8i7t8vFwXAG8KW/GDUbgcoQr8C5dbFcBEv2ml/qSdsdJtI2+ +MF2F/kEk6OxdWuX1dxe+d86tVgIN2TYZV3ljoNRVMliivWV98VSr X-Gm-Gg: ASbGncv7K6SFCinFwZ53W10ufKXnHURnT+bRwU8Husr+KmEe1UGS6W0qRWp77DzN9YS 8HxtzPZfcW3EDKtR27XR221MIQQ9C5XKTci2eLQ/qDhaDv0R66Mt7OMflY06s7yfPQxroGpGZhO 9V2ab+GLbJK8l53FF2nzJgJhtZ8hKB8+gFxZpUx6e+g1aLS+pz88LWolkT8WdVfZFCgl/nLuZXZ GIjIpaH1g4Kjcjruq8yFObYtRsQ3r609ZRFWA0w+V5W+PnH4jDyisJ/B8wFyGzWXpFRAV9VEEPh w7Jxu7RUuBttnbAHp2mpWGmAyfb7Um0Gk1i733ZSnMEwRPfxz2OVCLx0eUgpcSP/ryxGJ1Wr7dM FCaWsbQNrwtNB+PiOqPBmF9yqA4Np3J2tOouZqcdypixdNvPwboT8jZ+tcR3KoCTFGZqsIrSHpX Ox8ePmKsC522fs4AmdM74k4drPPaA= X-Received: by 2002:a5d:5d85:0:b0:426:dac0:8ee8 with SMTP id ffacd0b85a97d-429bcd05203mr2998215f8f.10.1761905993323; Fri, 31 Oct 2025 03:19:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH8jpSFh3hhPp3PzJX0f48uDqqqBw7iyd7GjZkB/l1xZ2kBNbllkQmlUEXSQLnQvjsz9LvTiQ== X-Received: by 2002:a5d:5d85:0:b0:426:dac0:8ee8 with SMTP id ffacd0b85a97d-429bcd05203mr2998195f8f.10.1761905992898; Fri, 31 Oct 2025 03:19:52 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3f:4b00:ee13:8c22:5cc5:d169? (p200300d82f3f4b00ee138c225cc5d169.dip0.t-ipconnect.de. [2003:d8:2f3f:4b00:ee13:8c22:5cc5:d169]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c13e0311sm2647741f8f.30.2025.10.31.03.19.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Oct 2025 03:19:52 -0700 (PDT) Message-ID: <38f0ff98-3dcd-4dc2-87f1-3ea34bb9935a@redhat.com> Date: Fri, 31 Oct 2025 11:19:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/secretmem: fix use-after-free race in fault handler To: Mike Rapoport , Lance Yang Cc: akpm@linux-foundation.org, big-sleep-vuln-reports@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, willy@infradead.org, stable@vger.kernel.org References: <20251031091818.66843-1-lance.yang@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ufA8OQsv2Q5gwLcEpKRgvSshJ4b0PKRcTBb6n3dhA18_1761905993 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: fgjsjaj7raio61sbxxa9a3otiz5qu9qt X-Rspamd-Queue-Id: 89BC340002 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1761905996-544415 X-HE-Meta: U2FsdGVkX1/q1qzdHK6JENXlqTuuyDD3QGT3tn+TALkfMy62XtSwLH71e5XL8QLkItmjtEusd95zuQCQ6cOMHU3mLXzDLZQykOM+2sOXBwhOx+C4yRDrX4aEW4PTE9Wa91YG4dtYrvGv1JaLvOJ3iIql0oiKxb3oqcqL3/+bfHxcF4FgS4mscVx2fgl3X3q1bovDlIjJxFlkjQQiLkH6VulxDpa70NJP6D0CShM35G/50UCfMfWKNRpXzWqtgjnxTQ5OVRu31NK8kdFpLDEComes2t5ipwLbqsMrsU5sSb14L1p855qHsnNJ/hez4ogC7mncuPhjyCW1A/yOWn4+NCBJS352W4zMdidcegLK/K02dPxItl1HPE5rNJR8d3MgWXFhvOqOIuwYE4ZXNhEWfAqeoPNt5dnigHhQgOnEldaVgbSNB24pg53jHJXIXKMVen5DV0UXuRXPDZwhsrKY5MLQj2UqSPhQyiRknYgfHxLgUHnKA5fxjjnlUlYRfKM8y0LZdcq0rGQzhbC2iGg267J0NAipqfxboU546FZh5RGUNC16O+S1fIrpEgWQPh1WrH7TPtF29MHlvtio/ZsLcNfw/ns0cbttgqf70KTNGSlhOL3xSXcZdg8xATI31XQHRru8wa9lVEVBoYsThuevRt9hckL5ZKVMy0nEkDkgZ1Gu3fltVWLg8uSYJ2VdY3WKUt0NQw2KAyb8Xem2UyiC10obKFz623IoOySALTZTuWRcY6+aL6hSzwcusKu8zLWSIa6ZTebqhmHuacRXkevEonPvOKUx5PhHdN1QFrzfhWzwz1I8/9cXNGkLdOGO6S5PNH01zwgngQqazU2qlHWgN9FQyy/N//wPX2SV/fEje4QRlSIvS76y1iT2zFZQULosaRibwIvtkbdaJ06Jrm26G3G7FAWyRq8N48nmiWUwaUYhL/Ly6Yv+pNJj3pPQWvlp3uJ/+70HP2yBH32O3UY J6QJrElq Ld9l585dHbvEmhPnTJjlOozFinbVHh37j7xEIbJoJ0QRjAp9SC1JJ5N+nVKHoTB3htbizLttMCdHzj1BfOJU16LDkmTuQnGaNsjX8AtNnQn3ykHAIWa7FoPNzt8IqOnV/gp04iwlQSyQ0MQUCLWEa9itTZS1j3viob4U+d/n38BikalxrFkaP/eXhWFOsWRfs5/WPJiYCCJsrj7arIoeNIF6XVrALqYfRuvRKMPtu26pEHgUgsIJqA5RTarKcs0ni/TNamkMIBd7QZccEtJm59YLUIGN40gRCky4/WwSexlKYtGIkhwwDiBRzhdjETRecih6AdvHO76jyicuGjB3NI7uuzUTBIHxSj86b5TUTucrcAS13dI73s7ajI4efMdYTT8O75AShL/iWY2fVfQzwfhy4mQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.10.25 10:59, Mike Rapoport wrote: > On Fri, Oct 31, 2025 at 05:18:18PM +0800, Lance Yang wrote: >> From: Lance Yang >> >> The error path in secretmem_fault() frees a folio before restoring its >> direct map status, which is a race leading to a panic. > > Let's use the issue description from the report: > > When a page fault occurs in a secret memory file created with > `memfd_secret(2)`, the kernel will allocate a new folio for it, mark > the underlying page as not-present in the direct map, and add it to > the file mapping. > > If two tasks cause a fault in the same page concurrently, both could > end up allocating a folio and removing the page from the direct map, > but only one would succeed in adding the folio to the file > mapping. The task that failed undoes the effects of its attempt by (a) > freeing the folio again and (b) putting the page back into the direct > map. However, by doing these two operations in this order, the page > becomes available to the allocator again before it is placed back in > the direct mapping. > > If another task attempts to allocate the page between (a) and (b), and > the kernel tries to access it via the direct map, it would result in a > supervisor not-present page fault. > >> Fix the ordering to restore the map before the folio is freed. > > ... restore the direct map > > With these changes > > Reviewed-by: Mike Rapoport (Microsoft) Fully agreed Acked-by: David Hildenbrand -- Cheers David / dhildenb