From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60647CD11C2 for ; Fri, 5 Apr 2024 09:04:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 657AA6B0122; Fri, 5 Apr 2024 05:04:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 607AC6B0123; Fri, 5 Apr 2024 05:04:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 482C06B0124; Fri, 5 Apr 2024 05:04:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2998F6B0122 for ; Fri, 5 Apr 2024 05:04:19 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 90466C1101 for ; Fri, 5 Apr 2024 09:04:18 +0000 (UTC) X-FDA: 81974891796.23.006F5B8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 3B0C2C000B for ; Fri, 5 Apr 2024 09:04:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U9vP0mfb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712307856; a=rsa-sha256; cv=none; b=inv63b++KH7JCzvXHEHHV3goJp/HFxwuvtHFKowjDNRI3RXPwPQyD0jtz6kkqURUYSLx/u H+wLyYv2C3gI125uXC3IiwJiSZr8YJ1sCdrRyE8rNGYPgSCD2fj/KOl5oGFl+DlJYhKOta wgQl+k0r5UiNwoKKXLpc0X2XyfJ3E2c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U9vP0mfb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712307856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CJdNEyzAoJZANtxLIIs8AdbIcTf6acDNmbCaEO4rNGI=; b=q7NHlQSYo4zOn5JkGIxJdACqhMZzrwAVFuPojuYsmOuzVRr3f0wDHO3XLx0iywLAGJ2XFx HO2VKcaoHwJPg9Zg6edyjUFoATSw8Q/VdyB3LBcBxPvFvGGl/XpPvQUfkNaCO1zN1xcUE+ Vk5hWoOdTjE/P3cu/4SidsTul4jn6WY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712307855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CJdNEyzAoJZANtxLIIs8AdbIcTf6acDNmbCaEO4rNGI=; b=U9vP0mfbVXaB7nzb72hQQmQl9l1yEVN9qDGa3R+li8NSDFzDfT4stMyz6ublU7UXcNsPGQ oApdszsT4TwWOKlctMJ10s4Aj3Y1QI+IUYKCJ0H8X/wHY0mBQCtfUyWZLxqNYaoa7zLgxq pdtYHNykR/dUNWAKEO9DNbk23uBa9I4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-ke0gbw0PPgOi0SKvvLUQ5w-1; Fri, 05 Apr 2024 05:04:05 -0400 X-MC-Unique: ke0gbw0PPgOi0SKvvLUQ5w-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-343f08542f8so115142f8f.0 for ; Fri, 05 Apr 2024 02:04:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712307842; x=1712912642; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CJdNEyzAoJZANtxLIIs8AdbIcTf6acDNmbCaEO4rNGI=; b=MEw0AnNIOAI179/4+2mGZm13QLSM74taR9Q+oPsvzlolKcaOIAjfvi37OQN60j95Ag dFMC0dtiTWMjRS790KKsk1QcJ1nyYXOksQ118Kb5yApnKd0OqLN7r7be+Z8h3N2akKsf qPtOh3nO32NwNZvj+XLnCtall0pWaMuX97nAoumjby+rPZPC078W/Lpe8AWOuQloZyfB ijUD46yChxwbLbsQ2CaYKERgLIJ9xy8DN0UGm23Xc0QnMlZY8MPIwvN2bFbZs1IwJe73 fgg682fkqzCRyaSmmf4Z1fT3zDN6T+pijpnZvTarCckOjuFFxGV4lhC+1RXzUDE0L+VP f4CA== X-Forwarded-Encrypted: i=1; AJvYcCXjx71uRzyn+q5hQ/G4GsjZ+C0WeW7MCr+P9y2U4DxiWiuaK7PI1uTBnDjz/pv/q1/0zXlDNr7+79MuJ1pRLlLZAQ0= X-Gm-Message-State: AOJu0Yz9PWpP2d+VhY3e/Lf4QCNzj6GgHsyx+g4sRsQ4d2aV2ri4sGDT 1EFzp1wFew/JfEqCEBnLyIWjFgI9FDXHl3j68TQmGm5fQsUxPzr0fwm7k4JWkoVVWG4KsRfZQ2d LXUjVFRyTF/Mgu06bUCzxAXkUcekluZqzumCnXR3SFE3Ao0Ro X-Received: by 2002:a5d:6d88:0:b0:343:e3df:6c6a with SMTP id l8-20020a5d6d88000000b00343e3df6c6amr646423wrs.29.1712307842569; Fri, 05 Apr 2024 02:04:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGiau2chpJIYE/Xi9/WDZq6choKxfW94Ntzxm0MqiD/id0cj0qByySZf0SLXQJQJJNjm8X0/g== X-Received: by 2002:a5d:6d88:0:b0:343:e3df:6c6a with SMTP id l8-20020a5d6d88000000b00343e3df6c6amr646402wrs.29.1712307842029; Fri, 05 Apr 2024 02:04:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1? (p200300cbc74b5500e1f8a3108fa34ec1.dip0.t-ipconnect.de. [2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1]) by smtp.gmail.com with ESMTPSA id p12-20020a5d638c000000b003432ffc3aeasm1512792wru.56.2024.04.05.02.04.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 02:04:01 -0700 (PDT) Message-ID: <38eee542-8567-4c42-ad63-778b4a20c153@redhat.com> Date: Fri, 5 Apr 2024 11:04:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: add per-order mTHP alloc_success and alloc_fail counters To: Ryan Roberts , Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, cerasuolodomenico@gmail.com, chrisl@kernel.org, kasong@tencent.com, peterx@redhat.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com References: <20240403035502.71356-1-21cnbao@gmail.com> <30392471-71f9-4eb1-8855-d9c12499346f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3B0C2C000B X-Stat-Signature: m4r8r5yxbyq9umbjfpgi1yzm1ycspqpa X-HE-Tag: 1712307856-349377 X-HE-Meta: U2FsdGVkX19QxSAy8P9XbGSGeLCoY2ZZgLdrxMyANAniTwMrH1OjcWl4OEM/5ZUnUd5GS9e17EVId/C+EAxQ4Ib/Ul4safDdIT2FRh0FovRboKhEy6JxsGNZcCZNhg/ja5dj9zasU5abfd9zmRo6iDCbR/gPAC4E2/4PzJ5yYWUmqMPOsgdcrMp4kCkgp5MWjH5ya/Av6i5psx6NpsuL6FqHAfGX9hDFGxrIkR5IzcWIIRY6FSz4/6CPvNd7q240Q99WWwGoZjLk11OdoOBrAnvyJGoqgxuckgyOIPqblpg/2HKi3J9g4WVbx8oJdL7G14iOPhq0ze6UXnh+VkSe2v09QEQKZ25RSC+Tprn5yBC3yOqI7KKRc91/7GO/+bEDh6tWWFVE2300mhfRbZ3KCUjON0uOVkFywzoyeo+/LAizXu91ukxR3Y/JY/8ELZ0sXrVAX6KDG89Y+8GTXFz3zmjjRoRRLNYi4SYf6UEfRtJaQ+jlLx5SQjcM0Kdi1WSZR2r/hbjb0Vr7BNtJpOdavxv0JZDPDczo032ceifFhp5LGG03zMOWQYGtXPlzJZ7Gr8d1i6j7RE2hK1B1fPFkh0yrjboTWyDuUCqYmSU5wAnVpi15mo4fwbBiMyYANMOE8vcbFWZ7d7GdypB3KQtMthKHPJJFkxa+YypVtJsdc6w3Dl6CvoZ5uhwNQSRSm6QrnwBW+nj7SpfTxhAlEVZVC135aOoSA5HMTsZ2rHYzVn6tLXfANMWf1JetM82XqXFnDJaUL4lBADQhxB00NYcGMWuVT5/QweLDTQJwnZuh1+423yW5W2khtbtCa3/SEmHXWYd+UbZNAu8SmjYfi95WFUF22zk51KbDqZP8ySBwxBvj3IJYLonnbp4CVU9zZHvUYWhTup6wpB5ALmsDurWPULAZrn10O0AWZXtP1fZJfrfNSfov9XOR5BPRTRpcG1ZvcYmzmV2rUflBm3TOyVW n/fJtrsf OUlSwP9XG/jef/P+ZfPZ9lLkglqkRq7Zyeg6btsFTuswFS+uusmwXPZDYJTTP+v7A3edqdHpdhoyqDn+igqTh5vEQyvoy8jtUq+++H8TRKnrn98562KL9D6xKzXE4MOJ0XPxmqJIQtdtJqOiS6PgSMNGpYLYZyCSskM9hBM0g1tYqE6HWtKLDnpULdh5O1b7hq51LH5J2DjLqV22G2MQHeDZU7xKxtazW4fFmrZOA9YFdsV9e7QJ6MKHuI7jV6ABXPQKozs540asPfQDiJqPTtT6ZpKU3qZHYvoHPS+ELI6dRT8SeKXrYWzsxulqGVSxSFkj+PDxgewQ3o5ksRe4JjycNitL19/XpUTo2upvqUZcro1gLJQzEgVp94tZQSfmECBSPvJY0/nmba5DaGs4GA7K1N7LC0dKT7v1uDXtSPv6GlFQIUzIrBZw8XDMZKj9NJIERrnX8l90L/+qrnVj8tiEFQjHAyaB3lXovmS1uIIsyaYfO4mOEn5aZprAzo26Vtwh4z0QjW+hbquq+3nqsl/51Iufro8nGHTc1P2kz2DKyMHytwWa3rOiNXnKIcsPcVn5vm/ek5s2cfxjuittrXwJe1m/tK4I5RzfEZOP3QE/q8br5nqfQbozNRbia7JPfR1vVMY6/qYUA8HVvhQyYLAWx8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.04.24 09:21, Ryan Roberts wrote: > On 05/04/2024 07:29, David Hildenbrand wrote: >> On 05.04.24 06:01, Barry Song wrote: >>> On Fri, Apr 5, 2024 at 3:57 PM Barry Song <21cnbao@gmail.com> wrote: >>>> >>>> On Fri, Apr 5, 2024 at 4:31 AM David Hildenbrand wrote: >>>>> >>>>> On 04.04.24 09:21, Ryan Roberts wrote: >>>>>> On 03/04/2024 22:00, Barry Song wrote: >>>>>>> On Thu, Apr 4, 2024 at 12:48 AM Ryan Roberts wrote: >>>>>>>> >>>>>>>> On 03/04/2024 09:22, David Hildenbrand wrote: >>>>>>>>> On 03.04.24 05:55, Barry Song wrote: >>>>>>>>>> From: Barry Song >>>>>>>>>> >>>>>>>>>> Profiling a system blindly with mTHP has become challenging due >>>>>>>>>> to the lack of visibility into its operations. Presenting the >>>>>>>>>> success rate of mTHP allocations appears to be pressing need. >>>>>>>>>> >>>>>>>>>> Recently, I've been experiencing significant difficulty debugging >>>>>>>>>> performance improvements and regressions without these figures. >>>>>>>>>> It's crucial for us to understand the true effectiveness of >>>>>>>>>> mTHP in real-world scenarios, especially in systems with >>>>>>>>>> fragmented memory. >>>>>>>>>> >>>>>>>>>> This patch sets up the framework for per-order mTHP counters, >>>>>>>>>> starting with the introduction of anon_alloc_success and >>>>>>>>>> anon_alloc_fail counters.  Incorporating additional counters >>>>>>>>>> should now be straightforward as well. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Barry Song >>>>>>>>>> --- >>>>>>>>>>     -v3: >>>>>>>>>>     * save some memory as order-0 and order-1 can't be THP, Ryan; >>>>>>>>>>     * rename to anon_alloc as right now we only support anon to address >>>>>>>>>>       David's comment; >>>>>>>>>>     * drop a redundant "else", Ryan >>>>>>>>>> >>>>>>>>>>     include/linux/huge_mm.h | 18 ++++++++++++++ >>>>>>>>>>     mm/huge_memory.c        | 54 +++++++++++++++++++++++++++++++++++++++++ >>>>>>>>>>     mm/memory.c             |  2 ++ >>>>>>>>>>     3 files changed, 74 insertions(+) >>>>>>>>>> >>>>>>>>>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>>>>>>>>> index e896ca4760f6..5e9af6be9537 100644 >>>>>>>>>> --- a/include/linux/huge_mm.h >>>>>>>>>> +++ b/include/linux/huge_mm.h >>>>>>>>>> @@ -70,6 +70,7 @@ extern struct kobj_attribute shmem_enabled_attr; >>>>>>>>>>      * (which is a limitation of the THP implementation). >>>>>>>>>>      */ >>>>>>>>>>     #define THP_ORDERS_ALL_ANON    ((BIT(PMD_ORDER + 1) - 1) & ~(BIT(0) >>>>>>>>>> | BIT(1))) >>>>>>>>>> +#define THP_MIN_ORDER        2 >>>>>>>>>>       /* >>>>>>>>>>      * Mask of all large folio orders supported for file THP. >>>>>>>>>> @@ -264,6 +265,23 @@ unsigned long thp_vma_allowable_orders(struct >>>>>>>>>> vm_area_struct *vma, >>>>>>>>>>                           enforce_sysfs, orders); >>>>>>>>>>     } >>>>>>>>>>     +enum thp_event_item { >>>>>>>>>> +    THP_ANON_ALLOC_SUCCESS, >>>>>>>>>> +    THP_ANON_ALLOC_FAIL, >>>>>>>>>> +    NR_THP_EVENT_ITEMS >>>>>>>>>> +}; >>>>>>>>> >>>>>>>>> Maybe use a prefix that resembles matches the enum name and is "obviously" >>>>>>>>> different to the ones in vm_event_item.h, like >>>>>>>>> >>>>>>>>> enum thp_event { >>>>>>>>>       THP_EVENT_ANON_ALLOC_SUCCESS, >>>>>>>>>       THP_EVENT_ANON_ALLOC_FAIL, >>>>>>>>>       __THP_EVENT_COUNT, >>>>>>>>> }; >>>>>>>> >>>>>>>> FWIW, I'd personally replace "event" with "stat". For me "event" only ever >>>>>>>> increments, but "stat" can increment and decrement. An event is a type of >>>>>>>> stat. >>>>>>>> >>>>>>>> You are only adding events for now, but we have identified a need for >>>>>>>> inc/dec >>>>>>>> stats that will be added in future. >>>>>>> >>>>>>> What about the below? >>>>>>> >>>>>>> enum thp_stat { >>>> >>>> It seems we still need to use enum thp_stat_item rather than thp_stat. >>>> This follows >>>> enum zone_stat_item >>>> enum numa_stat_item >>>> enum node_stat_item >> >> >> Right, we can do that. >> >> [...] >> >>>> ok. >>> >>> Hi David, Ryan, >>> >>> I've named everything as follows. Please let me know if you have any further >>> suggestions before I send the updated version :-) >>> >>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>> index e896ca4760f6..cc13fa14aa32 100644 >>> --- a/include/linux/huge_mm.h >>> +++ b/include/linux/huge_mm.h >>> @@ -264,6 +264,23 @@ unsigned long thp_vma_allowable_orders(struct >>> vm_area_struct *vma, >>>                                            enforce_sysfs, orders); >>>   } >>> >>> +enum thp_stat_item { >>> +       THP_STAT_ANON_ALLOC, >>> +       THP_STAT_ANON_ALLOC_FALLBACK, >>> +       __THP_STAT_COUNT >>> +}; >>> + >> >> >> Final bikeshedding: so we want to call all of that MTHP_, mthp_ etc, to make it >> clearer that this is per mTHP size? > > Perviously we concluded that mTHP was only for commit logs, and in the longer > term we wanted THP to mean the full set of sizes like it does for hugetlb. > Neither "mTHP" nor "multi-size THP" currently exist in the code base. True, but some indication that these are "per THP size" might be reasonable. -- Cheers, David / dhildenb