From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C911CEB64DC for ; Fri, 21 Jul 2023 06:23:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CE64280199; Fri, 21 Jul 2023 02:23:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07F99280190; Fri, 21 Jul 2023 02:23:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E880D280199; Fri, 21 Jul 2023 02:23:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D7686280190 for ; Fri, 21 Jul 2023 02:23:23 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 99E46140176 for ; Fri, 21 Jul 2023 06:23:23 +0000 (UTC) X-FDA: 81034627086.10.DB3E3D4 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf18.hostedemail.com (Postfix) with ESMTP id D90BF1C000E for ; Fri, 21 Jul 2023 06:23:21 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=tJ1jQMnP; spf=pass (imf18.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689920601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=CMM2Xz7iszNlfybnGDsCEu6Ft2cukp2NOoySqKmrqR8=; b=45lStV5K/I6VpMQb/0Pt7qW4zm2oGN2HC40a8lKTWIG6QgpQNdU21WnaXoOHaw/ZgcbFqu OdwrFVlhbQyifiWQgWrEIy4OFach0JB6T8J2o1/HbRzn2wYzvo7DtnAEFCwPRiN3J6m+4n 7XY9gQpnZHJLFBKKVCr3G/cjKpBme+4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689920602; a=rsa-sha256; cv=none; b=ZzPUJ1OwgiXhcF3s9ZJ1YfV1dm/jenUlJsu9yRbzGm8ICZ53mDrdoiFHmO1/OmvRRHGou6 li0u8qBLIHVka3L1sFeyZ897Ifo9MilcqZr9j8Uto6U6LcHIJn1LuN25b79iJRyXPJBeNC 7n4bDx90+T+kTc4j3icAq7TY3KX/jLE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=tJ1jQMnP; spf=pass (imf18.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-3fbfa811667so16513355e9.1 for ; Thu, 20 Jul 2023 23:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689920600; x=1690525400; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=CMM2Xz7iszNlfybnGDsCEu6Ft2cukp2NOoySqKmrqR8=; b=tJ1jQMnPdKTdHLq3tc1HQnuuYLEHWHXMDC4e7vJhCqoVaVUJqLNcEoU/KRIhWO/bYx YdPywBA1IPbPrkFa8NrvXsv+eD/t2foyQnX0VRV5Jw4NrQ7m2FHnTkjeIwgc0RJIlc0Y imVjGy8+D5xxnsCvfwhmC4+6Dmw6MUHaLQ/Gd5b+NQ8jelpDBErzxYvVhmdo9nG8DhVv /9qWaDcaZ6MmHsARhMBAARFeOuKM1g5ay47Lt2SF+lTnnzAH70Tb/xntH7tc2I6sEebv LWN+gSOGmx/KIVeLoozuS/ChJSxT2xR4fy3WOEJmjgu+qiNgYId72F3YMFB3NG9ejebY OSUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689920600; x=1690525400; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CMM2Xz7iszNlfybnGDsCEu6Ft2cukp2NOoySqKmrqR8=; b=WpFXBapWih6TLou9TsmpMIIvjfaS2CCTmB+ob8flaToNDDp6zeuEAYIqL33m7iY8yp bNUr9cfURbmiYb2c1XYe9ybi6UgiWccsO5giIYLc/E2d7PywmFbRjEvC2NOrdj5AP82N xYkoO9zklUJzQHvq+OH2m2eSAcN3Ql6/2FT2+9MDVFoZnemCBSIQvwxhunNEQGyfqZgV G9cQ3y6OdAh0vLLb9DFYMcH4//ZZVnfkWyAhP+nxYb60zf1X6+92DhRA++61USQDYj4e Fy3oCnkwJV9Rw8WcZyvxhqIj2uU2FF6mgj6Ly6vbhiT7oxD4YfFBo1iDjT1nBv5zHcTs RM1g== X-Gm-Message-State: ABy/qLaE61Ja1OixVbwZzvHngQy4/tWwhMfyJhPE3qgK0oDPZNkoc0ua n2aQzR0mRc2Kl6kBrS3b39Zsrw== X-Google-Smtp-Source: APBJJlHK9rMkKbet9xx6IhhFPgmsgH0l7Q7T68Zrxeo292wyOGGMmauek+7B24Hn4WRH0OUVwfyngA== X-Received: by 2002:adf:f641:0:b0:315:acbc:cab6 with SMTP id x1-20020adff641000000b00315acbccab6mr849900wrp.16.1689920600174; Thu, 20 Jul 2023 23:23:20 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id t10-20020a5d690a000000b00316fc844be7sm3232332wru.36.2023.07.20.23.23.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 23:23:17 -0700 (PDT) Date: Fri, 21 Jul 2023 09:23:12 +0300 From: Dan Carpenter To: apopple@nvidia.com Cc: linux-mm@kvack.org Subject: [bug report] mmu_notifiers: rename invalidate_range notifier Message-ID: <38ed0627-1283-4da2-827a-e90484d7bd7d@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: oijqdmk85hn5ibsg8n3ym5fg8s4foirp X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D90BF1C000E X-Rspam-User: X-HE-Tag: 1689920601-325154 X-HE-Meta: U2FsdGVkX19G//jA1hBZnVprzZH2/88iV6oCbBMawXphUmG6YxjTCBPGLcE41xOi6NzsFuFccqkR5y0/K9ID2UHgWRCfjZDTlcKv7ws4W2/youjgm4cGayisHixeFlaff75YI8/IwJtfm/gN3HaAoxEl2Z7wb3TnojheHYQ4YkAlb/D4vM90tvRkiASuxD8A1djgEuu3CG6GUK0MtrlrIXq/CjaMJmG5zZZxRGi94k/MLXkDBmqtbj+auEnZ0HyG6emPEf7Ts7JL+xWKEpqcyyDqM2svvsByhZrlxYbvBQqnRGvIZewM2asklIznxZS6df1y37mNazEKq34XAzjzZM7eAezRRcX37qdZN5xZZ15nlAugbplzHJGE7EAuoG7xfuPaCWCQ0fJBC2KwZVXPGj4Bcs9d6p6q61Cic9iuq6x1lf/VG5HgxFOwnnBjavY8J3egM0+R7IucHVFgaTv1uwG1B4JBjYDtmlHqODxjovoqYstZ0HIaxdJvxVJ2P+E7gD3XsVhqdRo18ld2kXvDiKnLCl9EeLvTaOUmYJ6UAP8bM8e02Tsl++FGK7nP3t++9HQ2XoZkQjjSnY8PYclocYMVq1k2gOHO4/m2fBKMe03nWgu3spjy6OPy+tJNLMS3a6dgv3lkNl8gSY2WeR4Dkgn0YhCoCOpxcnsym77y/86i8zKAf/7IUX6tRjX2DovCisFW0a8mJf1KBrJpdjr3d4PqTAR2/SFJWDaFkp9Vupy1aTNVsw0OqLf/i7RW6/V69Ep4O+/dkiyXkHQ/aOfSbkuwrIPhaRkGfuS9+6x3UyAA4kkZOdJijraXqw6lFIySw0Jkg8jAoB/96jpk2lZFfrK8l6fCcV81mw+/lBTa0RTPGnbqPGixPojkZ6Yvmj/8MUdatx2xKxGpG1la7+RboB54ZItMR6SgADOLeDizxuQUyF45U45erzKABlH6fVOQOhwMOLwY5PrRLdukL+T RDaXgbLv +UM0Wv+VRW24zvQKUtoHP+KOl4ToRPyuv5LRSMxO2PYF8Oi10ixVNs59v5hI7p+0jKAbY06AjIRoRmWwG0lP4uRhzuTbdz7kE+UXh6zmA+/8w0SKSObo2iP7Wi+YCxqn4TYMGLnfBJ6T2YZ+k4AVNkf6eEkx1ZiX6Cd2LCHj5+b26+y3gPoll9xoWe7wdcWqwd+Fixr878IDAFgYqzxIe4xgEyBJggOywSSeFpGo1g8R1IMlkMXQn1wthzhjXmT/3DNE89jv69tEdSiX8NqgJxYi8XNZqRsz6CMfGs0fYY3l1wI2iBuoAEXiRpe5VrQBY2DFpi2ifv51dZAHKIc0mQPwdQUHTOXRA9Nvh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000063, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Alistair Popple, The patch 828fe4085cae: "mmu_notifiers: rename invalidate_range notifier" from Jul 19, 2023 (linux-next), leads to the following Smatch static checker warning: mm/mmu_notifier.c:1020 mmu_interval_notifier_insert_locked() error: NULL dereference inside function __mmu_notifier_register() mm/mmu_notifier.c:671 __mmu_notifier_register() warn: variable dereferenced before check 'subscription' (see line 624) mm/mmu_notifier.c 1010 unsigned long start, unsigned long length, 1011 const struct mmu_interval_notifier_ops *ops) 1012 { 1013 struct mmu_notifier_subscriptions *subscriptions = 1014 mm->notifier_subscriptions; 1015 int ret; 1016 1017 mmap_assert_write_locked(mm); 1018 1019 if (!subscriptions || !subscriptions->has_itree) { --> 1020 ret = __mmu_notifier_register(NULL, mm); subscription is NULL here 1021 if (ret) 1022 return ret; 1023 subscriptions = mm->notifier_subscriptions; 1024 } 1025 return __mmu_interval_notifier_insert(interval_sub, mm, subscriptions, 1026 start, length, ops); 1027 } regards, dan carpenter