From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54609EB64D8 for ; Thu, 15 Jun 2023 01:50:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 741E76B0072; Wed, 14 Jun 2023 21:50:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F25C6B0074; Wed, 14 Jun 2023 21:50:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B93C6B0078; Wed, 14 Jun 2023 21:50:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4B4F16B0072 for ; Wed, 14 Jun 2023 21:50:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0C3D1140883 for ; Thu, 15 Jun 2023 01:50:01 +0000 (UTC) X-FDA: 80903301402.30.6FF9E42 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 3DC8714000C for ; Thu, 15 Jun 2023 01:49:58 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TrlgT4GO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686793798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2uiIRiOQ0DTIHN7hqkYOKeXZW/KwneQWIcgJ01GitdA=; b=xU1dzuBk75Q4yvCpoAlMelOH72CuOgClvP8xmRKblFQ79gZyvs7z2UQdNrB2Nw6FecirNi kEjQR0ieSb0A+sWhIikhDx8A0Hie5E2LPrEmTK0FVZMQU7sYUwMB28VdymPDAoY7iuvHuO SoaHp6mj5q7A63ELkReMuiofsRgPPfg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TrlgT4GO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686793798; a=rsa-sha256; cv=none; b=zdcYWdGru3uD39TyokwlKIq7LG7Dv0h2pkNlKuJUiPOlnVlV/UBfHpvxxKAqHmMNnYZgiy ZbXLOf3gT0Cq6XwqE7t4Wa8EqwVAwMXBFN3FIQma62f/kzjmgsxmVt3l7378BWZqQ0RZdM +jnAorbXBUjsjSWRPPXetlCgXsxKoj0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4E85E601D6; Thu, 15 Jun 2023 01:49:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 122B1C433D9; Thu, 15 Jun 2023 01:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686793796; bh=13gtF2bZglg63yrcK3lxW+cPS0rix6IFq+4QbpuaVqI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TrlgT4GOuYdBNGCPlMo9ywNESPLLc7CKzgW6t5gXJMa0raksWYB5YJY5qu3FlKI78 TquE6itIMX2cKgBWrrBSp39ywmQopGttDJBsw3/F/pSTo79cOeq87JSkabZqaKIOpP HI9dBr2vEd0mlKhYY264myATYH5wZlkQ+9DKxjZdmT7yuM81F/GKVfNxWsrCsFmQ8B hmM9PZ90SeWywDztrUp16XHnMfvajCtAn7ysclVCC7WQpurGtMTEo7EVoiXsMZkTOC 5BOgQ8OZslQtHrXlk70mb93JDkKfERK7XO8zhl6H78bVJEeAxYTI9hyTZ4EwcgaOoj jMyiw6Pn4NqWQ== Message-ID: <38de9e99-593b-f852-190c-e843869694b3@kernel.org> Date: Thu, 15 Jun 2023 10:49:55 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [linux-next:master 9063/9793] drivers/ata/pata_octeon_cf.c:835:7: error: call to undeclared function 'of_property_read_reg'; ISO C99 and later do not support implicit function declarations Content-Language: en-US To: Rob Herring Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Sergey Shtylyov References: <202306141702.ZaO9V2lk-lkp@intel.com> <9be724b6-9b3c-51fd-ca20-634603a9145e@kernel.org> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3DC8714000C X-Stat-Signature: kzpafw9xb56cjsgw73i435um9rxaeide X-HE-Tag: 1686793798-351615 X-HE-Meta: U2FsdGVkX1/Ee7cBqx8s0TBg0CbXcCHnahjO/nWgB8c7PLHNOCNfwV4n9V+uQ+n8DWyL4ukIQI3hrOqLMfSRZ95d1PXunG2RD1WxltNq1SlaKASJG+pdPSpQlQnTruSM/xOIJMTX8bv8SP4Hn/ZccLIQ5fnUoLdjxEEww+hUC4dqQOla81HG6nv8fuDPvAl/v0S8AMZQ6HJXhn4yeHhaNQ9K37BNLr2A5ZLXAvrbSe/7EBodBbRc4WhiFGD0Lqc7tHaE0Wm2H3EkceHlqdlzQY+Lwhf74oj2lTtDXF6KAtFb7+hBXwG71t6yPJaNwi6J6Y1cJ9eRwCw8WoOk40NguSoJi5U2Sc3lBRwSilhtSEBLY4m+WNgeDKlq7k6+oxwoh/Flqdv2eZLZkjJ4AdhUj7fNMXQbqajpTcvGELrkyXcSkAgHFPTHGRQZrVFsflZyybcOZ+PaU2RsCq8LgD7rlKD85lUOlj1hTJJiJDF4lx09yvt7K69VCZGctkfSjr8Wj5AYWnNy1yznCQ0uLHWdKYdKS6OwrywN1RQWtd17y0MU04rhn0Zoj0L9m2soHsbLMdsvCBlaT9Zv8p6OhWQi5NnUP7hqbb6Uvzvsr68bDkgKNib6u4m1R+tI+viwlNlrvOW9gMk+CBKEBbdKiii31p5CvbtCiXxFhTCCY1k3WJB7aGZk7HSj29kZ4fQ71IORqKO7ncDOu8uBC6atGp6fgocL0t25PELwxMvV/xlyW6N/Xt/bRhnQI9vuWTvHK6KGmvpfzNAPGCNKxp5CzJUOqfBYkdor8ORWymNDCZfj8fWI9JfwlwLDKP0uO5KfXi2CDl9Mzv/TZrVNqZODb0WFfdUJ6AsqVqG0ARGPGGgkTso6rt3EeYzaStQWAjR2buoFkVjkZiQi6LyRDF515O74gWzTcYsN132PPN7JVSuT05ED5PObzVusu+iJddt4Kvjt53NtbH9gYyUBoCmrOC5 EafIY0He SzgSGXtQupkF50ms6LPq4Km5mtR3GbU7crf93Zms1I+j41kwOaHrOJ28r8ekfHuFpwIGjopE1f6e1X+oin5f+5DiY7uSmBuXcHjsDxaAWo3KDPSh8fPE4dL4uLF4V1KSLwqjDxJhbiiEkG5cHM2qW0n61AxIjF3BU9pZjNbs9NCWRGILnAHz7eGvvgfpN4yCe/ggI6RK0HREaklgw1RYiftufJIAie9YXRj1anC4HnlEVUf7M8OuoSA+Kb9/tlKDBsYuNSIMUuo4PKYLyzPKUKjjaExx2OuFizeGgRZpnL2Lw/fFOamq7keim8krkLUfoH/2ay5JjbI7NBurP5Ea5gYHolPh5aOCT4AByGWdDE5FdtCmrDnf4It9T4LWG0m2Ggph/cgM6Q0nUeFJJMmfmxVuOD5GM/TIUNXUvhLcZrLY+ul6YXjHqHu+hblTwBRt94ft4Iz1Fy07r/mGTVnNcOj7fnncx5lfzKeVLkOcG0SK4/h/wC9dtDMqetWn49LEkYmB/Dsm298aByC59LcKuPk0cGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/15/23 10:34, Rob Herring wrote: >> Something like this works for ahci_octeon: >> >> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig >> index 4572f837e504..6b115685a86e 100644 >> --- a/drivers/ata/Kconfig >> +++ b/drivers/ata/Kconfig >> @@ -239,7 +239,7 @@ config AHCI_MVEBU >> >> config AHCI_OCTEON >> tristate "Cavium Octeon Soc Serial ATA" >> - depends on SATA_AHCI_PLATFORM && MIPS && (CAVIUM_OCTEON_SOC || COMPILE_TEST) >> + depends on SATA_AHCI_PLATFORM && ((MIPS && CAVIUM_OCTEON_SOC) || >> COMPILE_TEST) >> default y >> help >> This option enables support for Cavium Octeon SoC Serial ATA. >> diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c >> index 5021ab3ede49..2e6b28bf43f4 100644 >> --- a/drivers/ata/ahci_octeon.c >> +++ b/drivers/ata/ahci_octeon.c >> @@ -15,8 +15,13 @@ >> #include >> #include >> >> +#ifdef CONFIG_MIPS >> #include >> #include >> +#else >> +#define cvmx_readq_csr(csr) (0) >> +#define cvmx_writeq_csr(csr, cfg) do { } while (0) >> +#endif > > That's kind of ugly... Yes :) > >> >> #define CVMX_SATA_UCTL_SHIM_CFG 0xE8 >> >> But it is not that simple for pata_octeon... > > I copied you on mine[1]. It doesn't build for !MIPS, but at least > doesn't depend on a specific config. Should be good enough for 0-day > to build somewhat quickly. Yes, replied to that. The patches look good to me. An Ack from the MIPS folks on patch 1 would be nice though. > > Rob > > [1] https://lore.kernel.org/all/20230614173633.2430653-2-robh@kernel.org/ -- Damien Le Moal Western Digital Research