From: Damien Le Moal <dlemoal@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Sergey Shtylyov <s.shtylyov@omp.ru>
Subject: Re: [linux-next:master 9063/9793] drivers/ata/pata_octeon_cf.c:835:7: error: call to undeclared function 'of_property_read_reg'; ISO C99 and later do not support implicit function declarations
Date: Thu, 15 Jun 2023 10:49:55 +0900 [thread overview]
Message-ID: <38de9e99-593b-f852-190c-e843869694b3@kernel.org> (raw)
In-Reply-To: <CAL_JsqL1=gPcRRmqhYK_nnxim5m4NJcYxCVO1wy-eLh0pWnwzA@mail.gmail.com>
On 6/15/23 10:34, Rob Herring wrote:
>> Something like this works for ahci_octeon:
>>
>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index 4572f837e504..6b115685a86e 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -239,7 +239,7 @@ config AHCI_MVEBU
>>
>> config AHCI_OCTEON
>> tristate "Cavium Octeon Soc Serial ATA"
>> - depends on SATA_AHCI_PLATFORM && MIPS && (CAVIUM_OCTEON_SOC || COMPILE_TEST)
>> + depends on SATA_AHCI_PLATFORM && ((MIPS && CAVIUM_OCTEON_SOC) ||
>> COMPILE_TEST)
>> default y
>> help
>> This option enables support for Cavium Octeon SoC Serial ATA.
>> diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c
>> index 5021ab3ede49..2e6b28bf43f4 100644
>> --- a/drivers/ata/ahci_octeon.c
>> +++ b/drivers/ata/ahci_octeon.c
>> @@ -15,8 +15,13 @@
>> #include <linux/platform_device.h>
>> #include <linux/of_platform.h>
>>
>> +#ifdef CONFIG_MIPS
>> #include <asm/octeon/octeon.h>
>> #include <asm/bitfield.h>
>> +#else
>> +#define cvmx_readq_csr(csr) (0)
>> +#define cvmx_writeq_csr(csr, cfg) do { } while (0)
>> +#endif
>
> That's kind of ugly...
Yes :)
>
>>
>> #define CVMX_SATA_UCTL_SHIM_CFG 0xE8
>>
>> But it is not that simple for pata_octeon...
>
> I copied you on mine[1]. It doesn't build for !MIPS, but at least
> doesn't depend on a specific config. Should be good enough for 0-day
> to build somewhat quickly.
Yes, replied to that. The patches look good to me. An Ack from the MIPS folks on
patch 1 would be nice though.
>
> Rob
>
> [1] https://lore.kernel.org/all/20230614173633.2430653-2-robh@kernel.org/
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2023-06-15 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 9:23 kernel test robot
2023-06-14 9:41 ` Damien Le Moal
2023-06-14 15:26 ` Rob Herring
2023-06-15 0:41 ` Damien Le Moal
2023-06-15 1:34 ` Rob Herring
2023-06-15 1:49 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38de9e99-593b-f852-190c-e843869694b3@kernel.org \
--to=dlemoal@kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh@kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox