Re: [PATCH] selftest: memcg: Skp memcg_sock test if address family not supported

Waiman Long
2026-03-10T14:09:21Z

On 3/9/26 8:04 PM, Waiman Long wrote:
> On 3/9/26 2:07 PM, Michal Koutný wrote:
>> On Mon, Mar 09, 2026 at 12:02:05PM -0400, Waiman Long
>> <longman@redhat.com> wrote:
>>> On systems where IPv6 isn't enabled or not configured to support
>>> SOCK_STREAM, the test_memcg_sock test always fails.
>> I think IPv6 is not substantial for the check...
> I mentioned it because the current code is using AF_INET6 family.
>>
>>> The purpose of the test_memcg_sock test is to verify that
>>> memory.stat.sock and memory.current values are close.
>> ... so this should work with IPv4 too.
> Probably, I will try that out.

On my test system, creating a socket with IPv4 does work. However, with
IPv4, the memcg_sock test becomes unstable and it fails half of the
times as the memory values aren't close enough. It is possible that the
assumption that memory values should be close aren't quite true with
IPv4. As I am not familiar with the networking code at all, I will let
others who have more experience with the networking side to try that out.

Cheers,
Longman