From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by kanga.kvack.org (Postfix) with ESMTP id 5D0696B5206 for ; Thu, 29 Nov 2018 05:12:17 -0500 (EST) Received: by mail-qk1-f199.google.com with SMTP id k66so1292759qkf.1 for ; Thu, 29 Nov 2018 02:12:17 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id n64si1018059qtd.105.2018.11.29.02.12.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 02:12:16 -0800 (PST) Subject: Re: [PATCH 2/2] fs: Don't open-code lru_to_page References: <20181129075301.29087-1-nborisov@suse.com> <20181129075301.29087-2-nborisov@suse.com> <20181129081826.GO6923@dhcp22.suse.cz> From: David Hildenbrand Message-ID: <38bdc5f7-63b5-7276-921f-258ee876c45b@redhat.com> Date: Thu, 29 Nov 2018 11:12:07 +0100 MIME-Version: 1.0 In-Reply-To: <20181129081826.GO6923@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , Nikolay Borisov Cc: linux-kernel@vger.kernel.org, David Howells , Chris Mason , Josef Bacik , David Sterba , "Yan, Zheng" , Sage Weil , Ilya Dryomov , Steve French , Theodore Ts'o , Andreas Dilger , Mark Fasheh , Joel Becker , Mike Marshall , Martin Brandenburg , Andrew Morton , Mike Rapoport , Matthew Wilcox , Randy Dunlap , YueHaibing , Shakeel Butt , Dan Williams , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-mm@kvack.org On 29.11.18 09:18, Michal Hocko wrote: > On Thu 29-11-18 09:52:57, Nikolay Borisov wrote: >> There are a bunch of filesystems which essentially open-code lru_to_page >> helper. Change them to using the helper. No functional changes. > > I would just squash the two into a single patch. It makes the first one > more obvious. Or is there any reason to have them separate? > >> Signed-off-by: Nikolay Borisov > > Acked-by: Michal Hocko mm_inline.h is 99.9% about lru and there is barely anything about lru in mm.h. However this simple macro seems to differ from the other inlined functions. So to the squashed patch Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb