From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C45FCD128A for ; Tue, 9 Apr 2024 15:15:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC2446B0089; Tue, 9 Apr 2024 11:15:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A71D56B008C; Tue, 9 Apr 2024 11:15:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C3C36B0092; Tue, 9 Apr 2024 11:15:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6E1F46B0089 for ; Tue, 9 Apr 2024 11:15:22 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 21E4A1603D5 for ; Tue, 9 Apr 2024 15:15:22 +0000 (UTC) X-FDA: 81990342084.09.91699B7 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf29.hostedemail.com (Postfix) with ESMTP id A3537120005 for ; Tue, 9 Apr 2024 15:15:18 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=CSGCqORl; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=pyIB7Qxg; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf29.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712675718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JJx8rFJgOhLX915dXnECffN0CjFOZa3A5vbMGZf2LdU=; b=zhgvshxaAZlPw6tP2RfyXgOuxQKdaL+GlG9tFcS8JjE7jnH4nQZha8+1y5IUrRUNOscsom 0vzg1wYR5fb2ntP1/OOj+A/r/twLOeMKy8aPoS8Pq51bE1AI39iO9URoECkBhW5Gn71LGY MFwFdJNF/7C4etOSVmZgYvCiwPCAHyA= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=CSGCqORl; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=pyIB7Qxg; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf29.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712675718; a=rsa-sha256; cv=pass; b=ShQta29ko5fPkSpduq4eFdY+5qbFKYHGfcF2i2F+7I7DIplErG5aLBgrzj/0MkWTdkkkE+ L3vZpY+lD1247cBn+10C6B7QfgXQu9BlgdeIPqLXkp6d2NdZV937N5R9DFrCwpth7Kq+93 2fOvL/22IoUHrIrCM3ICQJcX6geRlnw= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 439BYsLP004421; Tue, 9 Apr 2024 15:15:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=JJx8rFJgOhLX915dXnECffN0CjFOZa3A5vbMGZf2LdU=; b=CSGCqORlfcNzBFVUAz1p28Fgcpy4ucdo4B2PEhVbe0PoTGcNpD9/wv0Du+DMY2LLA1Fb GijlYl0Kxxf8WuxxvkxU6qcl205ge4m3LXKm5/t0oRIyZ+TI7IfGYbxoX9kdsKWmnkyq WOyc30CohUWA1sAvrTLAVy1f2+j5e9i77Jp+b16A6tU4ImMBLXSJyjciXPOHDUlwELxk IRJGgFv59ttIQvYOjNR8/HptFhyIwVYnK573KzONOPzwLpHICfn10+pDsCUsAAJr2E5+ N0KO2ohe4L2MJM3Spdb1I/DDDxJD4iiNZ9FRFHE6jnVPZoOt3n5TQGB2QCd+HO38ONLB xg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xaxxvd7fr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 09 Apr 2024 15:15:11 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 439F0bqN010569; Tue, 9 Apr 2024 15:15:11 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2041.outbound.protection.outlook.com [104.47.57.41]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xavu6v6r9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 09 Apr 2024 15:15:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fZrbfYxc67v2+CFIOGvFcHHNQeBJWt9qMLdApOj0uJn7P/OkyJUg3Nf2Sd5ZdPOEr+HMHs06P4H+6KuPrQpUz/Gfn5vUZyvo5a6b6OJDfQVafuNx9VJGd84hl3IV2An0PytCWQmTldmrF0zKZ1mc64JXL41B+zhLP4gKPejEp9f6Rn/SJn7wS7aAPySJkEN6xWHBN7uMG9H027Cf8hF06+wkNNJvm+uUYpZKQweJi9gouyTUxgdcmzamXoTk2u7Eqg5LTx86LLLdlSlNzYNbXR4mwGuT7gl8MHYbTli5sHH3y7ksyefTKhKS5uKTUFTt7irLgvmufF78feQ88Wi2ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JJx8rFJgOhLX915dXnECffN0CjFOZa3A5vbMGZf2LdU=; b=Cl1Ij4lqw+XR7N8SERIT7bUnZq5cEzmW+dW0uiYaqftuga6HT3hhgLhtUpq8tM52nJz3AYrMl9xGtB4FyZoIysQcwYysN4L+Ixjx/sbfZk9R0DwrVfZp2ONTy73/eT/i9atI0JiSNTeVe2edDKGvEOv1AgJecwR3j4JVTpmITGXbiYj+Hx7ZEPCok9fqZejuE+IXox5Kaqv0GxaiWBUE8XV5jZrBe09WmqWIP43H6NUxTb32aJ7C9EA+90TC+/IwFSzdG+bgbSkqDAO9MiHtXaTH8PyyybSBZ23CG6DyMXQcX13FhILowBOYrCfaYURLoTDhItBUaWIIOygCbozJjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JJx8rFJgOhLX915dXnECffN0CjFOZa3A5vbMGZf2LdU=; b=pyIB7QxgQV4f1wJ3C8O7LYRVAVsCNDrzWFqg9/qc96vG4jqY8A+IuAv/8mWQzcdQHKP+13XICsvOLO57wdtNoNX0EKQO0KLA2gKZt26e9zMzcTA3LgEk2twCxA/RksO87rjfkMwhLWAN5V9fQ8L08F6itW4INx4ukdkc5BYbJQQ= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by CO1PR10MB4770.namprd10.prod.outlook.com (2603:10b6:303:96::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.54; Tue, 9 Apr 2024 15:15:09 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03%7]) with mapi id 15.20.7409.042; Tue, 9 Apr 2024 15:15:09 +0000 Message-ID: <38b9cc86-33a6-4824-8afe-64a2e9a1b7ce@oracle.com> Date: Tue, 9 Apr 2024 08:15:07 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/11] mm/memory-failure: Pass the folio to collect_procs_ksm() To: Matthew Wilcox Cc: Miaohe Lin , linux-mm@kvack.org References: <20240408194232.118537-1-willy@infradead.org> <20240408194232.118537-12-willy@infradead.org> <721459db-1a7d-4b39-aa42-723624e718a8@oracle.com> Content-Language: en-US From: Jane Chu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR05CA0015.namprd05.prod.outlook.com (2603:10b6:a03:33b::20) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|CO1PR10MB4770:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /LBSN3Uhztq7jxaf6o4rmmBX3UyuwUW0rsizp3R9YqI53LqGpzlcXWm3WtwmVvZOBBwkcH9aCgRr+DWagfN3VUA041nl1fA6lUUqAJIygBdhqgqSEzCbYQT2P3nXsjQqGnCNG+Krppz2ZPnw/u5jFg7vowBRYINFJ1i8Vhx4tUryJ2AVCgVW4arPSCvi5eukuB6pdN46uG0AzEvKwrqWquf2x+XpTO64uj+kML4GuofcCpqTKpO27TVGiDnZXCGM8yf0+lQ6EPN147OvPWJPokAiRIoeFRJWHb7b9C67VsuuPpc19CLR3eCz0U/GbDC34H1adJIhkiVwi1Vg8uBMydx81UV9y+82P64DRmBFNA1n7/JFavdspWPe8OaKP4lQ0Yi3FYRAxqxUE+AG88c3GKzNqYghrrlVf1FsXug4jaRK8murNBsk7N0xFf7fy4VNluO+poM3Rp6hV4P97+q8BfUz3EKXjZkNEnkgkZ8+3kFhJrZpdXjD9ocV5gja8x5Fsub10+xtjbKciMY4HWG2ds6+EurFe02hwEeiMxFy6kfboUHQDA8IO8uqw9B+AwO7IaDLdE+5DhT3wPd2eKSSFAXfRgqRfYfKQrwLGRDJ1+aK9Jl/Gj5z8NR8KkEEVDsphpcjwaQceeEfqnIYbpZ2ig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3lFcTRaS2x2cVJMc3YzQjlONWZhZG5mN1Z1dXViYTBCSUdKQUxqeEswQ3lI?= =?utf-8?B?WTBzT212bjZ2R3ZabS9QQW5XQ3ZYZlNnbWNiNmZPUnNJZ3FmajlOM085dG1F?= =?utf-8?B?clFUU25zNmZGa2U3aktQQjdkMkVCb0diTU1wTDV0MWtCdVowWVlhR1Btckwy?= =?utf-8?B?a29jS3ZJZSs3RmFSb0RUZlo2SElSbk5vMkVCekI2dERBdVlsTjE5b28xaDdI?= =?utf-8?B?ZFRIYXlFc0NVWUgrVU1FdENwWXBwRmU3UGlrUm5jK0VzdkRmLzFCb2xhdlBt?= =?utf-8?B?MmMyM0VLRm9zWkhOdG1iVlMvNndXMDFJd3lGcUNVZStJaVhjd0Z3Ui9YeGJI?= =?utf-8?B?OFNIUTZQelFTT2pYNDRXa3V1QWpwQVV6SjBrNFQ2eVdoRHNueG00RjZlQWFr?= =?utf-8?B?dFFDZkF2SW4zQldZSS9mamxRdUFpbGJWam82ZXpWU2JMTXJxc3I2bnRiWDZB?= =?utf-8?B?RHVNUnpVUUZ0SDNiSEFqZmtsL2M5STJsbGFNMUlsalkyL05QVmxZZ2t1b1l3?= =?utf-8?B?M3pXRFprVkxIc0NJcWpmS3ZrbkNBT0xuK3M2bWI2d0pFemhLaTNHV01mcTFt?= =?utf-8?B?UUtUUnRoOFNSb1g3czJHOXk0UjVxMXc2Mm5JVkozOHFXSnF3N3pmV0o5L2lz?= =?utf-8?B?cUR1OGx1ellyRnZZczJ5ZlgzOS9QOE1HTWZUT0ZkZFFkRElPZHNKSnJxR3NR?= =?utf-8?B?YjVlYjdWQ2hvRHlyeWJVQ01OLzhzOTBhYVJGa2kwVnJqVlZTL1hwc2FEMkpa?= =?utf-8?B?MWtaaERTRVpla2pleXBNQW52ZmRwUzRKT1JwOGtUQlBtSEl2RDZ6Z01iZmU0?= =?utf-8?B?ais4MTdWZ3BVaFZaRUUyVkZvWTlRMjhyck0wRFRsSUpYRXY1U2UwWVozOFVT?= =?utf-8?B?YXdRVmNtaGZNbXhUeHAydmZmY2p0SG1zT3EwL2c0WnI3Z1NjQktmR1lNMFEx?= =?utf-8?B?Qmx1MDlmN2U3WTlnOEVvZ0Y1NklKdW1sRGQ2RVVvd1BrY1cvbFlHS01SckFZ?= =?utf-8?B?MUhoL3pJY05lM09zTlpRd0o2WDhCVVFYUTVUa2Ivc3ZQS2h0MFRmUG5hMFY2?= =?utf-8?B?am83RmlNRFZqcVA4MXVXeVBFbU5uUEo0WTRvaWZKMFRmcHZRaHF4MHdHTUJX?= =?utf-8?B?c0dMZFhNeTNOSFY4VG1xaFVWQ2x6SjQrNmkrTmY3TmRtV01LT0g4UWJ4TU1u?= =?utf-8?B?QTNvK2Y3UVRQazhUU3B2UnBXWnNjM29TK2xVNnRXb1VJb3FRUjNPN2preXhv?= =?utf-8?B?RHpLMHNsa3pyN2Z2RU0wcEFYWVl2ZXA2VDExR0NkdVNHMkNRQzJVYVFOVDlB?= =?utf-8?B?R29XaG1kMU4rSWVPbUpNVExJNWpsNlBYY3BQN0VsUk1tWGRnbklIWGlOVFc0?= =?utf-8?B?WDhpTGRjSVFwYVhxR0pMUzlrSDhHWjZWS1RtWG1EOW0zeTVIS3JNM3loSnpW?= =?utf-8?B?Zzk1ZlBDYzAxUXVaZnlnR29oVUdNVmdJNGZFVmY0RlhtZ0pxa3RvRGh3RzRa?= =?utf-8?B?anFIMHRXQmNKUmJsNjhuNHFJK2wzbkJKS2FaN1QxemE5dVlQeE54dFl0c3Mv?= =?utf-8?B?dDN3bkU0TVNlYmJCWmNEN1hBb0MrckF4K1pEQVZzV3NXY1hjV0pHd216QmFu?= =?utf-8?B?VUM4V1VqN3V1dSswZVg5SzVuNDlxSVZDbUNMZzltSHUvZi84K2VaUGpFa1Zw?= =?utf-8?B?NnBWVVpuaTRPSitwYU1RMi9hbWtmV2tuRWpiUWRNaFlHQXQ0dFg0eDhwMER0?= =?utf-8?B?eFBDNnpXUWNTRE9oSDRZZmROSlV0MDN4NU1ENURHeDBMaGNxcFdTUFBVYUZ5?= =?utf-8?B?NS9HNFd4YVNpdWRDeEE0RDN1dnVrUE55WWo0MGRTRy9wOEx6RHdORjFKdjhM?= =?utf-8?B?UTM4dFBEejJSVDZsb2hKeU1YYStLUnFkNE95dlRsNWlERjUxU0JHdk5vL0xo?= =?utf-8?B?UmR2a24yeVMxV3lIdGhxUWxMUXRnNXN1ODRFaFBJaFE1bE16Y3owbUNoa21Y?= =?utf-8?B?QUV2S0FkRGlUc2FIRDkvVHVyeS9kRCtmQ0p6c1dFeHdkNFBYaE1kSDl1bm5F?= =?utf-8?B?aTY1SmJHMWxVMzlCWWRQa2RicGgxOWl1OUQ2d3dwZHhJaDJDSEF3eU1RWW9p?= =?utf-8?Q?F55wTLIuscLd+23lYfwaq892T?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BXcpSmeuKA/omL80FWhkpjIbha7ilEs06beeT5svba/HI99Y3NhNss/WdgZaX2VYWMOPrnUnA2Rd8WXAH6zCASN7maru90GQOUxQPKbUZFaBUq4mVPLAuj6fzRNqG/MR6ju8ZqMn9mVKDBhSwQfAxGbIrmdCCCx3d/mIDSM5yerG7l8lG6plyCv9jOc8gRi+LhzJgEmWm+5OU4N97hRo4cDiAt3fg0QGz25B+RX6PGtLFI7kKEZvJ6GPMZh3qTam94eq6BwlQMulDzszQ94gA3isPwr/I4Gd9BW3Wyfjg41ybBudHB48/B/dtVGLoWupZzBn8r1nGkiFqwl6VSirrQrWSLiwemLLO2/7nA/QJhQgZZJanLq/gyNySeGLdZtMRETeWRFQo56dboMnAnL1GW9fshuqhtAsgy0nEjcJuDx/VhTwYlBfRda5sCLk/pd4MDB4PUKlQcRhPBEqWqVFNlogw+ngAhfUzrQbZLGHuOO8SP5Zw3n1ReIh1sNDH5nL6cDS3Jndur7QG/M8ucyzgS96LiJ6LFNeiRUfc+PdNJchiSlIkQwPSMWAd0pvOsFX3C5pYD7tOUZpj+zdo2/YW1mlfiaQUpDH96H1JYBLVKw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9341f860-070f-4c5d-95dc-08dc58a7d82f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 15:15:09.2001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iaBXeSk8v8hbI8vifCUrwl1yHwaSGxncSZpVJmF2Wl8yX/naCafDAPS5km2mqUbKcz5dXbwluPZdQVdNx7y+8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4770 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-09_10,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=768 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404090100 X-Proofpoint-ORIG-GUID: SOgrwGqKjAn8m9Bk1x0eyutcpWSjkcvw X-Proofpoint-GUID: SOgrwGqKjAn8m9Bk1x0eyutcpWSjkcvw X-Rspamd-Queue-Id: A3537120005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: euyo6q8s1igotn137haepjxnpdy9wqen X-HE-Tag: 1712675718-921117 X-HE-Meta: U2FsdGVkX18e6HmJ8jBRlPMIukKr5I620jhhJTdm1aGKOPm34xE8mn9H2Lcb00T8BVdTP78guzmV8ABQylVfQOUNsWU94uedYUha5M+Lls8UDlWSiFN53PgF6ao0YM84z6lWtsBGeb2sqwWmnFqGN4YrrwSvfjMWShGD57Fj/+wWtR8/df6c9YXP/cDS2KIqL5n+lHVaXeKYlxqXmApPEwk5X0ESV7w4pN57bdENhpUVUspVVG2EZAEeE2tUiLz5VWgb0NWZj0s4jGTiUaviZjRtYevKqDqNUTGduNqoJgqPXnn+bYnUEPZvTd+jB4e6VoftL8IboaaGmy+94kkrYyxSH+vQLDDHDPaTi8v6K3ilY5aUORviuy5q1kNKL/DGZTgQC7LMDws0Uf9d73xFDghf8jcG2PfuhzMwoAK9ESmRoEUD0M6CaVTOC2ZeF67uL9kOc5IwaeakbkfGkbezqnvmuZj4GO66t+anA3KwKmKxhDcA70xxKn6SUznkD+zagxdYF38dcNZL/cA0njB451xawmOKQzVAU6ZAlSmeiFkpuSM+7Btg5mN30tGUJ9TNH35oTxSaUmy4MrIBn3WIZMDJ686gQNQJYKGt1sNyLOaXEAWDdMqNeGIBWxXuni1QgAXBgW5iULF2nY0eH4hBhU8W9XaKYbx9FJpljp0bLpP1sLPmwPZNBTMgeHW4vkzt9QNCo8EkwAykxNfR9yIi7B8lo96GJWYizHXmDY2IEtl9JHJSbNOtvHzSRqNWYn7svXBRiG+WSXIeciS/SQy7ApF5tIlphekmDlDHBO5+Q2tvdfZ9REZEgwnoFvRcIx8j6lXgQAbOoNmBdkJ6EXxQhqfZ0nltnoZMEbmLtR52+leXhiRl6psIxEEgvXu6+6edHZXpMk63JWjgnpVJ1DaRk9wfZBDJcekQ6rsenJGHx/KTX1tO4q24pyTIOUdGaX0ZbY/yqNY8NJTuLa0XO2A HSOrWfCh tfXJ9/2KRlmp0C563gq8TKip/KE/nt2b1UhJwxusllEngDS8iqHBr43uiArr/e5hvOUnLmB5ys5hKRgatk9u03cBkd9m9K1XaYJcTneycJss/tX874DHKVwv3LXMamVKvMKBjknWSqh1r4DA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/9/2024 5:11 AM, Matthew Wilcox wrote: > On Mon, Apr 08, 2024 at 11:27:02PM -0700, Jane Chu wrote: >> On 4/8/2024 12:42 PM, Matthew Wilcox (Oracle) wrote: >>> +++ b/include/linux/ksm.h >>> @@ -81,15 +81,9 @@ struct folio *ksm_might_need_to_copy(struct folio *folio, >>> void rmap_walk_ksm(struct folio *folio, struct rmap_walk_control *rwc); >>> void folio_migrate_ksm(struct folio *newfolio, struct folio *folio); >>> - >>> -#ifdef CONFIG_MEMORY_FAILURE >>> -void collect_procs_ksm(struct page *page, struct list_head *to_kill, >>> - int force_early); >>> -#endif >>> - >>> -#ifdef CONFIG_PROC_FS >>> +void collect_procs_ksm(struct folio *folio, struct page *page, >>> + struct list_head *to_kill, int force_early); >>> long ksm_process_profit(struct mm_struct *); >>> -#endif /* CONFIG_PROC_FS */ >> Why is the #ifdef-#endif CONFIG_PROC_FS removed?  In ksm.c, >> ksm_process_profit() is defined within the config switch. > Yes, but there's no need to put ifdefs around function declarations. > All it does is add a rather bogus dependency on the CONFIG symbol. > There's no harm in having a declaration for a function which doesn't > exist. I see, sounds good. Reviewed-by: Jane Chu -jane