From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA70C36018 for ; Tue, 1 Apr 2025 08:52:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4963D280002; Tue, 1 Apr 2025 04:52:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42291280001; Tue, 1 Apr 2025 04:52:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29BD6280002; Tue, 1 Apr 2025 04:52:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D410280001 for ; Tue, 1 Apr 2025 04:52:25 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E95C9161FCC for ; Tue, 1 Apr 2025 08:52:24 +0000 (UTC) X-FDA: 83284858608.16.37F078F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id A1E3840007 for ; Tue, 1 Apr 2025 08:52:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YUojYi8Z; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of pabeni@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743497542; a=rsa-sha256; cv=none; b=zdwb2w+SNtbCp2pltkaUq+3b8CTNl153L4xnSTIzZeO0nMNQfH3xw5LammoVLTY+2+kJXk DIH7/QhbzUSioAae+giY7nZ4RQEsrMkf82cHDD0JsuhxBBt0H81fD9PVoMKkK1Q3mfu4Jn J0/XrfI85w1aP518zIrYh4IugDT3yLY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YUojYi8Z; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of pabeni@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743497542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iTrzmKHOhipGTrVn6hOCwktriFPfHqZi1ySNcTDYp58=; b=emr3S+cm+b785ZtSXthcuwJz+v282sNRCcNNcCsgtTA7qNP0KzBzNLnI1hDoNO/1W2JXNi oaoeMK5JqqAyIXqIuSlv7Xz0GBxYH0hSJvAB0n5j04rU+Kx4PbWORZZjQJYNOyk80EzbDs HlZcraRumfj9sGMMDowGIepc1whKAI4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743497542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iTrzmKHOhipGTrVn6hOCwktriFPfHqZi1ySNcTDYp58=; b=YUojYi8ZAMeXoo/HxJ0x0B/DNZk3CljCNCrB/uYtvSkTGDMptoyt/IAVmTS1K3kecys3JU akTUhE9MxJdzeznuoxLNwPpQowFoKlkOZ7LZSqBUmA/uL0GnSPqQDI9nfJODc1w8RoiMHH AqL1zoGvoiK5VXNNnjhA4xECPLUVH40= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-543-DSI-9O_UMU-B5Uhm-7KzSA-1; Tue, 01 Apr 2025 04:52:20 -0400 X-MC-Unique: DSI-9O_UMU-B5Uhm-7KzSA-1 X-Mimecast-MFC-AGG-ID: DSI-9O_UMU-B5Uhm-7KzSA_1743497540 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-391425471d6so2335229f8f.3 for ; Tue, 01 Apr 2025 01:52:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743497540; x=1744102340; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iTrzmKHOhipGTrVn6hOCwktriFPfHqZi1ySNcTDYp58=; b=OKtA4xKH1IED8Rzr+L40SAkP0FgK1GXwv1IheYVbQe/0bJRkLbTYNRS4+cAPxi+YNf VqvSO6m2IaljwvH5mKExhfgRwAc4bvqwTDTs12B9djWOFUWwIX8BuKqorA6x/28k8I3K 9A8XbjK5rdvG29vRgctY4rxo5iLKvbZ00UrgBj5O6WY5905PMcUHLDPA/R2dR54lwlLr 9a9/tnB0lQdAYJID7QR06agYevayJESs/8mK8IvzFbrbcp0oWYJcQuC3ym4TC4jxhpyY vS/amI7RZ+xGdrSGXOAP+HIPUOOCM4mA+z+LsEt99V5YIU2p9tYYrv04H5Uh6NFtEfgM MtGg== X-Forwarded-Encrypted: i=1; AJvYcCVfC0EZRDjAdNXJEiK7zFSA2lKCXF+za4EGvIduj5XeczBDUJrFoKx7fcsSFMyYGp390VvioRlciw==@kvack.org X-Gm-Message-State: AOJu0Yz/Y8sIZjq1eKrgA/Z992He0z27k5drvc/vdupWoaiGaci27Z+5 O4j5Lfp4VwABi1Ubg7ixdJhnNcA9FG5VYReuylKL9LyOGevvCDp/CBtlIENo1cWT2xEQhuHltZS hnv06o8ZtNifOrfGNwJPgveljoQM4eFRO5HFhpQcw/cpukMQQ X-Gm-Gg: ASbGncvkhCIa3rejD6jRz44ctOTjd9iZZEa8C6OMtEmuX0I8bW8xwohuOqjsKrfU4kq Dcz8Renu/zRvcQPpK7YqNDWyvSJ3cmHs5YLq91S9zcxp4RAjrpfKAf74Vhm+7TLW4M1ItqEz2yq 73Hvn33ILNHH+HPHpRrtW3ScqnRvBnBw/lYj5/iL6r4ToVTHugxJPukoInwRUT6MzQnjZ9hZEuf EERgp3CpPIQj2BAjAahhtJkWUMuemEyk8RCbC07fW6KB7qhnOVa006npaD6W3uSz537sqrCLb2X 57W4TSIqTdXU6drt4GlAGIdaT1FzS+r5+b5PQRDX8US/lg== X-Received: by 2002:a5d:6daf:0:b0:391:1222:b444 with SMTP id ffacd0b85a97d-39c120db3f4mr8036366f8f.20.1743497539702; Tue, 01 Apr 2025 01:52:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEFIwIsFXgnFgUnvUf7GiB0Qo92O2pFQl8WkobeyI6QhVmQ5/bHplaSDVAbQLHpuaV2qU/iLQ== X-Received: by 2002:a5d:6daf:0:b0:391:1222:b444 with SMTP id ffacd0b85a97d-39c120db3f4mr8036337f8f.20.1743497539288; Tue, 01 Apr 2025 01:52:19 -0700 (PDT) Received: from [192.168.88.253] (146-241-68-231.dyn.eolo.it. [146.241.68.231]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b7a4351sm13751264f8f.98.2025.04.01.01.52.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 01:52:18 -0700 (PDT) Message-ID: <38b9af46-0d03-424d-8ecc-461b7daf216c@redhat.com> Date: Tue, 1 Apr 2025 10:52:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 2/2] page_pool: Track DMA-mapped pages and unmap them when destroying the pool To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, Qiuling Ren , Yuying Ma References: <20250328-page-pool-track-dma-v5-0-55002af683ad@redhat.com> <20250328-page-pool-track-dma-v5-2-55002af683ad@redhat.com> From: Paolo Abeni In-Reply-To: <20250328-page-pool-track-dma-v5-2-55002af683ad@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: c_1J360XmvTJYdkiWz5SKLtaY11qriwrwVxJN1TVE20_1743497540 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A1E3840007 X-Stat-Signature: r8kzcksnb4cbrskqmfjzika36y8mubin X-Rspam-User: X-HE-Tag: 1743497542-621024 X-HE-Meta: U2FsdGVkX18VrEn+h11Q31TM3FNo+JEE8hykBkR4arlOOZu/UhLVc877wzVsCKg9BQsmVl5vJgKVLWd0zGGXTbSG5x/2JMhCIYGW/MpC0I3UinLq5g+6FPrclY8Ue7VF1gmgvSciSQ1A7zPWh91ArmGHrQlLH8CFICnnuzUMx1D9FANDG2EcQscxFDjtHxy+unu+X4IXzqzca3u5xpYihzW4BsHGxP83Q/G5ALD1SjPpUoChRcwbawyj+78SQtfuihaDnQ3fsOwe5NpsB3gdwjc3q134zzaRpOuiQLUgEQYniY7cLAGgRaf+n17t9dIjKhpypsx44FAPFvHx9CrQtMssRugXnz6mwpvxXTuDtt1nZvcsuLLB0Phc5yl+vw9XCXKKSXyHrAdsO2UAXrQBDP2IZqTm98P2e1zvx032gKsjEHys5cXKtxWmVWMD6KgXOOx7w27SZ+VTnYEqqftL2nk11rHtL8d0bisz2Ij/UciOkjwzm0mmnlKLOF7Scsy7tVKP7QJKctZdcViiQwCcgtJ3PE8pfiUvX9Mf1I/eP6VtkvexevBOjkOReKa6LznGOkpGZx68qN9UjSr3ZiaawumI8Zx5LPT8TRsF/TTKcUytmM/ipZLrroXAYc7jJsYQzPUqvKv3sE2NU2Zt2P45RJvN2ytAPi3ksiA4i9X5Nfw5YGMFJEO/6OR0g4dEk9SObKfTW96PORomJu/0kKyBgxRVYPZjpqA37cvJyfTG57pQwFREm8wQQe48E0mhErMOcvh7FDsviicFf65UnZhhZMhK5EPqDL4gnlsTJbIS/O+oMkm4Zbj2P11UrVdbdhwJG8jPMf75Dsd4IGRftrFLxlquDmLog/KQpu2jrj7EQd9jGqL/8hxPgnvySwxKz8nXB0v1BjnIY4EgMtGgsE5N7alD2Cb1eOgVFgMr+2WGH2Rn049J7R00Lf49EAoDgKnoqmFZDetnxvkjBI0UwKc DteWKQ8s /5XFTqWtNvYFBP1DMjNiteqNMC2qS/VtLnAAt5EQLCVviM+y9HNLNCen5cLHykg9IGMSJgufa5TS029QxNNePXWvo1W2lA3NyPgiGTq4dWpeoVuKsYLCiDQDUmm2IEQdlwcPTlXMLTvvKt0y8Tt/Z6FZvqgflrKg5M0WYOFhSHz4TWkY6FUV3cUbfizkHo6hcpDA4YJel8lanZyAjpXftJZBNmkaKyCa4ZNY/Lg1CkdVs7w5FXshQkS5xnRLW75PIiY66YbBJAXpK2YPEj99g9VD2uuQWF+N2CFxOzo0M3JIq379H0C+n9mUCmFS4/ETOStQt57RXHonOjVIpIorWTHp5D1YyEFnhOHfPQQV+CnEC2ybe2T7TVupV0J33tszeyNd2txFiOuGrDykGOL1PH/zCcq80D49q8pXuk48VtmvmvGCBV5my/JLhPYqPvX+oJ71W8IgrMfUFH/ba7xugQ3uZFbznnTbKDU2b6e2Vqfg5aNhqlS7Nh9huwBVNgIa0f9sQYSVfhcmizkDHxjJnZ80xbXjx8FSLu4jS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/28/25 1:19 PM, Toke Høiland-Jørgensen wrote: > @@ -463,13 +462,21 @@ page_pool_dma_sync_for_device(const struct page_pool *pool, > netmem_ref netmem, > u32 dma_sync_size) > { > - if (pool->dma_sync && dma_dev_need_sync(pool->p.dev)) > - __page_pool_dma_sync_for_device(pool, netmem, dma_sync_size); > + if (pool->dma_sync && dma_dev_need_sync(pool->p.dev)) { Lacking a READ_ONCE() here, I think it's within compiler's right do some unexpected optimization between this read and the next one. Also it will make the double read more explicit. Thanks, Paolo