From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9576CC74A5B for ; Tue, 21 Mar 2023 11:41:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E88336B0075; Tue, 21 Mar 2023 07:41:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E38326B0078; Tue, 21 Mar 2023 07:41:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D00536B007B; Tue, 21 Mar 2023 07:41:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BF48E6B0075 for ; Tue, 21 Mar 2023 07:41:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 94165121384 for ; Tue, 21 Mar 2023 11:41:10 +0000 (UTC) X-FDA: 80592714300.15.90C5E16 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf15.hostedemail.com (Postfix) with ESMTP id A8571A000D for ; Tue, 21 Mar 2023 11:41:07 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PKV3JR3W; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CWZ8vl7U; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679398868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MwTj1oxYQNef9fyW1y1b6zGbRy/MsPXVId7UhSbxGHo=; b=dAfRyNntjYD1NjLiM9obsULMsaINewa41Mq6AiYGeewBdAShVS5CQq/ndo3PM8uI9RkIpB RpeAT3NmjxoTg47UyjxiH0DDpeQEW8cYpS98pWeCifCF5ry28aWTLofEqG8NmS1M7Wva3A mxqCW7wp9AiHmZCELhbUrRlbB4+xQRk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PKV3JR3W; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CWZ8vl7U; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679398868; a=rsa-sha256; cv=none; b=cj+pS/yhdTA0MGgz4EYYQsfAxgVmWi064DLJsvQZplFeqns7QiSBvTaE9hmllDGry7F+uJ PHdJ74Zz00Kgq0wlmZKqCyYngfNnxBe8O4N6qP2l5K2Aqur0jbs9vmcxVBVbX0iFAlthuJ 6MmmPyTSA7BESXlkloQSWYEx/DUuh1k= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6782021C90; Tue, 21 Mar 2023 11:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679398866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MwTj1oxYQNef9fyW1y1b6zGbRy/MsPXVId7UhSbxGHo=; b=PKV3JR3WSlhF3QR+TaeAlwtUggs2deWrLqNLbNztOzVlTqPHbHCD2S22muGH8UAsbytSCU HwKieIj/PsmbG/SLsuW4fwrr+ngHvqcqP/gStK0HeUpk1jsc6Tq0t5iocR1HGJIRCilPTp tIcb0OOPPiMNvc0/nTwbn9hO0jaBUi0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679398866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MwTj1oxYQNef9fyW1y1b6zGbRy/MsPXVId7UhSbxGHo=; b=CWZ8vl7U0gaxKv/IxIhWPeI1F3rphj7OJKaqjGufGdo+v8qg1QqDR+dQcIeI1D/AT6XQJn pxhAG8WcUFpP1pDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3518D13451; Tue, 21 Mar 2023 11:41:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5zO6C9KXGWTyAwAAMHmgww (envelope-from ); Tue, 21 Mar 2023 11:41:06 +0000 Message-ID: <38b82ca1-29c2-4ce5-b7d6-bf1b7dcc365b@suse.cz> Date: Tue, 21 Mar 2023 12:41:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCHv2] mm/page_alloc: Make deferred page init free pages in MAX_ORDER blocks Content-Language: en-US To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , David Hildenbrand Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230321002415.20843-1-kirill.shutemov@linux.intel.com> From: Vlastimil Babka In-Reply-To: <20230321002415.20843-1-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A8571A000D X-Stat-Signature: 15om1omhmmwrze3mbkd99pniudhq3635 X-HE-Tag: 1679398867-857908 X-HE-Meta: U2FsdGVkX1+EY3qOdvgFyuUhBRpMvdJImoGAzz6qnv10jxp96F0ftItcOI8nTB20mewyQfDens5JXvlSxIUQgFdTKapXlOuXjitnDLcoyyrUUzgH5uZ6Ct6jDOSS8uMNH361lyPKuPVJ3gbMbMgf/0JY9n7I+7rQWhQTlyDxtrm+g7jptPkDFeSW/f6PUTe+Ns4QWnu70u9W0JBn/z1ifmtEjloLPnJaiAMdAv76GJMoFgShv20/2rHZ3RU07jytfWjnZ9WEinYbUybXsMC0piIvSXWrTkS9fsa8MAzd9O2IR3JOpCBD3IQ77Hv1I9lF7lvq/kzvur8vxu7VC9FhSzFoc2/IT3Hj5s7NfLK3C6ia5NYXJobMWfh3S6ewAch0UXlViPmq2ZJnpM4es8WCkeX6rbBGfQRgYeeeDA5SsUTaf6UImOuogXMzA5S+t8UwqAR0XU+prNIEcGGCgc9vCepIQjHtN6norMFdhl5u9eyeVoF8mku2Z1CSTmL0Gd1Y3GUn1zVAAyTxU4maoGFKX6t1sQY7wT6AG9FZfIem+R88Ommv01RuGUSzA/jz9KXcpxX3KyDF1aeE8tO+sa7h8+1FUs/PN8WKnmRLI6dylM3+JQFf9MQyYjj5boua5EVKNG7eL2EOtZjs24njrHvCC+ZPkuQv2UVgX5Vn2wIhvQj9exh+1OrHcjSIugFJ/HVzZqITWk6r+YRPrCmI3erIq8ALCP6vjKV54jkiSemI6AE4oCbSASyjZo2Gbo04z3QIG3pFQ7i8cHjCkhj9x3WSfDROllT9EPYrN3QDzKMofYrJPznhdUDsuA7ytj+C48NA73pWjGBtpdow5FMnt/oNbC6KRP3x3jsFusZuCAtp9DhkBaJd5FxpxSvVws87jQTfSv6i2SlgYugQFP6LQ0rjYMBSe0I4CSTwtjTb2B1PnWip8u/BoZcrSrCDq0CT+yifRVlxcR/a6E4vJkQsPJY 4g6vzt5x wu3e4sOuXaccRFW1j5flRHGL3VyqQUd9RdvVrF9gfzJZSFf1wcaMivy1rVo/oCxMQGsVtNJDFwth5XgikdjwXCyM5O2wz3EFLMt9i2e3Pe4lhTeMjzMKnF3rQqEIYVbaoebSoRfROQgBujjW+GcXznNF4bCh7mr5JGabxmCkPWM4pfIRhrMz9yeSxEgavFSfg0umM9vYags6SGRxDSMQuh0IiDYti9gAXszuKyc4lp7CojP4l+rMYh8j/RgSHkAEzWtshCsvrHHvgvo8HoDQdHlRQplJ5ZO804NLd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/21/23 01:24, Kirill A. Shutemov wrote: > Normal page init path frees pages during the boot in MAX_ORDER chunks, > but deferred page init path does it in pageblock blocks. > > Change deferred page init path to work in MAX_ORDER blocks. > > For cases when MAX_ORDER is larger than pageblock, set migrate type to > MIGRATE_MOVABLE for all pageblocks covered by the page. Looks like the problems with migratetype were why commit e780149bcd4b ("mm: fix set pageblock migratetype in deferred struct page init") switched it from MAX_ORDER to pageblock_order. This should work better. > Signed-off-by: Kirill A. Shutemov Reviewed-by: Vlastimil Babka But I think you'll have to rebase on mm-unstable that moved some of the code to mm_init.c