From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59060D1624B for ; Mon, 14 Oct 2024 11:46:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C88FD6B0082; Mon, 14 Oct 2024 07:46:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1BCA6B0083; Mon, 14 Oct 2024 07:46:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8BB36B0085; Mon, 14 Oct 2024 07:46:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8AA8C6B0082 for ; Mon, 14 Oct 2024 07:46:12 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2186AA0E18 for ; Mon, 14 Oct 2024 11:45:58 +0000 (UTC) X-FDA: 82672029048.17.9486ECF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 6000E180011 for ; Mon, 14 Oct 2024 11:46:08 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CTKnMC0Z; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728906228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gBjYzcRVvT12PEuEEui9pwXMfmtmAfZKGIhfMKjJ2K4=; b=OUszzbK1rkrkoOZB7/7nltPRWKx2Hi0mccH2x3tOgm8FmortNKAiXKHYk66BUGh1aYoMtP caW/R4ROE/531RqLxNOtZ5kYHeobps1qSGWYll/peRheh96gHuxSdO6XdJYHBR8xVDDihQ tU09Sifh4Qofp50YxMyuA0c4BRDgjJY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728906228; a=rsa-sha256; cv=none; b=48DQUTp0euPxNOAMAIMFqNMc/CyfZAff2nwl4Q5nCAF9x8kcmO9pMlxB8Iv+WNZKak6n5R wVizC73PC6LOT0ptOpI9wOlZOq/SMRPV3kTD5rSrN3/lYZ12jY9q5HK3WRgHKFt5zGdlEg 128ezGFrEcG2jIg9EYz3tQK7g1QurIE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CTKnMC0Z; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728906369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gBjYzcRVvT12PEuEEui9pwXMfmtmAfZKGIhfMKjJ2K4=; b=CTKnMC0Z2bohhGUASi7wxzZLrUvxwku8+1do5QPWwmwM9IWhfXre5d8z8lDidf9zyHvChE VHQcuOjTQNGjK2haLWmU0DMpaJj8Va4eqdmKzRVAgRj7+7taR78vNBNOYIW/k1j9sWKS00 6xDLrwY6kX7J75lq/qQvqWVaKLB8nfE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-7NwUcv7LOFyqop4_I6PRJw-1; Mon, 14 Oct 2024 07:46:08 -0400 X-MC-Unique: 7NwUcv7LOFyqop4_I6PRJw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d462b64e3so1667891f8f.3 for ; Mon, 14 Oct 2024 04:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728906367; x=1729511167; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gBjYzcRVvT12PEuEEui9pwXMfmtmAfZKGIhfMKjJ2K4=; b=UnQ7NnUSO0zG9OtYKOO+IcrAlOVP2rmDxBizrRTS60Q1DxLZER4bqMXOtM6+3XzqCt Ocmzrirmyi/8K4hIxjmISNohnu/SZ2jVo42uxb8Vc5V52dcTGjOWwch7wzx1FFcJIxkg bl/unJRE5yX8LZo3+f0hNfLEk3JayWfBH7/cvcU19fOM9ALYxWCNUq6+yY46qSk7gMWh iFrbxTlEPQJmObsWte/4nTg8J2c6/J7s3iKQ4g58KUCFzXpSomhy5W2qU5u1R+ZeHj4x bdW22Ev925KrkOne6mLnV51TtsBB9qy9rPEcpv0t4JZM2fLGymT4M69uuK9+MPnfr/SK qz/Q== X-Forwarded-Encrypted: i=1; AJvYcCUTqk/3jNyTIkcql8wPc4pREIts53zfZiCGRUV+02iZb/LAih+amIT8WGd9cdSotPKdHZPNEuKfKQ==@kvack.org X-Gm-Message-State: AOJu0YzwU4kYUbDX75Rk9rDNwMCvFIvAuyE1kmZ83+mHKNDD+rr8efzc EU3uVOWNgfTz1OpBeWUogozcS3DNRnnEfxAPFzSeGZEdhLMg96ieSskN526KjK3pVwxlNFDbJVd G8H/IvZZNJt7bptPefjCwQ+nyRyM+SpBlBPQVENz8PrjfShTu X-Received: by 2002:a5d:4bc7:0:b0:37d:5257:41bd with SMTP id ffacd0b85a97d-37d5fe9563bmr5646864f8f.3.1728906366819; Mon, 14 Oct 2024 04:46:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGy4+eK7AI1hvF0chp44blw4HV74w/vDgNn4hR29csqzaMxakWWq4fE61CpHPmk22Wnjjh4wA== X-Received: by 2002:a5d:4bc7:0:b0:37d:5257:41bd with SMTP id ffacd0b85a97d-37d5fe9563bmr5646848f8f.3.1728906366399; Mon, 14 Oct 2024 04:46:06 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b79f9a9sm11208067f8f.74.2024.10.14.04.46.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 04:46:05 -0700 (PDT) Message-ID: <38b5649b-0e4b-460c-8097-04c530fbfa46@redhat.com> Date: Mon, 14 Oct 2024 13:46:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kaslr: rename physmem_end and PHYSMEM_END to direct_map_physmem_end To: John Hubbard , Andrew Morton Cc: Thomas Gleixner , Will Deacon , Alistair Popple , Jordan Niethe , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-mm@kvack.org, LKML References: <20241009025024.89813-1-jhubbard@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241009025024.89813-1-jhubbard@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6000E180011 X-Stat-Signature: 9rneyj8bw6wzqjm7rhp7m4ct1otsmhta X-HE-Tag: 1728906368-455762 X-HE-Meta: U2FsdGVkX1+38YAc1W3Vzk0g0YzCxWfq6fHvuFOK0wt1z5V73kqiN3U6VvL8UPn6PZWYre/p89eENNte+P1o/4IGBg6WXsnnDYJAbyrd8RywWzSCt0S31RDHqJvPdqmszph6ofovrYDJgcJ0DalJzcKxmK/k4YKQWRn2st5vYqEyQYeJrW7rT75/3YyTLFJPJADbYp2mLnV7dd1TTgyDIihnvhAjue6wOwsHTEUYUjkhroKJm96lE0l6HNQLoJIo6wsK2Mb3XU2PQGBJY2XKyKvu7hvEzNW7QKMy6W/7JKRx/du/urM7JICYY4DiH1hZotm8CU1gx6gqD8mZMgeMYMJjunQU7aHmLTXVx06eKrR5/gGnsekouIUJNHtktQW3ycuvkMwFvUVj440+ddGooN0nH2N/XgTV35JPpWDs1DhouyVZyIV0kRwaXouH+3JrP/WfZgeK04/rgg9MC+g9C+pyCf7ALEUtil12tlKZ6ZSR6uSCqzL9eqsT7DRKRpr1ryLICCU9VH7oaKq8W6I2Gk+OWR+Qy+qfh0GE/oSdcWHGRDfEEU4CVfSu1h6WV3zN93lZDVqeqklbVJOoqnmB08G534QY/EbMK+WALTy8/aQL4b8SlgF5lBrZaTl25bCD4J+pGzeEi4cp4FmNrpeepnImbaUNBVcy3Gr+DNwydFGftTVSuYqhTLxfhUWOIpauD+J7t+Dm37Du6JF++u/koVy9TzVjki53h3tzGQfqHIL08m2oGa5siTnLmeJq9pC+g67bxRjm+BH8iKN4rZ4Bwvx35X5h/+sJqJ/z6gJqoyb8hwyWGKPRkR4JwctLBCfUSJuNUTFzP2YMbXf6Hzbqo3EGSsCvE6jQ1hCvMVyX3L1f14x/YbJE7Y8gd9k17tsq0M3E0vmfSww61OHmnMbrOPXjGY2XFVx/OJ/zSk9l8XV7NYjH8Ew+Sg39yayl62rDeJ6lDhZo+eim+Tf6sAV H3OxsUHt sXzckWvaz7Vn5gxH7QvuNbMoEuYcZ1miUgha5ihR7m4yvezpDg3PQNQMZW0YE/S9GeNq0MpvC2CFJJCDH1LEJFsydVw2e7IBgbn97Bc2LGz8WCrk6hrjGfCOFn1QiHaNJBoIxlB7HN4ds/j73lgFOyDqUl97AOdJE6uf4PP3C/xl8vUMeHzUF8JmwhZvgpZe5vKnpdkS6FH8LFJX+kMxqKOGYCaxZAQWGtRRy37URm4kYetM9K4jS/MR3doUQ03fn4Nm7p4LcNIxR2Sf5b6nzsvhyMQATH7qfg/HVwhOTc/Qr9ZsPPSD8ax6vki6+nCrMo04V67VdRFb4Lbwxz2e9fOje5y2+KWYgSgc9p49IyyPcl0fJT9aCUkgkjIAsCJbPqD+nz1qt7Ezit3bKgwjHe0Fa5B2VoCOsu1FlMP2/JE9srxTV0g/UN+sMXzrF4oIx25i5I1hq1myWAsAjEB99IS1nQGCiW4Ebord7fOFSYJLAUjrE36TdPiZWl0Mtvk4qmhUpzOzsURz9kHw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.10.24 04:50, John Hubbard wrote: > For clarity. It's increasingly hard to reason about the code, when KASLR > is moving around the boundaries. In this case where KASLR is randomizing > the location of the kernel image within physical memory, the maximum > number of address bits for physical memory has not changed. > > What has changed is the ending address of memory that is allowed to be > directly mapped by the kernel. > > Let's name the variable, and the associated macro accordingly. > > Also, enhance the comment above the direct_map_physmem_end definition, > to further clarify how this all works. > > Cc: Thomas Gleixner > Cc: Alistair Popple > Cc: Jordan Niethe > Cc: David Hildenbrand > Signed-off-by: John Hubbard > --- > > David Hildenbrand, I recall you had an unanswered question in this > vicinity [1] when tglx's recent kaslr fix was being reviewed. Maybe this > will help with that. Yes, that makes it clearer for me, thanks Acked-by: David Hildenbrand -- Cheers, David / dhildenb