From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0011EED61E for ; Thu, 12 Sep 2024 16:32:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 706C96B0083; Thu, 12 Sep 2024 12:32:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B70A6B008C; Thu, 12 Sep 2024 12:32:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A5B46B0092; Thu, 12 Sep 2024 12:32:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3A1416B0083 for ; Thu, 12 Sep 2024 12:32:26 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CFFD5120CAF for ; Thu, 12 Sep 2024 16:32:25 +0000 (UTC) X-FDA: 82556629050.07.B48D7B4 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf28.hostedemail.com (Postfix) with ESMTP id AD687C000C for ; Thu, 12 Sep 2024 16:32:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=AMEjY1sX; dmarc=none; spf=pass (imf28.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.43 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726158666; a=rsa-sha256; cv=none; b=NB7JwXcg7keCb47mD49kYlbqrzjzZfjtyZQNU+5nTpAyNwCb6lgRN71w9z2s8uO56LSVzS kxUF3JPMvnL5a8qPTbCgBtzjVt4QnyHHbE+UpkfjZA7I/vvE5Z0sVspFgCoGL3ehawwAzW v923RUwQ4+11d1xhDEbepdnlJ6jOntE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=AMEjY1sX; dmarc=none; spf=pass (imf28.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.43 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726158666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3urj8tePJutWd/IrbdvsFovEyTtE2721b7veYUpgRCc=; b=U95ifmbtnmk64drm4Qi0wumJKmWq0c/JbwwsGdItcb48+dh5qqY6C5bISyn5tWNQSVyLpo mDZZNIZBew+HBwEc8EekvwUOYV97SvRKhzkqANT0OuvR0UEWUK6HiJqJCWYxmOYDWa+LBZ CYKZAD5zhSIydvX6ck3NuWJknKBtvSg= Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-82cdb749598so57169739f.1 for ; Thu, 12 Sep 2024 09:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1726158742; x=1726763542; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3urj8tePJutWd/IrbdvsFovEyTtE2721b7veYUpgRCc=; b=AMEjY1sX3o+roBdziDgpi6t7lpTK29rbDVslVK1uBfMTLckqJcPjzBWk9k8kkQJKfQ WT0FSFAlXHlTPV8ZeOoTUmsm+qn7S3eGbGzQa7PeVvqYtx0waChKa6KA8WWMKZxIsSlD HzU7jX4ScWA5ojpqpUKDV60J5//C6XVaLRec8Jsyz87kqQkuofRZ300eKZb5BGohrMNv TdfgcRiR7IGS2HNrI4L89JVcdRw9XnXMZU38yv2fqzYdHD5SsI4oLIvZUSxsEvsUq6Vj tVbgiYhwxczV4bS6QOtjZGWf1tqiON4+mfUSZUbVkAciTvGpClaebnF3HaAslBvmOE4Q myCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726158742; x=1726763542; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3urj8tePJutWd/IrbdvsFovEyTtE2721b7veYUpgRCc=; b=PCGlc6RnT2vFOzqFiefZQMH9NygaEvY0YmUP/wPGhkhmgbaD20Yyup70WNEGxr+4Xz ZoiWo19FQb/lKZKUhldI1egDd42IXOEKckPhlAnN3kVZx3U/4HmTdOth2gK0kPCjsQ+I VN7eoiz7AI6s6l3WN7O0oFj5ptgnfyLiFjLvz0yhwUUg+qyOK3RlFJxobqEhTNMtuUm1 nGNIHE9HtsR6mws9nFaiRfn1xN8vS+joD2Ft8qDW0Bjj9m1x/IQfwMH0PaE2slpk+0yZ 4k4MqpCdqpcc6V6QpelTzcfhRhO/6XEWlG4I03ABujPz4eJol1W8vNHJcASE6tu7xuAu 7ByA== X-Forwarded-Encrypted: i=1; AJvYcCVDjwzgq5XnHcjb0lDdQAcYR/QO9KU/m6eVBR2iRwWXYVyTIdtJKHLDRkWFoPTapiMuLm1akickkA==@kvack.org X-Gm-Message-State: AOJu0Yw2l5uCk+yXUB7Zp+EdVFgePg9otTTnMF8Q7jakpckzSbm0XxVk gHdW7IzpF63j3f5TeePkMMpswUH7LpdDdZJDVed6j2L6BCmKmnZnRD7BHblpqrc= X-Google-Smtp-Source: AGHT+IF5GUUBvcN/9IQWpyuBohIoLZhgni30cLRBwBi9s2pQziYqYiYvVShYoXxMqJMmlwI53g9KSw== X-Received: by 2002:a05:6602:3407:b0:82c:e4e1:2e99 with SMTP id ca18e2360f4ac-82d1f958b32mr349774839f.11.1726158742335; Thu, 12 Sep 2024 09:32:22 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d35f56d1b2sm683188173.38.2024.09.12.09.32.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 09:32:21 -0700 (PDT) Message-ID: <38a79cd5-2534-4614-bead-e77a087fefb2@kernel.dk> Date: Thu, 12 Sep 2024 10:32:21 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 6/8] block: implement write zeroes io_uring cmd To: Pavel Begunkov , Christoph Hellwig Cc: io-uring@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, Conrad Meyer References: <8e7975e44504d8371d716167face2bc8e248f7a4.1726072086.git.asml.silence@gmail.com> <707bc959-53f0-45c9-9898-59b0ccbf216a@gmail.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <707bc959-53f0-45c9-9898-59b0ccbf216a@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AD687C000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4zeygkyb6f931bhpuxousoqwuy7z5bqu X-HE-Tag: 1726158743-563873 X-HE-Meta: U2FsdGVkX1+sk7v6VBnCfSPCq38pXu/9GfkEO0IEtzJ34bF/qbdbrELMokIxGakqxStN+AKbS1T71EfTGpVC/qhJ4JbGvAhhFuov3yiLeyoPqhE7lB0/MyWAg4QPUD9tWUkjFk/qpfRguwtfXZ9mXqPV7B9gHbeSNZOfl05ZcTRx/aIE9fVI6JZsxhibIeP54m8j9lMR6JBH6fw0TGVKZICvOS05ic2G00JV1QissObjwYu+1ieuRT3FqVjMxICrI5ZdiwfeOXgFIo4QhA6xRGHb9pTBKijZoaexGnMuef3GaMap/NyiXTyMgYB4mQdPahCUo4JgcCZkB7jbxn952a+CO8mSoramWZ5qzd0NSKt8Y9sSVnvQwmKPGxUV3uaDjNmk0rEksEWSRzwhfa/kQuVgMJ4qg0x/6Xfmip1opno7kxG1yVpjwmT3cp8reyHGoGRaPskeVfJxujSC7Skubu0YCEx4MA58knKkIUeSEUv8/uUU1hwsp1nQhU/gnv9mzBQrFtRDcPQ9Cjf664eFG/AFobcn9w9c8IU1pbBcOnrIIxGjiNVTdoVjlZmOZV5UrWu36B9Q4TVHkq+ZZIknfx8n6xMT2eIX7qym953GONlGcP0/MVf9qbH6uA9VTMGiwcFWy6DQwBzFEqBaP9U8LoeWpGxEdBKjJlcpPy7gMapXqIAFYlz6TqUcETSpAM+v0/9u/692qtFVpFXrPpwMUXjzsQ2zU53ML7ryhCgwUlbrZ9pCPD6FZtJm6a/lYHJPBNki7IdPIZK03dK6fsC23FCZd+k0+VGD2YZQ5X7hshBfND24y6k/8xonFxPAVCjdI+ma9byoRZ+g5iwgr0dJk/tRfX0n9UrWdLPnT+BTmJ9YhYn6qJlqunY4MzjLmhCV+gFYQUpa3KusXSS9uj2osh4pr1HCxicdtgx9GgzUQcMvPps5VftlNQCwLWi3sW1y4GghPAnNN0Q2KrBaRaw AYFu49WC PUsF+Ls2wmR04H29Fpzeber8ZjQZ8y8JuEywAA/4ZxaUcRJP9lBefkQtmMb8fur3kANwKJB6FVA4kQ19dnyBCz7FCvwSNDMteyO35YajzW9CF8F2ZbxoxUzYVJ5FbN55tcBua80jhJoGLKr34GGWuV4JLbsb2dRxMvwQyNpLEQcWRZ3tujlMLfMjOZuz8DV044WpW35Pgo955OWlyp0V+Efy0/lOSEmNwemprM0WuiTY0Z9azbQkrRllL7bxzneRZSxCSva6QJXMVgWh9vhUj1LCyuiKmniWl5OyWbAZJ2lVr9kICj5G9hTIL0Ip8XPTiDsHGOrlbwIvDkwbA75g4VmTb0w9WxywndyhXKbImZ1OEi7jMjt9UMid+yAGkVuHytYUDblW5ERRJIzUaUQVMuAZuiQi0O8KyG10mv4P4dquXZX51SHWcmFxzbV2EjtQPZVWTSwQK6zpUX3Mnm/5eGZbgIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000074, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 10:25 AM, Pavel Begunkov wrote: >> an entirely different command leading to applications breaking when >> just using the command and the hardware doesn't support it. >> >> Nacked-by: Christoph Hellwig >> >> to this incomplete API that will just create incompatbilities. > > That's fine, I'd rather take your nack than humouring the idea > of having a worse api than it could be. How about we just drop 6-8 for now, and just focus on getting the actual main discard operation in? That's (by far) the most important anyway, and we can always add the write-zeroes bit later. -- Jens Axboe