[PATCH v3 3/3] amdgpu: don't report an error if the process was killed

[PATCH v3 3/3] amdgpu: don't report an error if the process was killed

[Mikulas Patocka]

If the process was killed by a fatal signal, amdgpu_hmm_register could
return -EINTR (the -EINTR comes from mm_take_all_locks).

Don't log the error in this case, because no error happened.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Index: mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
===================================================================
--- mm.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-04 21:19:14.000000000 +0100
+++ mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-04 21:19:14.000000000 +0100
@@ -1070,8 +1070,13 @@ static int init_user_pages(struct kgd_me
 
 	ret = amdgpu_hmm_register(bo, user_addr);
 	if (ret) {
-		pr_err("%s: Failed to register MMU notifier: %d\n",
-		       __func__, ret);
+		/*
+		 * If we got EINTR because the process was killed, don't report
+		 * it, because no error happened.
+		 */
+		if (!(fatal_signal_pending(current) && ret == -EINTR))
+			pr_err("%s: Failed to register MMU notifier: %d\n",
+			       __func__, ret);
 		goto out;
 	}
 

Re: [PATCH v3 3/3] amdgpu: don't report an error if the process was killed

[Christian König]

On 1/4/26 22:17, Mikulas Patocka wrote:
> If the process was killed by a fatal signal, amdgpu_hmm_register could
> return -EINTR (the -EINTR comes from mm_take_all_locks).
> 
> Don't log the error in this case, because no error happened.
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> 
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> Index: mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> ===================================================================
> --- mm.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-04 21:19:14.000000000 +0100
> +++ mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-04 21:19:14.000000000 +0100
> @@ -1070,8 +1070,13 @@ static int init_user_pages(struct kgd_me
>  
>  	ret = amdgpu_hmm_register(bo, user_addr);
>  	if (ret) {
> -		pr_err("%s: Failed to register MMU notifier: %d\n",
> -		       __func__, ret);
> +		/*
> +		 * If we got EINTR because the process was killed, don't report
> +		 * it, because no error happened.
> +		 */
> +		if (!(fatal_signal_pending(current) && ret == -EINTR))

The usually approach is to check the return value only.

> +			pr_err("%s: Failed to register MMU notifier: %d\n",
> +			       __func__, ret);

But in this particular case just remove the pr_err(), it seems completely superfluous to me.

The only reasonable user error here is that we run out of memory and that is noted in syslog quite extensively anyway.

Regards,
Christian.

>  		goto out;
>  	}
>  
> 

Re: [PATCH v3 3/3] amdgpu: don't report an error if the process was killed

[Lorenzo Stoakes]

Gentle nudge to ask you to please thread these series emails properly in
future.

Use something like:

git format-patch --cover-letter --thread ...

Or b4 or etc.

This is a nightmare to try to review without it.

Thanks!

Re: [PATCH v3 3/3] amdgpu: don't report an error if the process was killed

[Mikulas Patocka]

On Mon, 5 Jan 2026, Lorenzo Stoakes wrote:

> Gentle nudge to ask you to please thread these series emails properly in
> future.
> 
> Use something like:
> 
> git format-patch --cover-letter --thread ...
> 
> Or b4 or etc.
> 
> This is a nightmare to try to review without it.
> 
> Thanks!

I don't use git for patch development. I use quilt. I find git quite 
awkward when I need to move between multiple patches and update them 
independently.

I'll try to send the next version of this patchset using the 'quilt mail' 
command.

Mikulas

Re: [PATCH v3 3/3] amdgpu: don't report an error if the process was killed

[David Hildenbrand (Red Hat)]

On 1/7/26 21:29, Mikulas Patocka wrote:
> 
> 
> On Mon, 5 Jan 2026, Lorenzo Stoakes wrote:
> 
>> Gentle nudge to ask you to please thread these series emails properly in
>> future.
>>
>> Use something like:
>>
>> git format-patch --cover-letter --thread ...
>>
>> Or b4 or etc.
>>
>> This is a nightmare to try to review without it.
>>
>> Thanks!
> 
> I don't use git for patch development. I use quilt. I find git quite
> awkward when I need to move between multiple patches and update them
> independently.

You mean, multiple pages in the same tree? I hope you know about "git 
rebase -i" and "git commit --amend" :)

-- 
Cheers

David

Re: [PATCH v3 3/3] amdgpu: don't report an error if the process was killed

[Lorenzo Stoakes]

On Sun, Jan 04, 2026 at 10:17:52PM +0100, Mikulas Patocka wrote:
> If the process was killed by a fatal signal, amdgpu_hmm_register could
> return -EINTR (the -EINTR comes from mm_take_all_locks).
>
> Don't log the error in this case, because no error happened.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> Index: mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> ===================================================================
> --- mm.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-04 21:19:14.000000000 +0100
> +++ mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-04 21:19:14.000000000 +0100
> @@ -1070,8 +1070,13 @@ static int init_user_pages(struct kgd_me
>
>  	ret = amdgpu_hmm_register(bo, user_addr);
>  	if (ret) {
> -		pr_err("%s: Failed to register MMU notifier: %d\n",
> -		       __func__, ret);
> +		/*
> +		 * If we got EINTR because the process was killed, don't report
> +		 * it, because no error happened.
> +		 */

I mean, an error did happen right? It seems reasonable to report that you
couldn't register it because a fatal signal arose, so not sure this adds much
value.

If we really do want to skip reporting it, I agree with Christian, the
fatal_signal_pending() seems superfluous.

So if you want to skip reporting a process killed by fatal signal I'd implement
it as:

	if (ret && ret != -EINTR) {
		...
	}

But I generally think this is fine as-is, a user can see the error was
-EINTR. So I'd drop this patch personally.

> +		if (!(fatal_signal_pending(current) && ret == -EINTR))
> +			pr_err("%s: Failed to register MMU notifier: %d\n",
> +			       __func__, ret);
>  		goto out;
>  	}
>
>
>

Re: [PATCH v3 3/3] amdgpu: don't report an error if the process was killed

[Liam R. Howlett]

* Mikulas Patocka <mpatocka@redhat.com> [260104 16:18]:
> If the process was killed by a fatal signal, amdgpu_hmm_register could
> return -EINTR (the -EINTR comes from mm_take_all_locks).
> 
> Don't log the error in this case, because no error happened.
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> 
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> Index: mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> ===================================================================
> --- mm.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-04 21:19:14.000000000 +0100
> +++ mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-04 21:19:14.000000000 +0100
> @@ -1070,8 +1070,13 @@ static int init_user_pages(struct kgd_me
>  
>  	ret = amdgpu_hmm_register(bo, user_addr);
>  	if (ret) {
> -		pr_err("%s: Failed to register MMU notifier: %d\n",
> -		       __func__, ret);
> +		/*
> +		 * If we got EINTR because the process was killed, don't report
> +		 * it, because no error happened.
> +		 */
> +		if (!(fatal_signal_pending(current) && ret == -EINTR))
> +			pr_err("%s: Failed to register MMU notifier: %d\n",
> +			       __func__, ret);

Masking off error messages will make the message less useful and harder
to debug.

You could also change the log level, which might be more desirable for a
whole lot of the messages in here?

Thanks,
Liam