From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0399C3DA64 for ; Thu, 1 Aug 2024 07:35:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1D9A6B009B; Thu, 1 Aug 2024 03:35:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CD746B009C; Thu, 1 Aug 2024 03:35:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86E686B009E; Thu, 1 Aug 2024 03:35:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 698186B009B for ; Thu, 1 Aug 2024 03:35:32 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D9741C08A9 for ; Thu, 1 Aug 2024 07:35:31 +0000 (UTC) X-FDA: 82402866462.24.9A34C7A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 899A01C0012 for ; Thu, 1 Aug 2024 07:35:29 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Maz9sSwt; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722497701; a=rsa-sha256; cv=none; b=zBngHalEzPncTwF5B2JYRBw8E1hrzNT0/852wzOaU5q0lSzpJ52O0L+O32hyRoyDaY1Ugg FLvgX1xQuPRMVvhUInKKlBGIItyMv0gbniRh3vWBnEqtL5fv159ANdGF1sdJxl6viEJXeu kfAOCGIWqb5aHaT6CggpeWxeDIbseAg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Maz9sSwt; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722497701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1hYX0L6ZedJnEdtZfBvg3KBLdT3IMDSMx2Py5ZhR+5o=; b=UZVNTuH/9Qzhgc50be3poHd3Q+zGCPHy/udpUokHnDNb8Kc94aHNh1kmgmfUu3yQ9dYUw/ QSFipp00MrHXy4/aFhcYfxomIgn5oyFFhypG9OMCmx3yQTLnO34Qwc+l48ameRuiQbRART l43H424ToC2XRG7x384JOI2K1Gjlc5w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722497728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1hYX0L6ZedJnEdtZfBvg3KBLdT3IMDSMx2Py5ZhR+5o=; b=Maz9sSwt6VKkcyLQ/qaHzW6dzpc5s/hUIsjUyvQRr3ZymSMmfo/PmNGatocntItjt2mQlV uab8TbRLkcx5fo9WiF43yLNGa9k3Z5DJAfi0xtJlqx1ZF2+VzVet0Lc4WMilctk9L+KTL+ Al2aA5ViVGeHGWFiACJ3wU0CZ9lnuPs= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-PGTPiSRLNW2D0chfmR74ng-1; Thu, 01 Aug 2024 03:35:24 -0400 X-MC-Unique: PGTPiSRLNW2D0chfmR74ng-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2ef2907e21bso56935601fa.3 for ; Thu, 01 Aug 2024 00:35:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722497722; x=1723102522; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1hYX0L6ZedJnEdtZfBvg3KBLdT3IMDSMx2Py5ZhR+5o=; b=YGD/MDlwO2VUmc+nofNquQxWwWTqZxOgF6p0tt6gTGas3p+Tdmn8PdZPdCF5D5JUNa 37qM1BNvwOHnd8gkbkC7Ay9MtZda7SHCuy4ECwH2ZOKUfJ5dl0EfrNHeFzKkdaZKEAaL E5eebYcjfTzEffnLdD6rRLSZyDtEpVYXzSV5nvq81AuPvJLsMndV5UhlGL0mOVLr/rwH r8qs/XWMd6wCiB2vbU8xypcBIM1q8V/v9YISL7wTlnZmJ70q8x5liH8iN5rahqsIlFnZ SFtXxm+tLUjQ9t3y99upri/NcQbIf/vanLp9RhvssNLWIHZA3Lyu7SFotPPi5c7wFdjr QDSg== X-Forwarded-Encrypted: i=1; AJvYcCUP9R6wFw8JFdyKW65viVvaWAT97VFZVDolN65nUzZVvFfI41FgnRJdxgLKp3AQGjULsifWe2cOC06J6fkzir1rINw= X-Gm-Message-State: AOJu0YyDrynAoPYh1f7MbHgzihVlFbU38diNg40vSqloJfF4kYXE2ECT 94bBmDRdOGnLO8VIXumj0K+tzWaUMsHetfPrTvXdQYmkff3DGC3kH5KbNO0GJy89ZbuaB0J3hX2 plPH2dDYgKyzLs+gSJno/vXWBEaAFJmVzApelVfqJEeiw7V7p X-Received: by 2002:a05:651c:1037:b0:2ef:18b7:4408 with SMTP id 38308e7fff4ca-2f1530e8ae8mr11328581fa.5.1722497721975; Thu, 01 Aug 2024 00:35:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEX9rAQE8WF1+Fpjc4Z4kjegOzlas5pBC21l1Rd9Aor0bimSbLCGWJi3QQw6GOFDhKUY3rA6Q== X-Received: by 2002:a05:651c:1037:b0:2ef:18b7:4408 with SMTP id 38308e7fff4ca-2f1530e8ae8mr11328361fa.5.1722497721372; Thu, 01 Aug 2024 00:35:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282bb226b0sm46636415e9.46.2024.08.01.00.35.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 00:35:20 -0700 (PDT) Message-ID: <3898204d-83c7-4eb9-a4bc-90665b505704@redhat.com> Date: Thu, 1 Aug 2024 09:35:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/hugetlb: fix hugetlb vs. core-mm PT locking To: Michael Ellerman , Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, James Houghton , stable@vger.kernel.org, Oscar Salvador , Muchun Song , Baolin Wang , Christophe Leroy , Nicholas Piggin References: <20240731122103.382509-1-david@redhat.com> <2b0131cf-d066-44ba-96d9-a611448cbaf9@redhat.com> <871q39ov7x.fsf@mail.lhotse> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <871q39ov7x.fsf@mail.lhotse> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: emf1bth447ig94y587uuocuohf79n3ws X-Rspamd-Queue-Id: 899A01C0012 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722497729-272771 X-HE-Meta: U2FsdGVkX1/1tQKi2kuzmkT9awtBqGgBVaDYSWX21kV9mNUITk+8HnJ0ZA9jhbiu3rNI7J8k7x04HVofkGGGn6DKeZEPCLarOSRpZCsTRd8ZA/TITMpCfVs6BaHBFUtfW9iiNP1UdTHT9Ja87jWU9bm14I9PCa8LLUHBhi+CTFkBEJZy7vJXMNgPl+p3BzOnOoa52PQSpqiSpsgJM1TZ+0l4CZe5iaDtICariDr8HsBT8168MXtOA9rLacBJyd66ATPjuMHPF3zoFAuGnJhEeXX+9iKhQtPU3gHfD3RVg7GNgjmrBSKtS+n6pP1cdNrLnCEEcHl/ynBVhan/Y6q8PcX6MCHJ6OQrA74iCZwfUnZsUIY3u2phqMo2Tq5h34juHgmcMm2LCjJoTb+BVo+vX/4JxC+9V0k+enHwegxhwJsjef/ZOdTr/OBgCG+YIKpIz8kt6Hc9oLpoEloW/KDeVTNWyoxGvDeemVKWJke5TUX1LkwAyabqULqTHUf9WcsDaNpO4SVr07eroPt6Jtp+mz3M2yP6FC8SKM08BPLjNJFTaFu9tu3wZvpm7dcjDI0msFZJ7mdOmuwMfCRg+MpksiqblXPtYBtFymsgW8sgvOemFTdfCELslZSiXYwwlGKaNKkoDkWYDuPW+XVQz3vpkvH0Lhwaz3Mzs4Yw9P9GXrPswb6wbE6U/iMD197cHxFoQ4QHnHwly+GPKOD4R3MZ0FBddx+gDGBS80TcbmaBCR05bw14yQYRZTvBEAG+NDtJ449UYMd8WyUPUr0Y9QqC5dFGvkISIN17xuR1mDAIlFtU2rULF5yBi9tX3UCmL4dYWc9WsLRTFNjzVcNSJ96kJo0azfuGM4/lr73VERYJe9x6QH+2lHuD2cOlwIxo45Uf2vPN//KeJr+3FPo+1GkN2aLk++SMIx25T1EwPEf2W8dIk378TOe/Bc5M/Xb8i/CV2tt8EWfpSp4tkodRy5H d5Mp729b IYN6Q+Mol0Jj6BHfMPqa9vYATZCyuwqYsQR41xX9L+merqs7fhKfOipfCJpQ6NOe4jzr8oyc2YPjd+ocn7RwfWOlSEsSMhI7TME3XAIm9O7+Z9ccCHBW0GJWvIc2Xfda/mwDtB2JxBAj4avkpp6ulv6bEQ15bRLbMvgEQuAa9YQQIEOtvdQneS4HBlx1f55TzpRaogcVsZ91TbS4gd0xlROS9X81EXR9m2HT22eToTV315MtKvHJuKful1lmSKZkef8ld4fveP0T4fkTSHYDV3LuAudSgTAROE16y1JSE5xVAr5kAMfoMzvryanyEyI6B50o1ERrSE/3k6yi4uUIxqFO/Bcmg2HFtVhg0k8rZpCwpYZOwuvSnsC+FOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> pte_alloc_one() ends up calling pte_fragment_alloc(mm, 0). But there we always >> end up calling pagetable_alloc(, 0). >> >> And fragments are supposed to be <= a single page. >> >> Now I'm confused what's wrong here ... am I missing something obvious? >> >> CCing some powerpc folks. Is this some pte_t oddity? > > It will be because PTRS_PER_PTE is not a compile time constant :( Oh, sneaky! Thanks a bunch! > > $ git grep "define PTRS_PER_PTE" arch/powerpc/include/asm/book3s/64 > arch/powerpc/include/asm/book3s/64/pgtable.h:#define PTRS_PER_PTE (1 << PTE_INDEX_SIZE) > > $ git grep "define PTE_INDEX_SIZE" arch/powerpc/include/asm/book3s/64 > arch/powerpc/include/asm/book3s/64/pgtable.h:#define PTE_INDEX_SIZE __pte_index_size > > $ git grep __pte_index_size arch/powerpc/mm/pgtable_64.c > arch/powerpc/mm/pgtable_64.c:unsigned long __pte_index_size; > > Which is because the pseries/powernv (book3s64) kernel supports either > the HPT or Radix MMU at runtime, and they have different page table > geometry. > > If you change it to use MAX_PTRS_PER_PTE it should work (that's defined > for all arches). Yes, that should fly, thanks again! -- Cheers, David / dhildenb