From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46045C4332F for ; Fri, 3 Nov 2023 13:00:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D549C28001B; Fri, 3 Nov 2023 09:00:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D054A28000F; Fri, 3 Nov 2023 09:00:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7F9028001B; Fri, 3 Nov 2023 09:00:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AB52528000F for ; Fri, 3 Nov 2023 09:00:54 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8B987B539E for ; Fri, 3 Nov 2023 13:00:54 +0000 (UTC) X-FDA: 81416652828.05.2D63BA0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id F33DC180039 for ; Fri, 3 Nov 2023 13:00:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Iwr/wBGj"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699016452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o1BM5IVdx/zIlfdQnRWSMCxZ58YWny/OCvugL0oU/YQ=; b=PvQeJUT3wq8dTqeLMfO8B/YHBunweLLGxQDaXWVqaFizzqTwi4aVkAfjZhyfekxMIRa2uL /o6f7JeDU6ts51IV7vZjbsyeajsmVggZG15sF+cAXox2QJOgdifhWnKf1snA7h9yMSZix+ EVtyMPozsWsIdJ8S6ApCziNGiqFOVrw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Iwr/wBGj"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699016452; a=rsa-sha256; cv=none; b=N9fcYWlzLy6YPXN82bFzYY8RnPs7SyM7RBq2dN87LKyO6BDYLiiXucuHN3Ys08SUc5qirT 2p4M6u6XNuhK3UyQ2D/8NYt8wV7r+GJC3cIxOgg28pEt7fh3Wl9L9IF5MOcB43/LbFpP4z eMB/zWkYadGMVciafjsxr4A0svUBtYY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699016451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=o1BM5IVdx/zIlfdQnRWSMCxZ58YWny/OCvugL0oU/YQ=; b=Iwr/wBGjuybd5vveF0HoaUF4mfPmDMRG333DNCqgcuaW7A52RNPPxc0aiXUtA3dyq/V+9x pn+BLYVlySCB2WJu1NlT16b990r72FYqjR9QsEuLabzD7UhVakhVX67hwk529TTSJXWusL i9Y+0vQlvlCE0I3A0jhMN+DIAT6WMGs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-YYSVF0PKOBG-Bacmqyoh0A-1; Fri, 03 Nov 2023 09:00:49 -0400 X-MC-Unique: YYSVF0PKOBG-Bacmqyoh0A-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40837aa4a58so13655405e9.0 for ; Fri, 03 Nov 2023 06:00:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699016448; x=1699621248; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=o1BM5IVdx/zIlfdQnRWSMCxZ58YWny/OCvugL0oU/YQ=; b=JoolPxqxmsOYqkX5THK/Jb6Ol0Oh/cdZCUvSbUcEyQ/ln6o04zYpYp2gSAdUPqx3jX uWP4EO07pPieNZPFrZ5V02V2zQHv5s5qxuWrvJBu9DJfFIXSejMY+rl6loxEn8j9o18l 1auoIY/mqUUnM66i3HuAE+XIRw1X/o6f8oETPCUj8HDu+N69PaheGPtp9zs/Ao3BJb2r tlVghecd7u/AolPmgkY26/c+7XeOmNaR8N86XUoABpzQ0+IGOrTllFEoRu6ZdtqS/TSg mtF/pTNcVoycrYO6RwY3Pt6iWGIKsdv/y5m5f8aBq5bqcu0U1I9Ii+LUu69AYTaXkymm rdkA== X-Gm-Message-State: AOJu0Yycjfbkm7nh8BH1KDTpCdwWLgVPF1EIrk2iif3JrpVpLE8MBrFO JMIx99cQWgynI+QnXB/Dzo+hQVP7/IRf7D10uQ5qc4q0T5wl4tm5yZ/2bB4juFrtToR2Q4oT/J9 m/z24X6scnSw= X-Received: by 2002:a05:600c:3103:b0:407:3e94:bcca with SMTP id g3-20020a05600c310300b004073e94bccamr3308332wmo.1.1699016448390; Fri, 03 Nov 2023 06:00:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAykxIm6bwpaq29e3TYATQQiLzDOYI4Xh8bqnHUKgIvBnT2/LIC0KVtx75alsLuqxiMxigag== X-Received: by 2002:a05:600c:3103:b0:407:3e94:bcca with SMTP id g3-20020a05600c310300b004073e94bccamr3308242wmo.1.1699016447664; Fri, 03 Nov 2023 06:00:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:a600:bc48:cd31:d01f:f468? (p200300cbc70aa600bc48cd31d01ff468.dip0.t-ipconnect.de. [2003:cb:c70a:a600:bc48:cd31:d01f:f468]) by smtp.gmail.com with ESMTPSA id j5-20020adfe505000000b0031fd849e797sm1398010wrm.105.2023.11.03.06.00.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Nov 2023 06:00:47 -0700 (PDT) Message-ID: <3897f319-916f-4862-88d0-24db46c10b5b@redhat.com> Date: Fri, 3 Nov 2023 14:00:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built From: David Hildenbrand To: Peter Zijlstra Cc: John Hubbard , Linus Torvalds , Andrew Morton , Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Muhammad Usama Anjum , Jonathan Corbet , linux-doc@vger.kernel.org References: <20230606071637.267103-1-jhubbard@nvidia.com> <20230606071637.267103-12-jhubbard@nvidia.com> <20231103121652.GA6217@noisy.programming.kicks-ass.net> <20231103124606.GB8262@noisy.programming.kicks-ass.net> <15ff806d-59ab-46ab-8891-05ab917a1528@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <15ff806d-59ab-46ab-8891-05ab917a1528@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F33DC180039 X-Stat-Signature: eearfg7xc174a4uw5ieguoesyhhyux8h X-HE-Tag: 1699016451-183868 X-HE-Meta: U2FsdGVkX1/USVuxvUVExXgtJUNKAR2txqXswiSBYTtHQ0RAv4AkkpsW3pqhv52crHkAmmAeCVzs4QWKJ1mmztOzG0HtgYzLOuhzfOY6VOhiL2z43xhIog92uosbilHqmaktYOgyP8hvBozt2ueiusxl1Qjxgcb3gGRUoSYpW7FhPQw+Lnl0ZwmNFNOBZsEbkdw0m3cXZAaXZTUiG9QMqDjUT6RE2UXvcYBdFrdMhatBxPT4Vu/P4I6geNQZRZotQUFcWvfxOL5LBAh/Pa40isCs0/iZ+SzyAbNmHLN2r0MiHDxLAGRGt1SH/iPmsE6ydjFVcc1eCWy9lTkW8agg7hAHjHEhhbJGeSJwazLZ91SU4/coICWNOqzmi2eWkEthDqWaM6NT/UBVPwh7P2ZvnpNB/8Ksl2lL5HftLV5Khxv6exXXOUJmqbVJIz6TNjPIia76UYcwnJslELNk36ctE8YTyaHMQgyaigdl4hBongU4l0EkBPY7HPUy/d98psXfzTLqzT9H6l+mFfbVbkjxO7Em1gAsN700nhXydxqGX5IoGRNN8SQ2j2BTc4SnDQC1+wmqhCCr0GCQ8lfTJe5r1ayFPKkFN83ov1u3paWGdqrB6n3JvcT1Tz0PrauPNFojHMVQH0/lhMX/He8GDXdJOHoJhmeuUzDRzdmopZEUZsqZJq75QElvmxwmaUM4Lqs2NU9wXpElwei8oaHsXB3/j+ToWbdSOcO56EYnmnQGwDrtURcOfWyzts/2pXhvHnahIeeMUX2wnIxoF+n7qw2gv274zkK7sChipn0LuAb5cdJwMmfD5XDL9ubSoBTEQsFbIblx3aSoqr/mM9tbhtumWk6RLTNBGS9QqUBgPE7JuRYoJ5OHPRW9YF7cZfWxLcbEz2KzVhFdQvmFQ2ti0HQ5/7iundlXwxS3BrR1J/V7VzIzVD01gnGGXkT7QrUgN9t9/enjITWae5rMNFvPBzY P3PoHMw7 impptTtRArjH3aeccty4RVtjuovsJLBJDjT3SEGPRR5MMsKdH9JLhqdVdaeuIP54NCCwCp1Nj2RVj0r1vDqQVkS7MMtow3uJ1bTX6l6LcGf67q78v9jJJ+NRMlUgBahDxhOsPgVP7wv4YXZ0zX3+bq/fZTam3yA32J5UBJ4/6JiGIhaK7dFdfHIl/QZi+lKDfW6fWNRjM0oA5sEfzrJ2GZNN9oJSqIfDqArbOL4X5WG4rvuLrbJg65JVDFYRWduPckFhrvQQasolBGth808zjxwEJoZhPeYn2x3Twvh7Y8n13ui3+OWHB0Xq0MOttlZf2uivVeW6ayHHl/4g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.11.23 13:59, David Hildenbrand wrote: > On 03.11.23 13:46, Peter Zijlstra wrote: >> On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: >>> On 03.11.23 13:16, Peter Zijlstra wrote: >>>> On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: >>>>> As per a discussion with Muhammad Usama Anjum [1], the following is how >>>>> one is supposed to build selftests: >>>>> >>>>> make headers && make -C tools/testing/selftests/mm >>>>> >>>>> Change the selftest build system's lib.mk to fail out with a helpful >>>>> message if that prerequisite "make headers" has not been done yet. >>>>> >>>> >>>> NAK NAK NAK >>>> >>>> This now means I can no longer run selftests, I thank you very much! :-/ >>>> >>>> root@spr:/usr/src/linux-2.6# make O=defconfig-build/ -j64 >>>> make[1]: Entering directory '/usr/src/linux-2.6/defconfig-build' >>>> *** >>>> *** The source tree is not clean, please run 'make mrproper' >>>> *** in /usr/src/linux-2.6 >>>> >>>> >>>> I've always done: >>>> >>>> cd tools/testing/selftests/x86; make >>>> >>>> and that has always worked >>>> >>>> Now I can't bloody well build *any* selftest or risk not being able to >>>> do builds. >>> >>> This change landed in 6.5, no? And 6.6 was just released. Just curious why >>> you notice that now. >> >> Dunno, last time I edited the selftests and needed to recompile was a >> few weeks ago. > > Okay. the question is if your workflow can be easily adjusted, or if we > can improve that header handling as a whole. > > The problem I had with this recently: just because we did a "make > headers" once in a git tree doesn't mean that it is still up-to-date. > > So once some selftest changes showed up that require newer headers, > building the selftests again fails without a hint that another round of > "make headers" would be required. To clarify: maybe some kind of a warning would be better, ideally that the headers might be outdated and that another "make headers" would be required in case there are any build errors. -- Cheers, David / dhildenb