From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 570BEC36002 for ; Wed, 9 Apr 2025 08:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 547B828004E; Wed, 9 Apr 2025 04:02:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F64B280049; Wed, 9 Apr 2025 04:02:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40C8928004E; Wed, 9 Apr 2025 04:02:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2217A280049 for ; Wed, 9 Apr 2025 04:02:46 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 38B3E82064 for ; Wed, 9 Apr 2025 08:02:47 +0000 (UTC) X-FDA: 83313763974.27.1DB6036 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf14.hostedemail.com (Postfix) with ESMTP id A98D1100009 for ; Wed, 9 Apr 2025 08:02:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744185765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y3L7IaryHj+N0DZRYmeVKdRagQ0CYfr/ncVKfAiC9bs=; b=w7g2/Rb5asSKALYbls3YwRFg/EZyL91ilf50dzLSNHmf+6DLqpo2osi7k/IB8Um00FKtCV cvxFtX1qj30PiNxxHBNJj+9bSixc2kh/BqAG/w1w9Xqpu7sFIJcihnTVHCnhcHkR0Z5Ifg 0hrrhMAh1S8T4RRh9FHxvk6b5yhrLg4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744185765; a=rsa-sha256; cv=none; b=AXCzoYx54AMdH1Z02YwbGBxaJpdtuRWZzi6jNcSOVL6MYKGRLmO4DDqBq/emsNg8Y1EeI4 i5OeLLWOZCV/IWvgtCU6F+ENEYpWcABkMK+v9WTjfcickhYFfmEg2xPv9d7GgyW8ZCiciO 65lM09cfxuEtHxdQH94dXF6F9xAyu3c= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4ZXb065Mkrz1f1sB; Wed, 9 Apr 2025 15:57:42 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 75A7D1A0188; Wed, 9 Apr 2025 16:02:40 +0800 (CST) Received: from [10.67.120.129] (10.67.120.129) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 9 Apr 2025 16:02:40 +0800 Message-ID: <38964e68-ac20-4595-b41d-8adc83ae6ba0@huawei.com> Date: Wed, 9 Apr 2025 16:02:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: page_alloc: speed up fallbacks in rmqueue_bulk() To: Johannes Weiner , Andrew Morton CC: Vlastimil Babka , Brendan Jackman , Mel Gorman , Carlos Song , , , kernel test robot , References: <20250407180154.63348-1-hannes@cmpxchg.org> Content-Language: en-US From: Yunsheng Lin In-Reply-To: <20250407180154.63348-1-hannes@cmpxchg.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.129] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspamd-Server: rspam01 X-Stat-Signature: 3kptx79j3nfiufyaxqc9dtbyphfc5tka X-Rspam-User: X-Rspamd-Queue-Id: A98D1100009 X-HE-Tag: 1744185764-966726 X-HE-Meta: U2FsdGVkX1+b92tKCVlW5rFmyva1Z3dy3cth98D2oY2D4ztCLU54kjH/KHP2iIgOBFHsriNmJpVfU7YSjf25SFwHw9OnDpqCmKIekmNwLrjdYFBZPVb00tgUECbsrZibfCrs8tSBEw8zov4BTT9L+xW5RsqG8pppq+kao8zADiokv48ZlVFIHe9hUWx2JBA6/ctVVEFQhym0ub0RoS/qvc/ibqgTmUY7on70PnMDcElJpGul8TacLsMx4u/f/+P35aiHnhGzQDeRCWKwHRCR6kPTMqNLU0ubU57aAeA/QdyCnogQzRL3HNCttJiUBYYl4r2Q8NwFGRVYrTzNDWq6IPzyUMLGjq+uKf/M8RyIAzFCehAfILAwU5syJ0zCKJLrr+DXT0d6Hjiujj1meKN5dRbZ0w910yNg0fwupR6K5/sdp8UUofKfMbD6JKw+gjZ7DkKSuz36UfPKhbh/RBnxeBJHVy6DIdtgcsyzuj6m7FpFwFSg6Pv4GvIHZ3wzr37QjRdmQaKwZcyw53Vt1PKOlLyFv97QB+xN0LFgMN+2qTV3AdOaUwbN1pAMXqJkCDK8D8HywcvONu5Cq781ZKGoG/xcgm5Yw5bEhZtZiEi/4jcKCHnXSDVlloOQjC4kwmEv0yM2QXNfueWBVPkroaGZdD2jIXOOzBW3X/YqzeYqhV/yDB4WBCCRwGVpabJsbjb3DtqqZgozIxDyOYN/EzhHsP7F0RgZu22y4QiOSfJ9osV+4uvchdi6q/9swzeTjW7iqtoK6UaIha7FoeNrWqlQYf6uuvraSUlyoXVgcPeP0yMGWJ/UiUqz+k/oEoYK3HxYIQi7QCGC0cpMJZeFohog4ghn32q8KwPXRHK4S2jmPCs7d69NaTJyUwecoZy4WUfuE4us+4NUdYV0mv3K1hM1Zle221W0N6y7EfqVm8kEq/Pclca3xc3Cmi4hIrnU9gIQvHppZ0juFGBFy9Z+Prq 9V6yfwkg Skrk1jWQGKKZWx/vHcUMaOzsCcYJKa2g1Zn0XT/ndB1TomHPsEJAGXRWYdYgRo6OSD/EUWOILp2HyrtjFiwnGDmgxLfUx50RR1v9jBvpOxa+/ARzI1voaYyX7buxOKsfnyMbyUHshp/ToTZfstvCShoa/+QTp2H20AfsLdgLWomeJU4UzWFMmKI6eedYkYrJaLpKs5AxGyRnAXjmdb9BbgWbgBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/4/8 2:01, Johannes Weiner wrote: ... > > @@ -2934,6 +2981,7 @@ struct page *rmqueue_buddy(struct zone *preferred_zone, struct zone *zone, > { > struct page *page; > unsigned long flags; > + enum rmqueue_mode rmqm = RMQUEUE_NORMAL; > > do { > page = NULL; > @@ -2945,7 +2993,7 @@ struct page *rmqueue_buddy(struct zone *preferred_zone, struct zone *zone, > if (alloc_flags & ALLOC_HIGHATOMIC) > page = __rmqueue_smallest(zone, order, MIGRATE_HIGHATOMIC); > if (!page) { > - page = __rmqueue(zone, order, migratetype, alloc_flags); > + page = __rmqueue(zone, order, migratetype, alloc_flags, &rmqm); > > /* > * If the allocation fails, allow OOM handling and It was not in the diff, but it seems the zone->lock is held inside the do..while loop, doesn't it mean that the freelists are subject to outside changes and rmqm is stale?