From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3166EC47DB3 for ; Tue, 30 Jan 2024 03:11:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9A5F8D0003; Mon, 29 Jan 2024 22:11:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4A278D0001; Mon, 29 Jan 2024 22:11:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A38D48D0003; Mon, 29 Jan 2024 22:11:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9283F8D0001 for ; Mon, 29 Jan 2024 22:11:30 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 697941C0E99 for ; Tue, 30 Jan 2024 03:11:30 +0000 (UTC) X-FDA: 81734501940.28.AAEE58F Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf09.hostedemail.com (Postfix) with ESMTP id A78E9140020 for ; Tue, 30 Jan 2024 03:11:28 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RtoH3X8q; spf=pass (imf09.hostedemail.com: domain of rientjes@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706584288; a=rsa-sha256; cv=none; b=cmZU3+v+WjYj6nsnWl8TxnIJ3Olx7giKn/USvQOo9/MTs/DhuDcqkYHesy6EPNYXKSIBxi MVtjaIqOCbi8C0LHjTsWltW4ZyZTG6YfIIMULReivb4pmkWipXUziNP2y/MxmdRF5akdUE 7Dsua1JEI56o+ny5WN1Z1W11lx/JRTo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RtoH3X8q; spf=pass (imf09.hostedemail.com: domain of rientjes@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706584288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H2YWDa1CdHQ6mQIhukUOsTsYdhGWB7ZlEzy7qkLsrzM=; b=7C+6gzIj8t54YV9Xtrj5R81+QJo8iD88w7rDJWIo3VhgZOWjswWLcD2wEy82s/Wx7avQP+ bOHvZyZkceqpd0aScVVlMD4mQe3/LPK5fXisLKvulSosCtf9yP16gmwVTI+/TSNVDZhC4K TTkD9xrew5GE6xkP62pie4G7k3AXbIY= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d8d08f9454so57835ad.1 for ; Mon, 29 Jan 2024 19:11:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706584287; x=1707189087; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=H2YWDa1CdHQ6mQIhukUOsTsYdhGWB7ZlEzy7qkLsrzM=; b=RtoH3X8qUw6v1gmV6m6wQl4KgHiWLcMIBBd5oAZ181xx/uCOZKG6x/tmL+/8Ul6Baz yE8dQ4zhFt/Wx1YaijL3FXTz4J/K4TUUTn6FKyGYVOAWDs9JZcWqoxM0cK/NkcCsAs5V NNzVAdmJ1A5cWoiH/jRlHkFZB6DZ23/6fHdoy2jZav15avXUshTshPSMSJ+dlK8ROki5 OJNlLrTWh7NDPsoD6fiANyb7xqMQ3XUOgsHyGhNtIovVWV2CrLc7GNOOGENorRQPtCgF voZOuk+v0hLnNt4FnRLHN2LcDKe/h6JJbf0q878mw4tEw+KDj6hFh+O+1Okadqnk1oJU UlrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706584287; x=1707189087; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H2YWDa1CdHQ6mQIhukUOsTsYdhGWB7ZlEzy7qkLsrzM=; b=oT+yxtMRqgc394nbD93aGPJ9n14uG30DSf9FpSKmUx9ApM5jS8eQSFvDyuIukfUIdx FatUmx4fx13vlF4doZuTJhnCoAEYsPBLgE4MosWVCqjYDVXTjd/+wycW5aVVF/Q4fCtQ YvLw5Td0ea+okL7ap5BrA7Mn+M2VcK10ukEKm1mn3EV08eO9CxIK6zIMHC/rDaBXokAy DVFhfG4coZPneCKT2O+ydY1CkRmopjPF5quL7SaPpLpvKChdK6pG2kRdWGx+tmVAKR+I N1h1CW/UEt4lkwwIzgUexdkMJqU366JyryKCGCcua59rjck24LPkSoLQ6VzsBQTeYVrC LNeQ== X-Gm-Message-State: AOJu0YwzQW8KSOhwzyL2qjbbwTTCkEykgfw6cTLWwbQsGDjotNNaJYKv Ksw/vqFSwVHvyH30RvASQpkfKBIVQzZgSZ/62Lb+uQvHsHh50bYfb7cKR3bLgg== X-Google-Smtp-Source: AGHT+IG0XRJFTtE6va2vH6K0aa4X9yGtlYIGybzCZtc3f1ObkeiUulYAsH2aEVwdSjDz8tqzKm7g9g== X-Received: by 2002:a17:903:234b:b0:1d6:ebf1:f8cf with SMTP id c11-20020a170903234b00b001d6ebf1f8cfmr138308plh.0.1706584287284; Mon, 29 Jan 2024 19:11:27 -0800 (PST) Received: from [2620:0:1008:15:bf6f:6465:5fd1:5897] ([2620:0:1008:15:bf6f:6465:5fd1:5897]) by smtp.gmail.com with ESMTPSA id y13-20020a170902b48d00b001d74dd065e5sm6031212plr.136.2024.01.29.19.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 19:11:26 -0800 (PST) Date: Mon, 29 Jan 2024 19:11:23 -0800 (PST) From: David Rientjes To: Zheng Yejian cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: remove parameter 'flags' in create_kmalloc_caches() In-Reply-To: <20240130014107.1262373-1-zhengyejian1@huawei.com> Message-ID: <388197b3-6193-96ce-8e8d-261c8481eff3@google.com> References: <20240130014107.1262373-1-zhengyejian1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A78E9140020 X-Stat-Signature: h1eu6rd6e9w7s5xuxj4ihk6z5fws4nxy X-Rspam-User: X-HE-Tag: 1706584288-783216 X-HE-Meta: U2FsdGVkX1+EAmDjgXpEABfh+XNW9pWab/1fXcqbfHzgUUAFJd54JvJHxYM+XJMLDz5wBPR4HAT9j+ASDhfqKDu1FNaHvgwNM2+aquBx03+n5P+LXe6aLju/BT9i375MUobELnZhMya42O1rhu1DnLFO9ab6VRX0hE64ypNlMpoI+dtcq3DP4uRLDqpId0egKRYj49NKHtWpZ5a7oBQ9A8x6IJ9zl1em9tXDguobLnrJ1g+BsGvnwV/j17peak/ywLZHHqzXgDFGEBgUP/hE6G7McIcoiiUlUeDYEeZzq5DeBSgfm061esfNQxKPKBmCmLFhth5Pg27dUngxTU3TMrRR+OH2FHMTXjHcTgU7G7zpI5z/yXlmGyY1XvwSS6igKsaRS9SWhpMRtMi9ZdaLx8Bfx159C24IVQFGDgFWCvopabCAP4ptGjYUhAH6eSUAsPdh/ZUwUu/U1N54dxY5G96Hq15Brn270M4dQwhabSo4opFuZKO8DAiGz14ecYdYlq/SDy3hJ6CxaxlSQLcr8pANdcX+Mf96H5wO9rYkuBqqClqy5y00c86OkmXj9eJ6A4Ht675/8K/b34/yDdTutN27/y/xC1jkThmSeJdu4LtiLc5xQ+7lTx8uFYgPn+/FS1lW9l6BQRCq7IlqCatpBzqjTINLPsKBWrFyRohL4R0Gyx0IagunxI1bKBzKdpy8rUwyIFXEHMFZAo9X3nfe5y36uEKHFsHjEOIQPQ9Dob8TMLOfGx67MhSh2+/p8caZlvGzejCSNKc+FZUocGTAIAbHtk5ZIvzkmpSmVDDJiiSaAgbM8CLxGTeD2iHvE20ja4QKIlOUlVlz1go07T/bm8Cno6meXSblyt5OS7QrX+btCYVuPO3+nG7ZdQjyAwNd6R5wr2WzX0KhKjE3uAseJPh71kpJxTMlW1rsC9zq+TCHa3kzulY49ECM6xs97lrD8J6Md48WE/mUGzr112s uLE7/b74 nKonR7AGY5I+Dl6o35Kk5zmSDsO0QeYQc3KcGII6RS3c8CpafeouFA+0X+/Qv5b7GZFPJp+1Cm5IVdSCxNKchKdJaiVDLAOV1+mAUFnSS8a3jZAxkjWDTAZOQGDzTuM/h+bbZE9+qvPWhUlLgfbaCRj/QF4oQ+d2kgiymJLEo6apPMNSAsAUj/7DWVGQBI152ADJz8+Z9xY7wAqdy/TruCJTxOjUNaMFqKXPQuG2c+MtAOB5pFPkAXLlW1duuDD9/YgW52L9joHYf1lOvCFGTkgHM7lH+Lit6cDobqP2V1YEpZTEFkUlCefM4UoT+gfWUwpyjIroXe/cLScOK2YZSAnzE2OBQyyM4bvDYyOXifpi71KuR9SDqy47z5sAaZZIiDeyLQ2lzRiwLEF95JExF+5fYKKNfUVK36cWhfSmbfYlqTG+dwHhXAXaeVR4SPPTb5z7sataS0AmyKcVxAzbdPHWPXbRdUq8HAKoiFRgke5KK5DteL0dgcBbcVBwb0LPYhHvd+G8B9ed0ASA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000073, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 30 Jan 2024, Zheng Yejian wrote: > After commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"), > parameter 'flags' is only passed as 0 in create_kmalloc_caches(), and > then it is only passed to new_kmalloc_cache(). > > So we can change parameter 'flags' to be a local variable with > initial value 0 in new_kmalloc_cache() and remove parameter 'flags' > in create_kmalloc_caches(). Also make new_kmalloc_cache() static > due to it is only used in mm/slab_common.c. > > Signed-off-by: Zheng Yejian Acked-by: David Rientjes