From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 902A0C4743C for ; Mon, 21 Jun 2021 16:01:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20B46610EA for ; Mon, 21 Jun 2021 16:01:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20B46610EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 549EE6B0072; Mon, 21 Jun 2021 12:01:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F9CE6B0073; Mon, 21 Jun 2021 12:01:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 374166B0074; Mon, 21 Jun 2021 12:01:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id 017EF6B0072 for ; Mon, 21 Jun 2021 12:01:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 77D65180ACF84 for ; Mon, 21 Jun 2021 16:01:25 +0000 (UTC) X-FDA: 78278195730.11.38290A3 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf09.hostedemail.com (Postfix) with ESMTP id A585360024A9 for ; Mon, 21 Jun 2021 16:01:20 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id s6so19634701edu.10 for ; Mon, 21 Jun 2021 09:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZJINl3ujyElFF79o2Vp6G7gTRrWKDKDmi7XTzlrNQuo=; b=fux+ZPc4AJRwDv70FuZ0/eTKAWRBdJbvBe12avwC7WTFmYx9RXoAqtQU3b92nmYgrr SAdaZx9qV85GN85nhBVX+bXhD8cjIE1c7yZXOCdtFgC64PdrqkdrHZ4s9Pa9uUNzSSgI V0ng5OzjTjNJyHr5MhxRopH7B3RZ+atucD4TE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZJINl3ujyElFF79o2Vp6G7gTRrWKDKDmi7XTzlrNQuo=; b=Riss08JlNYITVfdy4oj/YLP02rQoYbjnZJPsScinreOW/2XSocCuq5X1alaILiJ7t+ xOxiT6kUM0dkId4YZQsTBjGegvTUPXYP+y2kk8YZi5wOWsHLskv28VOUVCC751UJXzpb zgS+pdbIYpoRYguQpByiu1p/YtbebSPyGp3U382DaMD+YZpdaXkl9K0rKfJnaHJ1UQR2 1k5uZKNw6R6pAiXbiUWSR2A1pHVPJKMWv44EO4VVgNbN6DDVecY2mqVA3RGrYoRNd3XW vt0cbtU1ARaDLAbJq5pNOgoys9jg6Vs3/zWsaSPFvQwcq/SHRoKB6Gbg2Xu7+re/Jj18 6hZg== X-Gm-Message-State: AOAM533n5Hrk9Cqh5IXThCNvedekzPEm3xc/9rwDNhks+DpjbajYGjXl sm/4QIAi9AsvpQLNA7Ty3crEOQ== X-Google-Smtp-Source: ABdhPJwIgu6wJ+DzjSb7rdWV8o1Xs362qySHLk/qlWURN5a6En6I3SxbPcwZ4LzhQNQ5OVfTUT2cuQ== X-Received: by 2002:a05:6402:1911:: with SMTP id e17mr22488554edz.62.1624291279115; Mon, 21 Jun 2021 09:01:19 -0700 (PDT) Received: from [192.168.1.149] ([80.208.64.110]) by smtp.gmail.com with ESMTPSA id h16sm10666590edb.23.2021.06.21.09.01.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 09:01:18 -0700 (PDT) Subject: Re: [PATCH] mm/page_alloc: __alloc_pages_bulk(): do bounds check before accessing array To: Mel Gorman Cc: Andrew Morton , Alexander Lobakin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210507064504.1712559-1-linux@rasmusvillemoes.dk> <20210507102634.GD9524@techsingularity.net> From: Rasmus Villemoes Message-ID: <387ca68d-7c59-b316-7d95-cf13a3b26770@rasmusvillemoes.dk> Date: Mon, 21 Jun 2021 18:01:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210507102634.GD9524@techsingularity.net> Content-Type: text/plain; charset=iso-8859-15 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A585360024A9 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=fux+ZPc4; spf=pass (imf09.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.208.48 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk; dmarc=none X-Stat-Signature: yp36paind1r4w7y6fwduazpmobgkr1s7 X-HE-Tag: 1624291280-501068 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/05/2021 12.26, Mel Gorman wrote: > On Fri, May 07, 2021 at 08:45:03AM +0200, Rasmus Villemoes wrote: >> In the event that somebody would call this with an already fully >> populated page_array, the last loop iteration would do an access >> beyond the end of page_array. >> >> It's of course extremely unlikely that would ever be done, but this >> triggers my internal static analyzer. Also, if it really is not >> supposed to be invoked this way (i.e., with no NULL entries in >> page_array), the nr_populated> instead. >> >> Fixes: 0f87d9d30f21 (mm/page_alloc: add an array-based interface to the bulk page allocator) >> Signed-off-by: Rasmus Villemoes > > Acked-by: Mel Gorman > Andrew, will you get this to Linus before 5.13 is released? I got a mail on May 9 that it had been added to your queue, but I don't see it in master yet. Rasmus