From: Qu Wenruo <wqu@suse.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-btrfs@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH v3 1/3] btrfs: use bdev_rw_virt() to read and scratch the disk super block
Date: Sat, 10 Jan 2026 16:32:52 +1030 [thread overview]
Message-ID: <38777db8-f90b-4437-988d-558231747750@suse.com> (raw)
In-Reply-To: <aWHqFJfzD9QeaKkS@casper.infradead.org>
在 2026/1/10 16:26, Matthew Wilcox 写道:
> On Sat, Jan 10, 2026 at 02:26:19PM +1030, Qu Wenruo wrote:
>> Furthermore read_cache_page*() can race with device block size setting,
>> thus requires extra locking.
>
> What? There's supposed to be sufficient locking to prevent this.
> Is there a bug report I can look at?
The comment of read_cache_page_gfp() already mentions that invalidate
lock is required, but we didn't hold inside btrfs, and it's already
fixed now, nothing to be worried from mm side:
https://lore.kernel.org/linux-btrfs/tencent_A63C4B6C74A576F566AA3C0B37CE96AC3609@qq.com/
This report and fix just reminds me to finally push the series to get
rid of read_cache_page_gfp() completely.
Thanks,
Qu
next prev parent reply other threads:[~2026-01-10 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-10 3:56 [PATCH v3 0/3] btrfs: only use bdev's page cache for super block writeback Qu Wenruo
2026-01-10 3:56 ` [PATCH v3 1/3] btrfs: use bdev_rw_virt() to read and scratch the disk super block Qu Wenruo
2026-01-10 5:56 ` Matthew Wilcox
2026-01-10 6:02 ` Qu Wenruo [this message]
2026-01-10 3:56 ` [PATCH v3 2/3] btrfs: minor improvement on super block writeback Qu Wenruo
2026-01-10 3:56 ` [PATCH v3 3/3] mm/filemap: remove read_cache_page_gfp() Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38777db8-f90b-4437-988d-558231747750@suse.com \
--to=wqu@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox