From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48660C433F5 for ; Fri, 18 Mar 2022 11:59:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E6BF8D0002; Fri, 18 Mar 2022 07:59:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9953A8D0001; Fri, 18 Mar 2022 07:59:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 841508D0002; Fri, 18 Mar 2022 07:59:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 707E18D0001 for ; Fri, 18 Mar 2022 07:59:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 13E6318274D25 for ; Fri, 18 Mar 2022 11:59:25 +0000 (UTC) X-FDA: 79257361890.22.1D830A3 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf31.hostedemail.com (Postfix) with ESMTP id A861620010 for ; Fri, 18 Mar 2022 11:59:24 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id u16so10421288wru.4 for ; Fri, 18 Mar 2022 04:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod-ie.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=XwzrvbL45Vf+JuYXVwm3nASREkeXG8VsC4OidM+IMsI=; b=tqS8g2hFS1AEIkU/+muItJiblvMDli1yyGog73Yl/v9bCh8cPAFB3ih2KKtM34q/pX ifFcgnxt4pL01uYHSdth9GdvSS4ndp87HScV2Ib/H/VI/+PJt9xKqleM6Ei5YBNFwvMm yuBX0Nx+nFg8SyR/FllbbwMnHSS7brWkfTlnToKmluiCXXJs+H0kAWurhpIiip1fSphO YwAnpKNcaOKeGZH73/aNTTkqsDrskoDI/iqTdnBtj9Tmuf13Z12NADbkK6dRejeZRFrF YXgfSzO7FivadiXpnH+AXARLBqpUPjf1dqaBQD+Fzm2t1w5CFK0HGydKuFTMeryRNucZ PLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XwzrvbL45Vf+JuYXVwm3nASREkeXG8VsC4OidM+IMsI=; b=ze5NR3YoDEr4YUwZ+AcmdbchWCbODxXG+4MXVt9E97Q3l5bwKtqmFhiQGjgr156ehn HcNHaAJxvnHqN/jEND9WuMdutNILmv9p+qTizqzRxGESZUbf0aphsvW5bOxNVQ5S9yqF z9uusmpepEeJG5BCxoHfnR03P/Wk7IiHY6NR+ZOwCnlxaKdGPXq4SyX5yE85R6OVDsx2 5CdC4GopKY0skkvsB20jvTaOe3EKOoB+Y3YAQyIibFwKMVudhdB3OmG25txEwk1AZopk qFOzusN1GN/MHyVZxv8kvqxfQosTEPC4iUtObeM4VfwUGA1pcNeS94PeSASbnR3PIwx3 OqHg== X-Gm-Message-State: AOAM5314fdUYgIEAXqDDHW9wBa6xEhE2IcGymtIlcPPDOReE4vhq6sH1 i6+82AcKhLgbLFdRieXjoJnI0g== X-Google-Smtp-Source: ABdhPJyNDQtCDLVSEH87DqdIJ+2/IHuLdqtZidZabUENNmeh58r9GxU2vKu3UXKY/J+fcP72+KT4zA== X-Received: by 2002:adf:f747:0:b0:203:ded4:dbd with SMTP id z7-20020adff747000000b00203ded40dbdmr7918109wrp.343.1647604763282; Fri, 18 Mar 2022 04:59:23 -0700 (PDT) Received: from [192.168.2.222] ([109.76.4.19]) by smtp.gmail.com with ESMTPSA id e9-20020a5d6d09000000b00203ecdca5b7sm3944901wrq.33.2022.03.18.04.59.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 04:59:22 -0700 (PDT) Message-ID: <3877078c-0797-7742-bd0b-240d1506b4e8@conchuod.ie> Date: Fri, 18 Mar 2022 11:59:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [linux-next:master 7918/13392] drivers/soc/microchip/mpfs-sys-controller.c:73:1-6: WARNING: invalid free of devm_ allocated data Content-Language: en-US To: Arnd Bergmann , Nicolas Ferre Cc: Conor Dooley , kbuild test robot , kbuild-all@lists.01.org, Linux-MM References: <202203180259.lgIylRZV-lkp@intel.com> <20220317211734.1340281-1-mail@conchuod.ie> From: Conor Dooley In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A861620010 X-Stat-Signature: d791dwjce7iuau6mzrtcchpqydaqecw5 X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=conchuod-ie.20210112.gappssmtp.com header.s=20210112 header.b=tqS8g2hF; spf=pass (imf31.hostedemail.com: domain of mail@conchuod.ie designates 209.85.221.49 as permitted sender) smtp.mailfrom=mail@conchuod.ie; dmarc=pass (policy=quarantine) header.from=conchuod.ie X-HE-Tag: 1647604764-560836 X-Bogosity: Ham, tests=bogofilter, spamicity=0.074456, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18/03/2022 11:02, Arnd Bergmann wrote: > On Fri, Mar 18, 2022 at 10:43 AM Nicolas Ferre > wrote: > >> Is there a drawback to this approach in the sense that it can trigger >> other test robots? >> >> This way, we won't have to disturb Arnd as I believe that his branches >> are all ready to be sent to Linus after this week-end. Additional >> benefit, you don't have to change your plans and enjoy St Patrick >> week-end ;-). > > I don't mind taking last minute fixes for buggy patches that I have queued > up, that seems better than sending the wrong code first and fixing it up > later. I would fix it myself, but I don't immediately see what the > correct fix it. > Do we just remove the kfree(), or does that conflict with the lifetime rules > in case we unbind the driver before the put() callback is called? I was just going to remove the kfree, but I don't think that's right. I'll switch it back to using kzalloc & leave the kfree. I'll send a patch later today. Thanks, Conor.