From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Israel Batista <linux@israelbatista.dev.br>
Cc: Omar Sandoval <osandov@osandov.com>,
David Hildenbrand <david@redhat.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-debuggers@vger.kernel.org
Subject: Re: [PATCH] mm: Convert memory block states (MEM_*) macros to enum
Date: Tue, 28 Oct 2025 16:34:38 +0000 [thread overview]
Message-ID: <3873b85d-a8c8-472b-82e1-2751c6fef3b0@lucifer.local> (raw)
In-Reply-To: <aaff172e-8fdd-4ff3-8161-1c7afb1f3e64@israelbatista.dev.br>
On Mon, Oct 27, 2025 at 11:53:57PM +0000, Israel Batista wrote:
>
>
> On 10/27/25 16:46, Lorenzo Stoakes wrote:
>
> >
> > So why are we naming the type... does drgn require it?
> >
>
> It doesn't need to be named, but as David pointed out, we could find
> where these values are being used and replace the type with the proper
> enum. I quickly grepped the codebase and it seems doable, I'm probably
> adding these changes to the next version of this patch since there are
> some things to fix anyway.
I mean we're getting a little out of scope here but fine, if these are not
in fact used as flags, I don't mind, just remove the silly 1 << x values
while you do it.
next prev parent reply other threads:[~2025-10-28 16:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 16:22 Israel Batista
2025-10-27 9:29 ` David Hildenbrand
2025-10-27 18:15 ` Omar Sandoval
2025-10-27 19:16 ` David Hildenbrand
2025-10-27 19:46 ` Lorenzo Stoakes
2025-10-27 23:34 ` Omar Sandoval
2025-10-28 16:06 ` David Hildenbrand
2025-10-28 16:33 ` Lorenzo Stoakes
2025-10-28 17:40 ` Omar Sandoval
2025-10-27 23:53 ` Israel Batista
2025-10-28 16:34 ` Lorenzo Stoakes [this message]
2025-10-28 19:06 ` Israel Batista
2025-10-28 19:13 ` Lorenzo Stoakes
2025-10-27 18:18 ` Omar Sandoval
2025-10-27 19:17 ` David Hildenbrand
2025-10-27 23:41 ` Israel Batista
2025-10-28 6:51 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3873b85d-a8c8-472b-82e1-2751c6fef3b0@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-debuggers@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@israelbatista.dev.br \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox